This reverts commit 4d7135f6f2.
This also reverts 3d72f1c08b.
The main reason is that it does not work on PowerShell due
to the tricky way it handles error.
- Though GimpDrawableChooser itself is deprecated, make it call the
new items popup API, which will work just as well.
- gimp_procedure_dialog_get_widget() will now return a GimpItemChooser
widget by default. I did hesitate if for API behavior stability, it
should not still return a GimpDrawableChooser, but considered that if
someone set G_TYPE_NONE, they want our "best choice" and are not
considering tweaking it. If someone wants to make sure this function
always returns a specific widget type, they should specify said type.
So I also added a note in the function docs related to this
assumption.
- Van Gogh plug-in must now use the GimpItemChooser API to set the item
to show. Also I am specifying the widget type, even though it is now
the new default, because of the previous point. Since we tweak further
the widget with its API, let's specify so that any further defaults
update doesn't break this code.
- Adding some pragma to ignore warnings on the few pieces of code where
we have to call deprecated functions (because inside other deprecated
functions themselves).
- gui_pdb_dialog_*() API should just always create GimpItemSelect
dialogs now. Also I ref rather than peek the class, because even if
the class has not been instanciated yet (a case I ran into), we still
want to obtain the class structure.
Also fix a bit of "Since:" annotations, some minor spacing fixing and
remove one useless test (if we test if a type is an item, we don't need
to test the children drawable type).
This patch adds a GimpItemChooser widget
for use in GimpProcedureDialog Item parameter
GUI creation.
This will deprecate the existing
GimpDrawableChooser, as it covers all the
same cases plus others such as GimpPath.
Resolves#15324
GimpSpinScale allows you to raise the value past the defined
limit, which can cause crashes when doing this for Raw Data
(since the upper bounds represent the maximum size of the
file).
For the 3.2 RC1 release, we'll convert back to GimpScaleEntry
and review before the final 3.2 release.
I was avoiding to add this feature because it needs to
download PowerShell (6+) while on PowerShell (5.1) but
MS guys clarified on GitHub that there is no other option.
Even when choosing JPEG, we don't want a layer with transparency to be
stored as JPEG, because it will completely break the render (adding a
background color). So we need to make the JPEG option a "when possible"
one.
If anyone has comments on wording, please tell them!
This is based off ongoing Teams/GIMP/CoreTeam/Discussions#9 discussion
and is meant to take care of worries which were raised in since-reverted
commit c4b4f343d4.
Basically GIMP is not a "toy software" indeed, made to just do quick
one-click edits, such as a quick crop-rotation, or apply common filters
with no options, by finger-swiping, for your social network account. It
is not to say that you cannot do all of this, but this is still part of
a much bigger feature-set, with a lot of advanced options to customize
renders, in a software made for high-end image editing and creation. The
target therefore includes graphics professionals (such as ourselves!),
but not only, which is why the reverted commit was not fine. It can be
amateurs doing high quality work too, and we don't want these creators
and usage to be left out.
The Core Team discussion is about our updated Project Vision. This is an
ongoing discussion which may span for a few more months, possibly until
the next physical meeting of contributors. So far, our Vision is
summarized as one sentence:
> GIMP is Community-driven Free Software for high-end image creation and manipulation.
This sums up several of the main aspects of GIMP: its community and how
it's being created by it, the fact it is Free Software, the fact it
targets high-end creation/manipulation, and the generic aspect of the
type of graphics works (creation or manipulation), because it is not
just about photo retouching.
This commit therefore reuses the current wording in the initial
paragraph of our metadata description. I move one example of such type
of graphics work in the second paragraph and remove the "simple" word,
as it may imply again "toy" and ourselves, as well as many other digital
painters across the world, have proved long ago that this program is not
just to do "simple painting".
This is an update before the RC release (where we will start freezing
strings). Of course, we may update further the text later (when we'll
start working on 3.4 probably), if the Project Vision further evolves.
This patch swaps out the GtkBox in
gimp_enum_icon_box_new_with_toggle ()
with a GtkButtonBox and sets it to EXPAND
so that the buttons are pressed together.
It also adds some CSS style to complete
the effect.
