This reverts commit 4d7135f6f2.
This also reverts 3d72f1c08b.
The main reason is that it does not work on PowerShell due
to the tricky way it handles error.
- Though GimpDrawableChooser itself is deprecated, make it call the
new items popup API, which will work just as well.
- gimp_procedure_dialog_get_widget() will now return a GimpItemChooser
widget by default. I did hesitate if for API behavior stability, it
should not still return a GimpDrawableChooser, but considered that if
someone set G_TYPE_NONE, they want our "best choice" and are not
considering tweaking it. If someone wants to make sure this function
always returns a specific widget type, they should specify said type.
So I also added a note in the function docs related to this
assumption.
- Van Gogh plug-in must now use the GimpItemChooser API to set the item
to show. Also I am specifying the widget type, even though it is now
the new default, because of the previous point. Since we tweak further
the widget with its API, let's specify so that any further defaults
update doesn't break this code.
- Adding some pragma to ignore warnings on the few pieces of code where
we have to call deprecated functions (because inside other deprecated
functions themselves).
- gui_pdb_dialog_*() API should just always create GimpItemSelect
dialogs now. Also I ref rather than peek the class, because even if
the class has not been instanciated yet (a case I ran into), we still
want to obtain the class structure.
Also fix a bit of "Since:" annotations, some minor spacing fixing and
remove one useless test (if we test if a type is an item, we don't need
to test the children drawable type).
This patch adds a GimpItemChooser widget
for use in GimpProcedureDialog Item parameter
GUI creation.
This will deprecate the existing
GimpDrawableChooser, as it covers all the
same cases plus others such as GimpPath.
Resolves#15324
GimpSpinScale allows you to raise the value past the defined
limit, which can cause crashes when doing this for Raw Data
(since the upper bounds represent the maximum size of the
file).
For the 3.2 RC1 release, we'll convert back to GimpScaleEntry
and review before the final 3.2 release.
I was avoiding to add this feature because it needs to
download PowerShell (6+) while on PowerShell (5.1) but
MS guys clarified on GitHub that there is no other option.
Even when choosing JPEG, we don't want a layer with transparency to be
stored as JPEG, because it will completely break the render (adding a
background color). So we need to make the JPEG option a "when possible"
one.
If anyone has comments on wording, please tell them!
