… delete build/ contents.
We were hitting an error on CI:
> ERROR: Uploading artifacts as "archive" to coordinator... 413 Request Entity Too Large […]
Because the .flatpak-builder/ tarball was huge.
After further testing, it turned out that this is a per-file limit,
since simply not compressing the folder and passing it as artifacts
worked, except this time, we were hitting permission issues: artifacts
end up as root on successive jobs, whereas the CI job runs unprivileged
as a "build" user, which doesn't fly with flatpak-builder still needing
to work and touch previous files.
So I'm doing some in-between by compressing sub-folders (the real
advantage is not the compression part, but the archiving in tar, which
preserves ownership and permissions).
Note that while this kinda partly worked, .flatpak-builder/build/ was
still huge, even when compressing .flatpak-builder/build/* contents in
further individual archives. So I just simply drop this data as it's not
needed at all for flatpak-builder caching (cache/ subfolder is).
See also discussions in #2404.
When we fail to read enough bytes when reading uncompressed psp
channels, return with an error.
The error message was copied from the PSD reader so this should not
be affected by the string freeze.
We were not checking whether channel types were valid for grayscale
images. Using a blue color channel caused an invalid computation of
the offset which could cause us to access an invalid memory location.
Now we separate RGB from non-RGB images when checking which channels
are valid, and if not return with an error.
Resolves#3737
We use the CLAMPed value of a pixel component as part
of an operation to select an index. However, CLAMP () does
not behave as expected with NaN values, resulting in the
operation crashing when trying to use an out-of-bounds value
as an index.
This patch adds a check for isnan () to the value before using it.
If it's NaN, then we replace the value with 0.
... to get limits in image coordinates instead of gimp_ruler_get_range.
Rulers return values in the active unit (e.g. mm, inches), while the
overlay logic works in pixels. This unit mismatch caused incorrect
clamping of the text overlay position, making it jump
when dragging if the unit wasn't set to pixels.
GimpLayerTreeView's delete button always deletes
the selected layer(s), even if a mask is selected.
This patch adds a new action button for deleting masks
(using the "layers-mask-delete" action) and conditionally
shows/hides it and the existing delete button based on
whether the mask or the layer is selected.
Note that after 3.2, we may replace this commit with a
single new action that conditionally deletes either the
mask or layer, depending on the selected item.
Note that the option still exists, which allows to not error-out when
using the same set of CLI options on both the GUI and CLI binaries. We
use this ourselves in our build, which is able to use either binaries,
and if -i became forbidden, it'd make complication for our scripts.
Yet since it's basically a no-op on the CLI tool, we might as well hide
it from the usage output.
- Add missing options in the top usage line.
- Add a usage line for gimp-console too, since this same man is used for
both binaries! I only removed -i / --no-interface from the
gimp-console usage.
- Reuse the top paragraph of the AppStream description as the top
paragraph of the man description. This is basically our current
"project vision". I've hesitated rewriting some of the rest in the
description, or reusing more from the AppStream file, but I'm not sure
if package metadata's and CLI man page's descriptions should really be
alike. Also such rewording may be better discussed with others from
the team first.
- Add descriptions for missing options: --quit, --show-playground,
--show-debug-menu and --g-fatal-warnings.
- Add descriptions for environment variables XDG_CONFIG_HOME,
GIMP_DEBUG_FONTS and GIMP_BATCH_INTERPRETER. I didn't list on purpose
a bunch of other environment variables when they are clearly meant to
be for internal use (testing, developer use, etc.).
- Made clear that GIMP3_DIRECTORY is legacy and should not be used if
possible, in favor of XDG_CONFIG_HOME. In particular, config file
format migration won't work across updates with GIMP3_DIRECTORY as we
don't control anymore the relative path format.
- Latest GTK libs are not shipped on our download server anymore.
I can't reproduce this issue, because when I set a fake font file as a
broken symlink, or a file without read access, it is simply not returned
as part of my font list to start with.
But from the issue discussion and traces, this should be the right fix.
… input devices.
Per Carlos' advice on gtk#7534, I wait for us to get a focus, since the
pad devices are only created at that point.
Note that this is a Wayland-only issue, but since it doesn't matter too
much that input devices are not initialized before we have a focused GUI
anyway, let's make this simpler.
At the earliest, the splash focus can announce a focus, but since it is
possible to start GIMP without the splash, display shells will also
possibly announce the first focus (there will always be a display shell
focusing at some point for any GUI GIMP!).
tar doesn't compress on its own, it's just a container format. It
doesn't look like these 2 files are actually used otherwise, apart from
being log artifacts (at least I couldn't find any script decompressing
these).
This is an attempt to reduce size of artifacts on deps-flatpak because
CI complains with a "Request Entity Too Large" error.
