Commit graph

17107 commits

Author SHA1 Message Date
elexis
d074c4d809 Use GUISize constructor instead of string concatenation when only passing absolute values.
Differential Revision: https://code.wildfiregames.com/D471
Reviewed By: bb
This was SVN commit r19554.
2017-05-10 22:29:55 +00:00
elexis
3d8fd6e740 Fix the position of a treasure which couldn't be picked up on the skirmish map Mediterranean Cove.
Patch By: Phormio
Fixes #4566

This was SVN commit r19553.
2017-05-10 16:53:41 +00:00
elexis
bbc7852df8 Use let keyword for cmpTrigger consistently, so that this reference to the component before deserialization can't be reused inside the Trigger component after deserialization which would cause an OOS on rejoin / savegame loading as experienced prior 53570da065.
Differential Revision: https://code.wildfiregames.com/D195
Refs #4310, 53570da065, d124b32f6a
Reviewed By: Sandarac
This was SVN commit r19552.
2017-05-10 14:03:51 +00:00
fatherbushido
11f90549c7 Add missing roundings for garrisoned arrows tooltips. Reviewed by elexis.
Differential Revision: https://code.wildfiregames.com/D470
This was SVN commit r19551.
2017-05-10 13:04:35 +00:00
fatherbushido
bba42de375 Add Iberian heroes auras. Patch by Grugnas.
Differential Revision: https://code.wildfiregames.com/D397
This was SVN commit r19550.
2017-05-10 11:32:26 +00:00
elexis
51655081d8 Botswanan Haven random map.
Differential Revision: https://code.wildfiregames.com/D362
Patch By: Hannibal_Baraq
This was SVN commit r19548.
2017-05-09 20:09:18 +00:00
mimo
d1108516af petra: adapt garrisoning to the attackers
Summary: When a structure with arrow was attacked, it was garrisoned
independently of the attacker, which was not the best answer when
atacked by a ram for example. This patch tries to adapt the garrisoning
to the attackers.

Reviewed By: Sandarac
Differential Revision: https://code.wildfiregames.com/D446
This was SVN commit r19547.
2017-05-09 17:53:59 +00:00
mimo
0517bbb83f cleanup of da4e03b7ad
This was SVN commit r19546.
2017-05-09 16:58:53 +00:00
elexis
8bf732453e Ignore color and font tags when typing something in a Dropdown gui element to select an item.
Differential Revision: https://code.wildfiregames.com/D462
Refs D435
Reviewed By: Vladislav
This was SVN commit r19545.
2017-05-09 13:29:19 +00:00
fatherbushido
228ba51d5c Aura Range tooltip. Reviewed by elexis.
Differential Revision: https://code.wildfiregames.com/D458
This was SVN commit r19544.
2017-05-09 12:55:56 +00:00
elexis
9cfe30c92a Add missing pair of braces as reported by mimo in b4e5858f6d.
This was SVN commit r19542.
2017-05-08 23:40:44 +00:00
elexis
2423e85a88 Add an optional color field to the gamesetup dropdown values, so that autocompleted text of the setting values (especially observernames) doesn't contain the color tag.
Differential Revision: https://code.wildfiregames.com/D435
Reviewed By: Imarok
This was SVN commit r19541.
2017-05-08 23:34:25 +00:00
elexis
36a16a4576 Remove debug breakpoint that is triggered whenever an unsupported UTF32 character is encountered,
for example when someone would send a lobby chat message containing such
a character, it effectively ended the game of the recipients.

Differential Revision: https://code.wildfiregames.com/D456
Fixes #4433
Reviewed By: leper
Reported and tested by: Hannibal_Barca
This was SVN commit r19540.
2017-05-08 22:29:00 +00:00
Imarok
af2f8a95fb Improve training tooltip with multiple selection
Reviewed by: bb. Fixes #4264.
Differential Revision: https://code.wildfiregames.com/D43
This was SVN commit r19538.
2017-05-08 18:13:26 +00:00
Imarok
30823d8988 Make g_EntityCommands use all entities but not only the first
Reviewed by: bb. Fixes #4273.
Differential Revision: https://code.wildfiregames.com/D45
This was SVN commit r19537.
2017-05-08 18:04:43 +00:00
elexis
6826a1355e Display aura tooltips for the entities in the top panel (currently heroes and relics).
Differential Revision: https://code.wildfiregames.com/D340
Reviewed By: fatherbushido (and leper and sanderd17 too basically)
This was SVN commit r19536.
2017-05-08 07:16:43 +00:00
leper
25b1837603 Pass CVector3D as const reference in a few places.
Reviewed By: Sandarac
Differential Revision: https://code.wildfiregames.com/D424
This was SVN commit r19534.
2017-05-08 04:04:45 +00:00
leper
bdfe500f98 Draw paths only when cinematics isn't playing. Patch by Vladislav.
Also show the GUI after the cinematics stopped playing in Atlas.

Differential Revision: https://code.wildfiregames.com/D411
This was SVN commit r19533.
2017-05-08 04:02:33 +00:00
leper
c5ab9925d4 Fix possible null dereferences.
Reviewed By: vladislavbelov
Differential Revision: https://code.wildfiregames.com/D420
This was SVN commit r19532.
2017-05-08 02:41:23 +00:00
leper
631fa4b376 Remove unused old code for triggers in atlas.
Actually implementing atlas support for triggers will most likely
require a different interface, so no use keeping it.

Reviewed By: vladislavbelov
Differential Revision: https://code.wildfiregames.com/D418
This was SVN commit r19531.
2017-05-08 02:40:22 +00:00
Imarok
a397f9bccb Sanitize playername in sanitizePlayerData in gamesetup and remove some hardcodings.
Fixes #4501

Reviewed by: elexis
Differential Revision: https://code.wildfiregames.com/D426
This was SVN commit r19530.
2017-05-07 22:28:56 +00:00
Itms
06bbcd6b76 Revamp of the quotes in the game loading screen, research and patch by Phormio.
Remove the "Quote of the Day" titling which did not make a lot of sense.

Undocumented or misleading quotes removed, new quotes, more historical
context, and literary source for all of them.

Reviewed By: Gallaecio, Itms
Differential Revision: https://code.wildfiregames.com/D296
This was SVN commit r19529.
2017-05-07 22:05:11 +00:00
fatherbushido
1c64742edc Add a type argument for CanAttack method of Attack component. Patch by bb. Fixes #4220.
Differential Revision: https://code.wildfiregames.com/D122
This was SVN commit r19528.
2017-05-07 19:32:59 +00:00
fatherbushido
ca89fa35b9 Edit many aura names. Remove "aura" from the name, use more flavouring name, replace placeholder or generic names. Patch by Hannibal_Barca. Reviewed by elexis.
Differential Revision: https://code.wildfiregames.com/D447
This was SVN commit r19527.
2017-05-07 18:56:14 +00:00
fatherbushido
17aa212c93 Clean a bit auras gui info parsing
Summary: (Title is clumsy)

Test Plan:
Check for example auras tooltip:
structree
entity tooltip
construction panel
wall tooltip too

Reviewers: elexis

Reviewed By: elexis
Subscribers: Vulcan

Differential Revision: https://code.wildfiregames.com/D447
This was SVN commit r19526.
2017-05-07 18:38:41 +00:00
Itms
7d00501a90 Make 81c57e8a28 compatible with wxWidgets 2.8, patch by vladislavbelov.
Reviewed By: Itms
Differential Revision: https://code.wildfiregames.com/D427
This was SVN commit r19525.
2017-05-07 15:49:55 +00:00
Itms
a857ee441e Enable other languages than English in the Windows installer, patch by vladislavbelov.
Reviewed By: Itms
Differential Revision: https://code.wildfiregames.com/D314
This was SVN commit r19524.
2017-05-07 14:38:29 +00:00
mimo
da4e03b7ad petra: hunters/gatherers improvments
Summary:
- better detection (hopefully less false positive due to pathfinder
problems) of inaccessible targets
- prevent hunters from drifting too much when chasing their target

Differential Revision: https://code.wildfiregames.com/D400
This was SVN commit r19523.
2017-05-07 09:25:03 +00:00
fatherbushido
ed72056fb5 Actually delete files in 07233d8cd6.
This was SVN commit r19522.
2017-05-06 14:39:10 +00:00
fatherbushido
07233d8cd6 Remove a not validating unused sound marker template. While at it remove another unused template in the same folder. Patch by Stan.
Differential Revision: https://code.wildfiregames.com/D412
This was SVN commit r19521.
2017-05-06 14:36:06 +00:00
elexis
e6b909bb51 Rename the map Rouen to Ratumacos and make it circular.
Description by Hannibal_Barca.

Differential Revision: https://code.wildfiregames.com/D177
Reviewed By: Grugnas
This was SVN commit r19520.
2017-05-06 01:20:49 +00:00
elexis
ee5bb1fd61 RangeVisualization component and use it to visualize Aura ranges.
Differential Revision: https://code.wildfiregames.com/D238
Fixes #4349
Patch By: Sandarac
This was SVN commit r19519.
2017-05-06 00:47:21 +00:00
elexis
f4ff462449 Select the number of relics to spawn in the gamesetup.
Differential Revision: https://code.wildfiregames.com/D410
Reviewed By: Sandarac
This was SVN commit r19518.
2017-05-05 20:41:37 +00:00
Imarok
4a0673e44e Show all summary values as a graph
Reviewed by: bb
Differential Revision: https://code.wildfiregames.com/D144
This was SVN commit r19517.
2017-05-05 18:52:20 +00:00
Imarok
2f67b2da61 Correctly center ally command buttons
Reviewed by: bb
Differential Revision: https://code.wildfiregames.com/D428
This was SVN commit r19516.
2017-05-05 15:10:12 +00:00
elexis
76bc9b579a Clientside Lobby support for muted players (visitor role).
Displays a chat message and a notification in the player details to
everyone if someone was muted and
hides the chat input to visitors.

Differential Revision: https://code.wildfiregames.com/D339
Reviewed By: user1
This was SVN commit r19514.
2017-05-05 01:13:12 +00:00
mimo
ba37ff9907 petra: remove some unneeded parentheses
This was SVN commit r19513.
2017-05-04 18:48:13 +00:00
Imarok
dad3e3d1bd Add the select all idle workers/fighters hotkey to the manual
Acked by elexis

This was SVN commit r19512.
2017-05-04 12:14:43 +00:00
leper
329f9e0957 Remove broken atlas error reporting code.
This has been disabled for nearly 10 years (44f5288a1d), so remove it.

Reviewed By: fatherbushido, vladislavbelov
Differential Revision: https://code.wildfiregames.com/D423
This was SVN commit r19511.
2017-05-04 09:29:24 +00:00
fatherbushido
bd73588935 Add the missing file in c707999bec. Refs #2524.
This was SVN commit r19510.
2017-05-04 09:17:29 +00:00
fatherbushido
c707999bec Fix Missing props for the old athen fortress. Patch by Stan.
Refs #2524.
Differential Revision: https://code.wildfiregames.com/D352
This was SVN commit r19509.
2017-05-04 09:13:54 +00:00
leper
f794a14610 Declare variable when actually initialized.
Reviewed By: wraitii
Differential Revision: https://code.wildfiregames.com/D417
This was SVN commit r19508.
2017-05-04 06:53:21 +00:00
elexis
4a5f302ce1 Optional FPS Limiter for running games too, use the Slider GUI object in the config to specify custom limits.
Make it way more accurate by excluding the SDL_Wait time and microsecond
precision.

Differential Revision: https://code.wildfiregames.com/D109
Refs #2882
Reviewed By: Vladislav
This was SVN commit r19507.
2017-05-03 23:44:13 +00:00
elexis
dd9b83626e Roman Entrenched Army Camp balancing.
Prevent building it in player owned territory, so as to
  highlight its usage as a building to dominate the enemy in his own
territory and
  prevent the player from building it as a defensive structure right
besides a fortress and civic center.

Increase CapturePoints from 500 to 1500, and RegenRate to 10, so that it
doesn't convert to gaia in 14 seconds but 50.
Reduce GarrisonRegenRate from 5 to 3.
Add minimum distance between two camps.
Increase cost to 500 wood and buff crush armor from 10% to 19%.
Reduce maximum range from 80 meters to 50 meters.

Differential Revision: https://code.wildfiregames.com/D405
Reviewed By: fatherbushido
Reported by PhyZic, discussed with Grugnas.

This was SVN commit r19505.
2017-05-03 12:32:48 +00:00
elexis
b4e5858f6d Unify gamesetup option handling, fixes #3994, refs #3049.
Removes a lot of duplication and ugly GUI handling code with very
similar, yet different code paths.
Move the setting specific logic to the functions of that setting and
keep the universal logic in global atomic functions.
Make gamesetup.xml agnostic of all gamesetup settings.

Adding a new gamesetup option now only requires adding one hunk with the
titles and values and one line in g_OptionOrderGUI.
Opens up the possibility to iterate over all settings, refs #3806,
#3883.

Allow starting singleplayer games in observermode with only AIs
assigned, fixes #4078.
Autocomplete translations of all setting titles and selected title
values like playernames and victory conditions.

Transfer the AI difficulty when swapping with a player.
Move logic from onTick to the GUI handling functions.
Change some global consts to var, so that contributors become invited to
change them from a different place.
Add missing startGameButton tooltip translation.

Differential Revision: https://code.wildfiregames.com/D322
Reviewed By: wraitii
Some strings reviewed By: leper
This was SVN commit r19504.
2017-05-02 20:57:14 +00:00
elexis
09e974e1cb Bump year number of files changed this year in the license headers.
This was SVN commit r19503.
2017-05-01 14:28:22 +00:00
Itms
bb81905245 Add text linting to Arcanist.
This introduces a .arclint file used by Arcanist to run a handful of
checks on patches submitted to Phabricator. To keep it portable and
avoid annoying contributors, most of the linting will happen through
Jenkins. This commit uses built-in text linting that checks trailing
whitespace and end of files.

Reviewed By: leper
Differential Revision: https://code.wildfiregames.com/D6
This was SVN commit r19502.
2017-05-01 14:26:50 +00:00
elexis
0a09bde961 JS lobby cleanup.
Hide chat input and disable buddy toggle button upon disconnect.
Imrpove user profile fetching code readability, move and merge code from
XML.

Differential Revision: https://code.wildfiregames.com/D396
Reviewed By: Vladislav
This was SVN commit r19501.
2017-05-01 13:36:10 +00:00
FeXoR
b22b58f13d Fix scenario .rnc/.rng validation errors.
Patch by vladislavbelov
Differential Revision: https://code.wildfiregames.com/D391
This was SVN commit r19500.
2017-05-01 10:26:36 +00:00
mimo
08c40e23db fix error when civData has no music (as gaia), fixes #4538
This was SVN commit r19499.
2017-05-01 10:03:15 +00:00