dallasgroot/0ad
1
0
Fork 0
mirror of https://gitea.wildfiregames.com/0ad/0ad synced 2026-06-17 13:53:57 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3
0ad/source/gui
History
elexis 1a49ccb294 Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 
Remove PSERROR codes from SetSetting (let std::map throw an out_of_range
if a caller wants to Set a setting that doesn't exist without having
checked with SettingExists, equal to GetSetting from 92b6cdfeab).
That also simplifies std::function SetSettingWrap construct from
0a7d0ecdde to void IGUIObject::SettingChanged.
Don't trigger debug_warn or exceptions in GUITooltip::ShowTooltip if the
XML author specified wrong tooltip input, and dodge another
dynamic_cast.

Rename existing IGUIObject::SetSetting to
IGUIObject::SetSettingFromString and comment that it is purposed for
parsing XML files.
Remove SetSetting default value, so that authors are made aware
explicitly of the need to decide the function broadcasting a message,
refs d87057b1c0, 719f2d7967, ...
Change const bool& SkipMessage to const bool SendMessage, so that a
positive value relates to a positive action.
Clean AddSettings whitespace and integer types.

Differential Revision: https://code.wildfiregames.com/D2231
Tested on: gcc 9.1.0, clang 8.0.1, Jenkins
Comments By: Philip on IRC on 2010-07-24 on GUIUtil being ugly, in case
that one counts

This was SVN commit r22796.
2019-08-28 11:21:11 +00:00
..
scripting Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
tests Move GUI string parsing specializations to a separate file and remove __ParseString proxy. 2019-08-19 19:43:13 +00:00
CButton.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
CButton.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CChart.cpp Move static GUI<>::GetSetting operating on IGUIObject member to a IGUIObject member function, grouping it with SettingExists and AddSetting. 2019-08-26 12:25:07 +00:00
CChart.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CCheckBox.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
CCheckBox.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CDropDown.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
CDropDown.h Mark some GUI functions as const, including the boolean ones from d4d5187c9d. 2019-08-22 23:51:10 +00:00
CGUI.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
CGUI.h Use variadic template for RecurseObject from c2a71e41bf and move it from GUIutil to IGUIObject. 2019-08-21 13:22:25 +00:00
CGUIColor.cpp Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CGUIColor.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CGUIList.h Split CGUIString.h from GUIText.h, so that one may have the SGUIText implementation in a separate cpp file. 2019-08-10 19:16:52 +00:00
CGUIScrollBarVertical.cpp Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CGUIScrollBarVertical.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CGUISeries.h Use NONCOPYABLE for most GUI classes and structs to have the compiler indicate unintended copies, refs 3028551b91 / D2163. 2019-08-10 00:04:17 +00:00
CGUISprite.cpp Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CGUISprite.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CGUIString.cpp Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CGUIString.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CGUIText.cpp Move static GUI<>::GetSetting operating on IGUIObject member to a IGUIObject member function, grouping it with SettingExists and AddSetting. 2019-08-26 12:25:07 +00:00
CGUIText.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CImage.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
CImage.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CInput.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
CInput.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CList.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
CList.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
COList.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
COList.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CProgressBar.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
CProgressBar.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CRadioButton.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
CRadioButton.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CSlider.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
CSlider.h Mark some GUI functions as const, including the boolean ones from d4d5187c9d. 2019-08-22 23:51:10 +00:00
CText.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
CText.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
CTooltip.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
CTooltip.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
GUI.h Move CGUI::GenerateText to CGUIText constructor, CGUI::DrawText to CGUIText::Draw, SGenerateTextImage from CGUI to CGUIText. 2019-08-17 01:32:11 +00:00
GUIbase.cpp Move CClientArea ToJSVal / FromJSVal conversion from JSI_IGUIObject (since that should be agnostic of the conversion) to CClientArea (since that defines the properties). 2019-07-26 14:47:27 +00:00
GUIbase.h Use variadic template for RecurseObject from c2a71e41bf and move it from GUIutil to IGUIObject. 2019-08-21 13:22:25 +00:00
GUIManager.cpp Fix valgrind conditional jump depending on uninitialised value warning in CGUIManager::HandleEvent from 7c2e9027c2. 2019-08-24 22:25:26 +00:00
GUIManager.h Mark some GUI functions as const, including the boolean ones from d4d5187c9d. 2019-08-22 23:51:10 +00:00
GUIMatrix.cpp Move GetDefaultGuiMatrix to a separate file. 2019-08-04 03:52:00 +00:00
GUIMatrix.h Move GetDefaultGuiMatrix to a separate file. 2019-08-04 03:52:00 +00:00
GUIRenderer.cpp Remove unused GUIUtil functions, unused GUI includes and some tails in GUIUtil. 2019-08-25 08:57:36 +00:00
GUIRenderer.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
GUIStringConversions.cpp Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
GUITooltip.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
GUITooltip.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
GUItypes.h Remove unused GUIUtil functions, unused GUI includes and some tails in GUIUtil. 2019-08-25 08:57:36 +00:00
GUIutil.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
GUIutil.h Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
IGUIButtonBehavior.cpp Move static GUI<>::GetSetting operating on IGUIObject member to a IGUIObject member function, grouping it with SettingExists and AddSetting. 2019-08-26 12:25:07 +00:00
IGUIButtonBehavior.h Use variadic template for RecurseObject from c2a71e41bf and move it from GUIutil to IGUIObject. 2019-08-21 13:22:25 +00:00
IGUIObject.cpp Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
IGUIObject.h Move static GUI<>::SetSetting operating on IGUIObject to a member IGUIObject::SetSetting. 2019-08-28 11:21:11 +00:00
IGUIScrollBar.cpp Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
IGUIScrollBar.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
IGUIScrollBarOwner.cpp Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
IGUIScrollBarOwner.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
IGUITextOwner.cpp Move static GUI<>::GetSetting operating on IGUIObject member to a IGUIObject member function, grouping it with SettingExists and AddSetting. 2019-08-26 12:25:07 +00:00
IGUITextOwner.h Use CGUI& instead of CGUI* so that the 50+ users stop wondering whether or not that is null and can't even be mistaken to add redundant null checks preemptively. 2019-08-21 10:12:33 +00:00
MiniMap.cpp Mark some GUI functions as const, including the boolean ones from d4d5187c9d. 2019-08-22 23:51:10 +00:00
MiniMap.h Mark some GUI functions as const, including the boolean ones from d4d5187c9d. 2019-08-22 23:51:10 +00:00