mirror of
https://gitea.wildfiregames.com/0ad/0ad
synced 2026-06-16 05:13:58 -07:00
1a49ccb294
Remove PSERROR codes from SetSetting (let std::map throw an out_of_range if a caller wants to Set a setting that doesn't exist without having checked with SettingExists, equal to GetSetting from92b6cdfeab). That also simplifies std::function SetSettingWrap construct from0a7d0ecddeto void IGUIObject::SettingChanged. Don't trigger debug_warn or exceptions in GUITooltip::ShowTooltip if the XML author specified wrong tooltip input, and dodge another dynamic_cast. Rename existing IGUIObject::SetSetting to IGUIObject::SetSettingFromString and comment that it is purposed for parsing XML files. Remove SetSetting default value, so that authors are made aware explicitly of the need to decide the function broadcasting a message, refsd87057b1c0,719f2d7967, ... Change const bool& SkipMessage to const bool SendMessage, so that a positive value relates to a positive action. Clean AddSettings whitespace and integer types. Differential Revision: https://code.wildfiregames.com/D2231 Tested on: gcc 9.1.0, clang 8.0.1, Jenkins Comments By: Philip on IRC on 2010-07-24 on GUIUtil being ugly, in case that one counts This was SVN commit r22796.
86 lines
2.3 KiB
C++
86 lines
2.3 KiB
C++
/* Copyright (C) 2019 Wildfire Games.
|
|
* This file is part of 0 A.D.
|
|
*
|
|
* 0 A.D. is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* 0 A.D. is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with 0 A.D. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "precompiled.h"
|
|
|
|
#include "GUIutil.h"
|
|
|
|
#include "gui/GUI.h"
|
|
|
|
template<typename T>
|
|
CGUISetting<T>::CGUISetting(IGUIObject& pObject, const CStr& Name)
|
|
: m_pSetting(T()), m_Name(Name), m_pObject(pObject)
|
|
{
|
|
}
|
|
|
|
template<typename T>
|
|
bool CGUISetting<T>::FromString(const CStrW& Value, const bool SendMessage)
|
|
{
|
|
T settingValue;
|
|
|
|
if (!GUI<T>::ParseString(&m_pObject.GetGUI(), Value, settingValue))
|
|
return false;
|
|
|
|
m_pObject.SetSetting<T>(m_Name, settingValue, SendMessage);
|
|
return true;
|
|
};
|
|
|
|
template<>
|
|
bool CGUISetting<CGUIColor>::FromJSVal(JSContext* cx, JS::HandleValue Value, const bool SendMessage)
|
|
{
|
|
CGUIColor settingValue;
|
|
if (Value.isString())
|
|
{
|
|
CStr name;
|
|
if (!ScriptInterface::FromJSVal(cx, Value, name))
|
|
return false;
|
|
|
|
if (!settingValue.ParseString(m_pObject.GetGUI(), name))
|
|
{
|
|
JS_ReportError(cx, "Invalid color '%s'", name.c_str());
|
|
return false;
|
|
}
|
|
}
|
|
else if (!ScriptInterface::FromJSVal<CColor>(cx, Value, settingValue))
|
|
return false;
|
|
|
|
m_pObject.SetSetting<CGUIColor>(m_Name, settingValue, SendMessage);
|
|
return true;
|
|
};
|
|
|
|
template<typename T>
|
|
bool CGUISetting<T>::FromJSVal(JSContext* cx, JS::HandleValue Value, const bool SendMessage)
|
|
{
|
|
T settingValue;
|
|
if (!ScriptInterface::FromJSVal<T>(cx, Value, settingValue))
|
|
return false;
|
|
|
|
m_pObject.SetSetting<T>(m_Name, settingValue, SendMessage);
|
|
return true;
|
|
};
|
|
|
|
template<typename T>
|
|
void CGUISetting<T>::ToJSVal(JSContext* cx, JS::MutableHandleValue Value)
|
|
{
|
|
ScriptInterface::ToJSVal<T>(cx, Value, m_pSetting);
|
|
};
|
|
|
|
#define TYPE(T) \
|
|
template class CGUISetting<T>; \
|
|
|
|
#include "GUItypes.h"
|
|
#undef TYPE
|