Commit graph

17123 commits

Author SHA1 Message Date
elexis
aa5f3e7d32 Fix the most annoying instance of the persist-matchsettings-bugs that prevented players to build the Ptolemian lighthouse in case of previously having selected a map where that template is disabled.
Most recently reported by nigel87.

Differential Revision: https://code.wildfiregames.com/D489
Reviewed By: Grugnas
Refs #3883

This was SVN commit r19573.
2017-05-13 17:15:16 +00:00
mimo
1f1b179202 petra: take restricted classes into account
This patch implements some changes needed to take restricted classes
into account for example for D450, but it does not claim to be complete.
This will have to be fully tested when these restrictions are really
used.
Tested by fatherbushido using D450

Differential Revision: https://code.wildfiregames.com/D473
This was SVN commit r19572.
2017-05-13 15:14:23 +00:00
mimo
fe2e0fa02f follow-up and complement of D446 to adapt garrisoning to the structure attackers
Summary:
- take the healthLevel of the units into account
- take Sandarac comments on D446 into account

Differential Revision: https://code.wildfiregames.com/D468
This was SVN commit r19571.
2017-05-13 15:04:04 +00:00
mimo
e8c6b09c4f Reset the alert of ProductionQueues when ownerShip changes, fixes #4571
This was SVN commit r19570.
2017-05-13 14:52:23 +00:00
fatherbushido
ae3b66a778 Make phase technology researchable in all captured civic center. Reviewed by elexis. Fix #4572.
This was SVN commit r19569.
2017-05-13 13:58:27 +00:00
elexis
57e767ac08 Gamesetup cleanup: Merge two adjacent identical loops in sanitizePlayerData.
Reviewed By: Imarok
This was SVN commit r19567.
2017-05-12 18:08:14 +00:00
fatherbushido
ac83155197 Remove reference to range in aura description. Patch by Grugnas.
Differential Revision: https://code.wildfiregames.com/D464
This was SVN commit r19566.
2017-05-12 17:09:07 +00:00
fatherbushido
5f4d5cdf76 Remove a leftover argument in GetSimulationState call. Refs 00ea7763f7. Reviewed by elexis and echotangoecho.
Differential Revision: https://code.wildfiregames.com/D479
This was SVN commit r19565.
2017-05-12 16:20:56 +00:00
Imarok
31a41ab735 Fix warning when quitting the game during loading. Patch by bb.
Also contains some `StatistcTracker` cleanup.

Differential Revision: https://code.wildfiregames.com/D475
This was SVN commit r19564.
2017-05-12 14:21:28 +00:00
Imarok
77246af17a Avoid NetClient FSM error when pausing while loading the game.
Patch by echotangoecho. Closes ec1696ded3. Fixes #4261.

Differential Revision: https://code.wildfiregames.com/D472
This was SVN commit r19563.
2017-05-12 13:22:29 +00:00
elexis
00c4adfae8 Add missing Hexify call to the OOS dialog in D105 that became required with the hash comparison in JS. Reported by causative.
Differential Revision: https://code.wildfiregames.com/D476
Reviewed By: leper
This was SVN commit r19562.
2017-05-12 08:50:20 +00:00
leper
51f7502bb1 Don't move temporaries, so possibly allowing for copy elision.
Pointed out by clang's -Wpessimizing-move.

Reviewed By: wraitii
Differential Revision: https://code.wildfiregames.com/D421
This was SVN commit r19559.
2017-05-11 23:24:54 +00:00
elexis
6e549bfed2 Prohibit cheats if cheats are disabled,
i.e. developer cheats to control enemy units, revealing the map and
promoting units too.

Open the developer overlay only if cheats are enabled (which is always
the case in singleplayer mode and only the case in multiplayer mode if
explicitly enabled).
(This doesn't make it harder for developers to "debug", since they
previously had to remember to disable the rated game setting too. Also
every bug had to be reproduced with the replay either way)

Reverts 3cbbf31173 which reverted 6e0e607b20 (since as of c288278229,
the autostart gamesetup enables cheats too).

Differential Revision: https://code.wildfiregames.com/D455
Fixes #3551
Reviewed By: echotangoecho
Agreed with Itms and Imarok in the last staff meeting.

This was SVN commit r19558.
2017-05-11 22:49:54 +00:00
elexis
c288278229 Enable cheats in autostarted games because the JS gamesetup enables them in singleplayer and because the autostarted multiplayer mode relies on the change-perspective feature to control players.
Differential Revision: https://code.wildfiregames.com/D453
Refs #2676
Reviewed By: echotangoecho
This was SVN commit r19557.
2017-05-11 22:32:41 +00:00
elexis
3cd2055ca7 Use self-closing tags for empty elements everywhere (refs d21c0026ec and 06bbcd6b76).
This was SVN commit r19556.
2017-05-11 22:11:25 +00:00
elexis
9ef3447b2a Fix missing escaping in 06bbcd6b76. Reported by Vladislav, patch by Phormio.
This was SVN commit r19555.
2017-05-11 21:37:27 +00:00
elexis
d074c4d809 Use GUISize constructor instead of string concatenation when only passing absolute values.
Differential Revision: https://code.wildfiregames.com/D471
Reviewed By: bb
This was SVN commit r19554.
2017-05-10 22:29:55 +00:00
elexis
3d8fd6e740 Fix the position of a treasure which couldn't be picked up on the skirmish map Mediterranean Cove.
Patch By: Phormio
Fixes #4566

This was SVN commit r19553.
2017-05-10 16:53:41 +00:00
elexis
bbc7852df8 Use let keyword for cmpTrigger consistently, so that this reference to the component before deserialization can't be reused inside the Trigger component after deserialization which would cause an OOS on rejoin / savegame loading as experienced prior 53570da065.
Differential Revision: https://code.wildfiregames.com/D195
Refs #4310, 53570da065, d124b32f6a
Reviewed By: Sandarac
This was SVN commit r19552.
2017-05-10 14:03:51 +00:00
fatherbushido
11f90549c7 Add missing roundings for garrisoned arrows tooltips. Reviewed by elexis.
Differential Revision: https://code.wildfiregames.com/D470
This was SVN commit r19551.
2017-05-10 13:04:35 +00:00
fatherbushido
bba42de375 Add Iberian heroes auras. Patch by Grugnas.
Differential Revision: https://code.wildfiregames.com/D397
This was SVN commit r19550.
2017-05-10 11:32:26 +00:00
elexis
51655081d8 Botswanan Haven random map.
Differential Revision: https://code.wildfiregames.com/D362
Patch By: Hannibal_Baraq
This was SVN commit r19548.
2017-05-09 20:09:18 +00:00
mimo
d1108516af petra: adapt garrisoning to the attackers
Summary: When a structure with arrow was attacked, it was garrisoned
independently of the attacker, which was not the best answer when
atacked by a ram for example. This patch tries to adapt the garrisoning
to the attackers.

Reviewed By: Sandarac
Differential Revision: https://code.wildfiregames.com/D446
This was SVN commit r19547.
2017-05-09 17:53:59 +00:00
mimo
0517bbb83f cleanup of da4e03b7ad
This was SVN commit r19546.
2017-05-09 16:58:53 +00:00
elexis
8bf732453e Ignore color and font tags when typing something in a Dropdown gui element to select an item.
Differential Revision: https://code.wildfiregames.com/D462
Refs D435
Reviewed By: Vladislav
This was SVN commit r19545.
2017-05-09 13:29:19 +00:00
fatherbushido
228ba51d5c Aura Range tooltip. Reviewed by elexis.
Differential Revision: https://code.wildfiregames.com/D458
This was SVN commit r19544.
2017-05-09 12:55:56 +00:00
elexis
9cfe30c92a Add missing pair of braces as reported by mimo in b4e5858f6d.
This was SVN commit r19542.
2017-05-08 23:40:44 +00:00
elexis
2423e85a88 Add an optional color field to the gamesetup dropdown values, so that autocompleted text of the setting values (especially observernames) doesn't contain the color tag.
Differential Revision: https://code.wildfiregames.com/D435
Reviewed By: Imarok
This was SVN commit r19541.
2017-05-08 23:34:25 +00:00
elexis
36a16a4576 Remove debug breakpoint that is triggered whenever an unsupported UTF32 character is encountered,
for example when someone would send a lobby chat message containing such
a character, it effectively ended the game of the recipients.

Differential Revision: https://code.wildfiregames.com/D456
Fixes #4433
Reviewed By: leper
Reported and tested by: Hannibal_Barca
This was SVN commit r19540.
2017-05-08 22:29:00 +00:00
Imarok
af2f8a95fb Improve training tooltip with multiple selection
Reviewed by: bb. Fixes #4264.
Differential Revision: https://code.wildfiregames.com/D43
This was SVN commit r19538.
2017-05-08 18:13:26 +00:00
Imarok
30823d8988 Make g_EntityCommands use all entities but not only the first
Reviewed by: bb. Fixes #4273.
Differential Revision: https://code.wildfiregames.com/D45
This was SVN commit r19537.
2017-05-08 18:04:43 +00:00
elexis
6826a1355e Display aura tooltips for the entities in the top panel (currently heroes and relics).
Differential Revision: https://code.wildfiregames.com/D340
Reviewed By: fatherbushido (and leper and sanderd17 too basically)
This was SVN commit r19536.
2017-05-08 07:16:43 +00:00
leper
25b1837603 Pass CVector3D as const reference in a few places.
Reviewed By: Sandarac
Differential Revision: https://code.wildfiregames.com/D424
This was SVN commit r19534.
2017-05-08 04:04:45 +00:00
leper
bdfe500f98 Draw paths only when cinematics isn't playing. Patch by Vladislav.
Also show the GUI after the cinematics stopped playing in Atlas.

Differential Revision: https://code.wildfiregames.com/D411
This was SVN commit r19533.
2017-05-08 04:02:33 +00:00
leper
c5ab9925d4 Fix possible null dereferences.
Reviewed By: vladislavbelov
Differential Revision: https://code.wildfiregames.com/D420
This was SVN commit r19532.
2017-05-08 02:41:23 +00:00
leper
631fa4b376 Remove unused old code for triggers in atlas.
Actually implementing atlas support for triggers will most likely
require a different interface, so no use keeping it.

Reviewed By: vladislavbelov
Differential Revision: https://code.wildfiregames.com/D418
This was SVN commit r19531.
2017-05-08 02:40:22 +00:00
Imarok
a397f9bccb Sanitize playername in sanitizePlayerData in gamesetup and remove some hardcodings.
Fixes #4501

Reviewed by: elexis
Differential Revision: https://code.wildfiregames.com/D426
This was SVN commit r19530.
2017-05-07 22:28:56 +00:00
Itms
06bbcd6b76 Revamp of the quotes in the game loading screen, research and patch by Phormio.
Remove the "Quote of the Day" titling which did not make a lot of sense.

Undocumented or misleading quotes removed, new quotes, more historical
context, and literary source for all of them.

Reviewed By: Gallaecio, Itms
Differential Revision: https://code.wildfiregames.com/D296
This was SVN commit r19529.
2017-05-07 22:05:11 +00:00
fatherbushido
1c64742edc Add a type argument for CanAttack method of Attack component. Patch by bb. Fixes #4220.
Differential Revision: https://code.wildfiregames.com/D122
This was SVN commit r19528.
2017-05-07 19:32:59 +00:00
fatherbushido
ca89fa35b9 Edit many aura names. Remove "aura" from the name, use more flavouring name, replace placeholder or generic names. Patch by Hannibal_Barca. Reviewed by elexis.
Differential Revision: https://code.wildfiregames.com/D447
This was SVN commit r19527.
2017-05-07 18:56:14 +00:00
fatherbushido
17aa212c93 Clean a bit auras gui info parsing
Summary: (Title is clumsy)

Test Plan:
Check for example auras tooltip:
structree
entity tooltip
construction panel
wall tooltip too

Reviewers: elexis

Reviewed By: elexis
Subscribers: Vulcan

Differential Revision: https://code.wildfiregames.com/D447
This was SVN commit r19526.
2017-05-07 18:38:41 +00:00
Itms
7d00501a90 Make 81c57e8a28 compatible with wxWidgets 2.8, patch by vladislavbelov.
Reviewed By: Itms
Differential Revision: https://code.wildfiregames.com/D427
This was SVN commit r19525.
2017-05-07 15:49:55 +00:00
Itms
a857ee441e Enable other languages than English in the Windows installer, patch by vladislavbelov.
Reviewed By: Itms
Differential Revision: https://code.wildfiregames.com/D314
This was SVN commit r19524.
2017-05-07 14:38:29 +00:00
mimo
da4e03b7ad petra: hunters/gatherers improvments
Summary:
- better detection (hopefully less false positive due to pathfinder
problems) of inaccessible targets
- prevent hunters from drifting too much when chasing their target

Differential Revision: https://code.wildfiregames.com/D400
This was SVN commit r19523.
2017-05-07 09:25:03 +00:00
fatherbushido
ed72056fb5 Actually delete files in 07233d8cd6.
This was SVN commit r19522.
2017-05-06 14:39:10 +00:00
fatherbushido
07233d8cd6 Remove a not validating unused sound marker template. While at it remove another unused template in the same folder. Patch by Stan.
Differential Revision: https://code.wildfiregames.com/D412
This was SVN commit r19521.
2017-05-06 14:36:06 +00:00
elexis
e6b909bb51 Rename the map Rouen to Ratumacos and make it circular.
Description by Hannibal_Barca.

Differential Revision: https://code.wildfiregames.com/D177
Reviewed By: Grugnas
This was SVN commit r19520.
2017-05-06 01:20:49 +00:00
elexis
ee5bb1fd61 RangeVisualization component and use it to visualize Aura ranges.
Differential Revision: https://code.wildfiregames.com/D238
Fixes #4349
Patch By: Sandarac
This was SVN commit r19519.
2017-05-06 00:47:21 +00:00
elexis
f4ff462449 Select the number of relics to spawn in the gamesetup.
Differential Revision: https://code.wildfiregames.com/D410
Reviewed By: Sandarac
This was SVN commit r19518.
2017-05-05 20:41:37 +00:00
Imarok
4a0673e44e Show all summary values as a graph
Reviewed by: bb
Differential Revision: https://code.wildfiregames.com/D144
This was SVN commit r19517.
2017-05-05 18:52:20 +00:00