As for any invalid argument reject them and cleanly exit with failure
status.
Fixes: #7687
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
(cherry picked from commit 958e6de9d3)
Signed-off-by: phosit <phosit@autistici.org>
Requested in #8244 for scripting purposes and automated testing. Extend
the original design by adding a means to pass an exit status. This also
comes in handy in case one wants to cleanly error out from JS on parsing
errors of command line arguments as reported in #7967.
Fixes: #8244
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
(cherry picked from commit 0d60bdfd2e)
Signed-off-by: phosit <phosit@autistici.org>
While in combat, if units are promoted and the promotion results
in a change in their attack range, this could trigger some errors
as 'this.template[type]' had a chance to be undefined when performing
a 'RepeatRangeCheck'.
Fixes#8670
(cherry picked from commit 68e625ab7a)
Signed-off-by: phosit <phosit@autistici.org>
The gendered citizen feature changed stat counter names in
3592814aa8 which are submitted to echelon
for rated games with the game report, the change in name for the property
means it no longer matches the database column name effectively breaking
rated games.
Translate the property name on the fly.
Fixes: #8687
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
(cherry picked from commit 0691e7f0ff)
Signed-off-by: phosit <phosit@autistici.org>
5741f77c6e and b5256ce014 added new translatable strings for game
settings, but missed adding them to
binaries/data/mods/public/l10n/messages.json to get them properly
extracted into the PO-templates for translation. This commit fixes that.
(cherry picked from commit f4c52e49a7)
Signed-off-by: phosit <phosit@autistici.org>
Some translatable strings in XML files have leading and trailing line
breaks and tabs. As these characters are significant in text in XML
files, they don't belong there.
Refs: #8649
(cherry picked from commit 8f8d1195c2)
Signed-off-by: phosit <phosit@autistici.org>
The `onTick` of the register-page was still running when connecting to
the lobby. This lead to an error when the `connect` message was
received.
With this commit returning from the login-page will always return to the
entrance-page. Previously it returned to the register-page when it was
opened by through that page.
(cherry picked from commit 0b83e24065)
Signed-off-by: phosit <phosit@autistici.org>
This change reduces the disk space requirement by 50%, from 1.1 GB down to 564 MB.
It is relevant when building 0AD in resource-constrained environments (e.g. in CI).
(cherry picked from commit 8bd0d0b84f)
Signed-off-by: phosit <phosit@autistici.org>
This is a regression of a fix in 7e481b73cd,
lost during the git migration. Refs #1819
(cherry picked from commit d1319179f8)
Signed-off-by: phosit <phosit@autistici.org>
The 'PopulationLimit' attribute of each player seems to have been
without effect for a long time, but this patch fixes it.
Fixes#7850
(cherry picked from commit 9b8ff77265)
Signed-off-by: phosit <phosit@autistici.org>
It was added in 670f1e5d42 and, while not illegal, was inconsistent with the
rest of the header file, which caused compiler warnings.
As a quick solution the override keyword is simply removed again.
In the long run, it would be good to still modernise the style of all files
in that directory (at once).
(cherry picked from commit 2e450f0f52)
Signed-off-by: phosit <phosit@autistici.org>
After 734386ce9f the new font system calculate height and cap height,
previously was having some magic number. Now we are using cap height
divide 2 to give a more nice space.
Remove an extra pixel in the buffer and improves background color for
better reading and eye care.
This also support the change console font option added in d549cbeeaaFixes: #8351
(cherry picked from commit 8e820a988e)
Signed-off-by: phosit <phosit@autistici.org>
Currently CalculateStringSize can't handle empty string (see #8630).
As a simple fix for RC just avoid drawing empty texts.
Refs: #8630
(cherry picked from commit df9c6f510c)
Signed-off-by: phosit <phosit@autistici.org>
The NSIS script incorrectly passes the default installation dir as
argument for the auto-uninstaller of previous installs.
This is supposed to avoid moving the uninstaller to a temp file, but it
is unclear why that was done, as this leaves the uninstaller behind.
More importantly, now that we have changed the default installation
directory, the auto-uninstall tries to remove the previous install from
the new location, which does nothing and leaves behind several GB on the
disk.
(cherry picked from commit 771bf0ba08)
Signed-off-by: phosit <phosit@autistici.org>
In fb98f5059a the manager was refactored
and the order of deinitialization was incorrectly changed.
(cherry picked from commit cea77c497c)
Signed-off-by: phosit <phosit@autistici.org>
-Make clubmen champion macemen and remove buiding ability to ensure they are not mistaken for CS units.
-Decrease obstruction size of houses (clunky to place in staff match)
-Encampents only allowed in own/neutral territory
-'fear' icon used for Lugius vision aura instead of movement speed.
- Make covered wagons unable to research house techs and train civilians.
(cherry picked from commit ec19e5d663)
Signed-off-by: phosit <phosit@autistici.org>
Currently CRenderingOptions are initialized only once on the application
start. It means changed m_GPUSkinning wasn't reset on the switch to Atlas.
Fixes#8596
(cherry picked from commit f43e98da09)
Signed-off-by: phosit <phosit@autistici.org>
This wasn't possible because init functions are called inside each
other and the outer one overwrites the result of the inner one.
Now the outer result doesn't overwrite the inner result but stores it to
the pointed to location.
(cherry picked from commit e62eb96092)
Signed-off-by: phosit <phosit@autistici.org>
Engine.GetTextWidth has been deprecated since e845da025a
Idea:
If you look at a dropdown as just a text field (its header) that can
change caption like any other, then getPreferredHeaderTextSize is the
equivalent to getPreferredTextSize (present on buttons and text fields).
Fixes#8493
(cherry picked from commit 670f1e5d42)
Signed-off-by: phosit <phosit@autistici.org>
The JavaScript error wasn't propagated leading to an infinite loop.
Fixes: #7967
(cherry picked from commit 14a5ccee52)
Signed-off-by: phosit <phosit@autistici.org>
It is extremely prone to timeouts and failures in this environment.
(cherry picked from commit ac36758b21)
Signed-off-by: phosit <phosit@autistici.org>
Add a civ restriction to make the bonus only apply to Carthage.
(cherry picked from commit 8d38ecda26)
(cherry picked from commit a03b01c935)
(cherry picked from commit f30271e955)
(cherry picked from commit 9c836d39e6)
(cherry picked from commit 91baeeb94e)
(cherry picked from commit cb3fecfce9)
Signed-off-by: phosit <phosit@autistici.org>
Commit b90280855f added support for
multiplayer saved games changing the signature of StartNetworkHost
without updating all callers.
Fixes: #7684
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
(cherry picked from commit 31a262ff7e)
Signed-off-by: phosit <phosit@autistici.org>
As 0 A.D. supports full unicode now and Vietnamese language coverage is
at a good level, let's include Vietnamese as supported language.
(cherry picked from commit 0086f005d4)
Signed-off-by: phosit <phosit@autistici.org>
While Catalan got removed for Alpha 27 because of low coverage, its
coverage is now good enough again to get re-added as supported language.
(cherry picked from commit ed1bd1d75b)
Signed-off-by: phosit <phosit@autistici.org>
When a script in "simulation/helpers/" contained an error. Files in
"simulation/components" aren't loaded. The return value of
`LoadDefaultScripts` indicated an error but was ignored. The simulation
still tried to start.
Now instead of returning a ignoreable error code the error is thrown. In
the common path the error is implicitly rethrown to the JS-function
which tried to start the game.
fixes: #8133
(cherry picked from commit 9a526bcae1)
Signed-off-by: phosit <phosit@autistici.org>
It's not permitted to pass a nullptr to the `app_hooks_update`. So a
reference should be used.
CppCheck says one shouldn't take pointer to a temporary.
(cherry picked from commit 977bf5c0d1)
Signed-off-by: phosit <phosit@autistici.org>
CppCheck wasn't able to handle `{0}`. C++20 allows to use designated
initializers.
(cherry picked from commit b17c2fb80f)
Signed-off-by: phosit <phosit@autistici.org>
'StatusName', 'ApplierTooltip' and 'ReceiverTooltip' are attributes of status
effects, which are defined in JSON files (and already extracted
correctly from there), not XMLs.
(cherry picked from commit 44984699f1)
Signed-off-by: phosit <phosit@autistici.org>
Add context and comment attributes to all translated XML elements in the
simulation that can specify any string -- unlike "Rank", which has to be
"Basic", "Advanced", or "Elite".
Most of them aren't used right now, but they can be in the
future and by mods, without touching the schemas again.
Fixes#8540
(cherry picked from commit 7032293207)
Signed-off-by: phosit <phosit@autistici.org>
Include the shared library libAtlasUI.
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
(cherry picked from commit 5609492731)
Signed-off-by: phosit <phosit@autistici.org>
