Commit graph

9325 commits

Author SHA1 Message Date
Michael Natterer
17287617d9 factored out utility function gimp_display_shell_update_focus() which sets
2007-07-27  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell-callbacks.c: factored out utility
	function gimp_display_shell_update_focus() which sets the active
	tool into the proper state after the canvas received focus.

	(gimp_display_shell_canvas_tool_events): use it here instead of
	duplicating the code 3 times.

	(gimp_display_shell_ruler_button_press): use it here too so the
	move and color tools don't do weird things in click-to-focus
	mode (when FOCUS_IN is delivered after BUTTON_PRESS).


svn path=/trunk/; revision=23020
2007-07-27 09:39:12 +00:00
Sven Neumann
bbdb6da18f moved common code into new utility function
2007-07-26  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-dnd.c: moved common code into new
	utility function gimp_display_shell_dnd_flush(). Also move focus
	to the image window from this function.

svn path=/trunk/; revision=23012
2007-07-26 10:52:39 +00:00
Sven Neumann
f29621ae1f added a sanity check.
2007-07-26  Sven Neumann  <sven@gimp.org>

	* app/paint/gimpbrushcore.c (gimp_brush_core_interpolate): added a
	sanity check.

svn path=/trunk/; revision=23011
2007-07-26 10:20:54 +00:00
Sven Neumann
7e4e919152 added new procedure gimp-progress-end.
2007-07-25  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/progress.pdb: added new procedure gimp-progress-end.

	* app/pdb/progress_cmds.c
	* app/pdb/internal_procs.c
	* libgimp/gimpprogress_pdb.[ch]: regenerated.

	* plug-ins/print/print.[ch]
	* plug-ins/print/print-settings.[ch]: end the progress and save
	the settings from the "end-print" handler. The plug-in then
	appears finished but keeps running in the background until it has
	finished the print operation.

svn path=/trunk/; revision=22994
2007-07-25 10:48:25 +00:00
Michael Natterer
c180bc4590 don't have the tool release ALT when the user releases CONTROL. Fixes
2007-07-25  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimptool.c (gimp_tool_set_active_modifier_state):
	don't have the tool release ALT when the user releases CONTROL.
	Fixes another stuck modifier instance and other modifier
	weirdness.


svn path=/trunk/; revision=22992
2007-07-25 00:39:01 +00:00
Sven Neumann
f14d05ed52 INSTALL configure.in depend on gtk+ >= 2.10.13. Fixes bug #436242.
2007-07-24  Sven Neumann  <sven@gimp.org>

	* INSTALL
	* configure.in
	* app/gui/gui.c: depend on gtk+ >= 2.10.13. Fixes bug #436242.

	* configure.in: no need to AC_SUBST() GIMP_API_VERSION twice.

svn path=/trunk/; revision=22984
2007-07-24 13:46:47 +00:00
Sven Neumann
9b96fc8e4c minor code cleanup.
2007-07-23  Sven Neumann  <sven@gimp.org>

	* app/core/gimpprojection-construct.c: minor code cleanup.


svn path=/trunk/; revision=22976
2007-07-23 20:14:28 +00:00
Sven Neumann
7963f0fc30 added convenience function gimp_action_group_activate_action().
2007-07-23  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpactiongroup.[ch]: added convenience function
	gimp_action_group_activate_action().

svn path=/trunk/; revision=22973
2007-07-23 13:01:55 +00:00
Sven Neumann
46eb9b2f90 don't call strlen on a NULL font name.
2007-07-20  Sven Neumann  <sven@gimp.org>

	* app/text/gimptext.c (gimp_text_set_property): don't call strlen
	on a NULL font name.

svn path=/trunk/; revision=22968
2007-07-20 15:10:24 +00:00
Sven Neumann
e2b9c20b43 fixed a gtk-doc comment.
2007-07-20  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.c: fixed a gtk-doc comment.


svn path=/trunk/; revision=22966
2007-07-20 13:18:43 +00:00
Sven Neumann
e53f7a2c81 overwrite the menurc with the systemwide default. Only if that fails,
2007-07-20  Sven Neumann  <sven@gimp.org>

	* app/menus/menus.c (menus_clear): overwrite the menurc with the
	systemwide default. Only if that fails, delete the menurc file.

	* app/dialogs/preferences-dialog.c: string change.

	* app/core/gimp-user-install.c: formatting.

svn path=/trunk/; revision=22964
2007-07-20 12:41:08 +00:00
Sven Neumann
6b0e6990d1 remember whether a channel was active before quick mask was activated.
2007-07-20  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage-quick-mask.[ch]: remember whether a channel
	was active before quick mask was activated. Fixes bug #134371.

svn path=/trunk/; revision=22961
2007-07-20 08:23:29 +00:00
Sven Neumann
a5d10b2ff0 renamed gimp_image_active_drawable() to gimp_image_get_active_drawable().
2007-07-19  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage.[ch]: renamed gimp_image_active_drawable() to
	gimp_image_get_active_drawable().

	* app/[lots of files]
	* tools/pdbgen/pdb/paths.pdb
	* tools/pdbgen/pdb/image.pdb: changed accordingly.

svn path=/trunk/; revision=22958
2007-07-19 14:59:51 +00:00
Sven Neumann
f6c626fba3 chain up.
2007-07-19  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpcolortool.c (gimp_color_tool_draw): chain up.

svn path=/trunk/; revision=22957
2007-07-19 09:09:26 +00:00
Sven Neumann
17d4af0080 added const qualifiers.
2007-07-18  Sven Neumann  <sven@gimp.org>

	* app/pdb/gimpprocedure.[ch] (gimp_procedure_set_strings): added
	const qualifiers.


svn path=/trunk/; revision=22956
2007-07-18 17:23:51 +00:00
Sven Neumann
eb9e9fec7d advance_dest is a boolean
svn path=/trunk/; revision=22955
2007-07-18 15:48:44 +00:00
Sven Neumann
b5e8ca6925 unified subsampling code.
2007-07-17  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/sample-funcs.c: unified subsampling code.


svn path=/trunk/; revision=22954
2007-07-18 15:39:19 +00:00
Sven Neumann
4ed227cf0e app/paint-funcs/Makefile.am app/paint-funcs/scale-funcs.[ch] moved
2007-07-17  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/Makefile.am
	* app/paint-funcs/scale-funcs.[ch]
	* app/paint-funcs/sample-funcs.[ch]: moved subsample_region() to
	new file and also moved subsample_indexed_region() there.

	* app/base/tile-manager-preview.c
	* app/core/gimpdrawable-preview.c: changed accordingly.


svn path=/trunk/; revision=22953
2007-07-18 12:47:00 +00:00
Sven Neumann
58ee85dfa6 added tile_manager_get_sub_preview().
2007-07-17  Sven Neumann  <sven@gimp.org>

	* app/base/tile-manager-preview.[ch]: added
	tile_manager_get_sub_preview().

	* app/core/gimpdrawable-preview.c: use the new function except 
for
	indexed drawables.


svn path=/trunk/; revision=22950
2007-07-17 20:33:10 +00:00
Sven Neumann
b47a3e52e5 app/base/Makefile.am added new file that holds code to create a preview
2007-07-17  Sven Neumann  <sven@gimp.org>

	* app/base/Makefile.am
	* app/base/tile-manager-preview.[ch]: added new file that holds 
code
	to create a preview from a tile manager.

	* app/core/gimpbuffer.c
	* app/core/gimpimage-preview.c: use the new function instead of
	duplicating this code.


svn path=/trunk/; revision=22948
2007-07-17 19:38:10 +00:00
Sven Neumann
cd7a6f3e6c use 64 bit integers to avoid an overflow. Fixes bug #457209.
2007-07-17  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/scale-funcs.c (scale_region_no_resample): use
	64 bit integers to avoid an overflow. Fixes bug #457209.

svn path=/trunk/; revision=22947
2007-07-17 16:52:39 +00:00
Sven Neumann
ca8bac4c0c gracefully deal with empty colormaps.
2007-07-17  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcolormapeditor.c: gracefully deal with empty
	colormaps.

svn path=/trunk/; revision=22946
2007-07-17 16:32:18 +00:00
Sven Neumann
9409179aa6 free the context list.
2007-07-17  Sven Neumann  <sven@gimp.org>

	* app/core/gimp.c (gimp_finalize): free the context list.

	* app/tools/gimprectangleoptions.c (gimp_rectangle_options_gui):
	removed unused vbox.

svn path=/trunk/; revision=22944
2007-07-17 11:15:15 +00:00
Simon Budig
340cd2f8e6 app/text/gimptext-private.h app/text/gimptextlayout.c Fix text rendering
2007-07-17  Simon Budig  <simon@gimp.org>

	* app/text/gimptext-private.h
	* app/text/gimptextlayout.c
	* app/text/gimptextlayout-render.c: Fix text rendering for xres != yres.


svn path=/trunk/; revision=22943
2007-07-17 11:00:56 +00:00
Sven Neumann
83898a0cf8 unref the context.
2007-07-17  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpmenudock.c (gimp_menu_dock_new): unref the context.

svn path=/trunk/; revision=22942
2007-07-17 10:55:21 +00:00
Sven Neumann
f3c451becd use the tool-info identifier as the name of the tool-options object.
2007-07-17  Sven Neumann  <sven@gimp.org>

	* app/core/gimptoolinfo.c (gimp_tool_info_new): use the tool-info
	identifier as the name of the tool-options object.

	* app/paint/gimppaintoptions.c (gimp_paint_options_new): use the
	paint-info identifier as the name of the paint-options object.

	* app/paint/gimp-paint.c (gimp_paint_register): added parameter check.

	* app/tools/gimp-tools.c (gimp_tools_init): formatting.

svn path=/trunk/; revision=22941
2007-07-17 10:04:06 +00:00
Sven Neumann
de7d46d6e2 plugged tiny memory leak.
2007-07-17  Sven Neumann  <sven@gimp.org>

	* app/plug-in/gimppluginprocedure.c
	(gimp_plug_in_procedure_set_file_proc): plugged tiny memory 
leak.

	* libgimpcolor/gimprgb.c (gimp_rgb_min) (gimp_rgb_max): 
formatting.


svn path=/trunk/; revision=22940
2007-07-17 07:22:20 +00:00
Sven Neumann
b56e206d0b sync with the default template. Fixes bug #457286.
2007-07-16  Sven Neumann  <sven@gimp.org>

	* app/core/gimpimage-new.c (gimp_image_new_get_last_template): sync
	with the default template. Fixes bug #457286.

svn path=/trunk/; revision=22938
2007-07-16 13:49:17 +00:00
Martin Nordholts
6b2187c1bd Added members to keep track of for what shell scale the handle sizes were
2007-07-15  Martin Nordholts  <martinn@svn.gnome.org>

	* app/tools/gimprectangletool.c (struct
	_GimpRectangleToolPrivate): Added members to keep track of for
	what shell scale the handle sizes were calculated. This is
	necessary so that in
	(gimp_rectangle_tool_control): we only update the handle sizes
	when the zoom level has changed. We must test this, because the
	tool is also paused/resumed when highlightning is on, and we don't
	want to update handle sizes just because highlightning happends to
	be on.
	(gimp_rectangle_tool_scale_has_changed): Added helper function.

svn path=/trunk/; revision=22933
2007-07-15 09:43:49 +00:00
Martin Nordholts
3a5d96d4f9 Check agains tool->display, this check was lost when this function was
2007-07-14  Martin Nordholts  <martinn@svn.gnome.org>

	* app/tools/gimprectangletool.c
	(gimp_rectangle_tool_set_highlight): Check agains tool->display,
	this check was lost when this function was moved out of
	gimp_rectangle_tool_configure.

svn path=/trunk/; revision=22931
2007-07-14 20:15:08 +00:00
Martin Nordholts
a8237b23b3 Also update rectangle handle sizes when canvas zoom is changed. (Forgot
2007-07-14  Martin Nordholts  <martinn@svn.gnome.org>

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_control):
	Also update rectangle handle sizes when canvas zoom is
	changed. (Forgot that in previous commit.)

svn path=/trunk/; revision=22930
2007-07-14 16:29:04 +00:00
Martin Nordholts
5b3f4ea658 Made the rectangle tool handles not resize during rectangle manipulation,
2007-07-14  Martin Nordholts  <martinn@svn.gnome.org>

	Made the rectangle tool handles not resize during rectangle
	manipulation, as outlined in the spec, by separating highlight
	updating and handle size updating calls.

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_configure):
	Renamed to
	(gimp_rectangle_tool_update_handle_sizes): and moved
	gimp_rectangle_tool_set_highlight out of it. These two are now
	called independantly.

svn path=/trunk/; revision=22929
2007-07-14 16:03:13 +00:00
Martin Nordholts
82430afc70 Fixed crash when creating a rectangle with constraints outside of canvas
2007-07-14  Martin Nordholts  <martinn@svn.gnome.org>

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_clamp_width)
	(gimp_rectangle_tool_clamp_height): Fixed crash when creating a
	rectangle with constraints outside of canvas bounds.

svn path=/trunk/; revision=22928
2007-07-14 10:01:46 +00:00
Martin Nordholts
72ec24da5f Don't execute selection if a dead area is clicked.
2007-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/tools/gimprectangletool.c
	(gimp_rectangle_tool_button_release): Don't execute selection if a
	dead area is clicked.

svn path=/trunk/; revision=22927
2007-07-13 20:49:32 +00:00
Martin Nordholts
eed8dc9b68 Update handle sizes and highlight area also when Ctrl is released.
2007-07-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/tools/gimprectangletool.c
	(gimp_rectangle_tool_active_modifier_key): Update handle sizes and
	highlight area also when Ctrl is released.

svn path=/trunk/; revision=22926
2007-07-13 19:07:02 +00:00
Sven Neumann
816f31318e Work around Pango appending " Not-Rotated" to font names:
2007-07-12  Sven Neumann  <sven@gimp.org>

	Work around Pango appending " Not-Rotated" to font names:

	* app/text/gimptext.c (gimp_text_set_property)
	* app/text/gimpfontlist.c (gimp_font_list_add_font): strip
	" Not-Rotated" from the font name.

svn path=/trunk/; revision=22918
2007-07-12 09:11:03 +00:00
Martin Nordholts
838d61670e Removed bitfieldized values from the SideToResize enum, they are
2007-07-11  Martin Nordholts  <martinn@svn.gnome.org>

	* app/tools/gimprectangletool.c: Removed bitfieldized values from
	the SideToResize enum, they are irrelevant. Also renamed
	HANDLE_SIZE to MAX_HANDLE_SIZE.

svn path=/trunk/; revision=22909
2007-07-11 05:09:50 +00:00
Martin Nordholts
b62c673dcf Removed declaration of gimp_rectangle_tool_update_and_redraw;
forgot that in previous patch.

svn path=/trunk/; revision=22904
2007-07-08 22:03:52 +00:00
Martin Nordholts
3ae75615d9 Completely rewrote logic in gimp_rectangle_tool_motion, in effect also
2007-07-08  Martin Nordholts  <martinn@svn.gnome.org>

	Completely rewrote logic in gimp_rectangle_tool_motion, in effect
	also fixing bug #353936 and bug #398188. The general strategy now
	is to have specialized functions doing one thing, and one thing
	only.

	The patch also makes adjusting the rectangle through the keyboard
	and through the rectangle tool options follow tool options.

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_motion):
	Completely refactored.

	(gimp_rectangle_tool_active_modifier_key):
	(gimp_rectangle_tool_update_options): Submit to tool options.

	(gimp_rectangle_tool_apply_coord)
	(gimp_rectangle_tool_clamp)
	(gimp_rectangle_tool_clamp_width)
	(gimp_rectangle_tool_clamp_height)
	(gimp_rectangle_tool_keep_inside)
	(gimp_rectangle_tool_keep_inside_horizontally)
	(gimp_rectangle_tool_keep_inside_vertically)
	(gimp_rectangle_tool_apply_fixed_width)
	(gimp_rectangle_tool_apply_fixed_height)
	(gimp_rectangle_tool_apply_aspect)
	(gimp_rectangle_tool_update_with_coord)
	(gimp_rectangle_tool_get_constraints)
	(gimp_rectangle_tool_handle_general_clamping): The new specialized
	functions.

svn path=/trunk/; revision=22903
2007-07-08 21:57:22 +00:00
Martin Nordholts
d8803f29b6 Block gimp_rectangle_tool_options_notify when changing fixed-aspect
2007-07-08  Martin Nordholts  <martinn@svn.gnome.org>

	* app/tools/gimprectangletool.c
	(gimp_rectangle_tool_active_modifier_key): Block
	gimp_rectangle_tool_options_notify when changing fixed-aspect
	through the shift key. Fixes bug #417168.


svn path=/trunk/; revision=22896
2007-07-08 13:38:58 +00:00
Michael Natterer
78be6549f1 renamed action "selection-editor-popup" to "selection-popup". Fixes bug
2007-07-08  Michael Natterer  <mitch@gimp.org>

	* app/actions/select-actions.c (select_actions): renamed action
	"selection-editor-popup" to "selection-popup". Fixes bug #454364.

	* app/widgets/gimpdockable.c (gimp_dockable_show_menu): warn when
	above bug happens instead of failing silently.


svn path=/trunk/; revision=22894
2007-07-08 12:23:44 +00:00
Sven Neumann
b7c967a9de removed debug output. (gimp_container_tree_view_clear_items)
2007-07-06  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimpcontainertreeview.c
	(gimp_container_tree_view_name_canceled): removed debug output.
	(gimp_container_tree_view_clear_items)
	(gimp_container_tree_view_remove_item): removed warning; the bug
	this warning referred to has been closed as WONTFIX.

svn path=/trunk/; revision=22889
2007-07-06 14:33:52 +00:00
Sven Neumann
9ab1cf582a marked two error messages as translatable strings.
2007-07-06  Sven Neumann  <sven@gimp.org>

	* app/xcf/xcf-load.c (xcf_load_image): marked two error messages
	as translatable strings.

	* libgimpbase/gimputils.c (gimp_any_to_utf8): insert a blank
	before the text that marks the string as invalid.

svn path=/trunk/; revision=22887
2007-07-06 10:02:31 +00:00
Sven Neumann
5a41fd121a don't count the number of repeated messages when the error messages are
2007-07-05  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimperrordialog.c (gimp_error_dialog_add): don't
	count the number of repeated messages when the error messages are
	being redirected to stderr already.

svn path=/trunk/; revision=22876
2007-07-05 15:39:22 +00:00
Sven Neumann
4512af8de1 return the number of bytes that have been read from the file.
2007-07-05  Sven Neumann  <sven@gimp.org>

	* app/xcf/xcf-read.c (xcf_read_int32) (xcf_read_int8): return the
	number of bytes that have been read from the file.

	* app/xcf/xcf-load.c (xcf_load_prop): return FALSE when reading fails.

svn path=/trunk/; revision=22873
2007-07-05 15:12:43 +00:00
Sven Neumann
933be6a806 allow the use of constants when specifying limits for a PDB type.
2007-07-05  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb.pl (arg_parse): allow the use of constants when
	specifying limits for a PDB type.

	* tools/pdbgen/pdb/channel.pdb
	* tools/pdbgen/pdb/image.pdb
	* tools/pdbgen/pdb/layer.pdb: use GIMP_MAX_IMAGE_SIZE as limit for
	image and drawable sizes.

	* tools/pdbgen/pdb/selection_tools.pdb: added missing include.

	* app/pdb/channel_cmds.c
	* app/pdb/image_cmds.c
	* app/pdb/layer_cmds.c
	* app/pdb/selection_tools_cmds.c: regenerated.

svn path=/trunk/; revision=22870
2007-07-05 14:31:42 +00:00
Sven Neumann
a2c401b0f6 changed the highlighting of the side handles to follow changes in the
2007-07-05  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpdrawtool.c (gimp_draw_tool_draw_corner): changed
	the highlighting of the side handles to follow changes in the
	specification.

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_draw): cosmetics.

svn path=/trunk/; revision=22867
2007-07-05 11:49:00 +00:00
Sven Neumann
62dbf9e330 applied patch from Jens Persson that adds a LUT to apply the jitter in
2007-07-04  Sven Neumann  <sven@gimp.org>

	* app/paint/gimpbrushcore.[ch]: applied patch from Jens Persson
	that adds a LUT to apply the jitter in polar coordinates (bug 
#434532).


svn path=/trunk/; revision=22859
2007-07-04 06:30:34 +00:00
Martin Nordholts
25fca1a6e2 Started taking GimpRectangleTool towards the new specification. The side
2007-06-30  Martin Nordholts  <martinn@svn.gnome.org>

	Started taking GimpRectangleTool towards the new specification.
	The side handles now have the same width and height as the
	corresponding corner handles, and the size of the side handles do
	not span across the whole rectangle. Side handles also have a
	limited mimimum size, just as corner handles.

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_oper_update,
	gimp_rectangle_tool_draw, gimp_rectangle_tool_configure,
	gimp_rectangle_tool_get_anchor): Changed accordingly.

	* app/tools/gimpdrawtool.c (gimp_draw_tool_draw_corner): Changed
	accordingly.

svn path=/trunk/; revision=22856
2007-06-30 18:13:41 +00:00
Martin Nordholts
eeb6d20d8b Made GimpRectangleTools remember where the "other side" is when
2007-06-29  Martin Nordholts  <martinn@svn.gnome.org>

	Made GimpRectangleTools remember where the "other side" is when
	fixed-center is turned on, and reset the "other side" to that position
	when fixed-center is turned off again. Fixes bug 398183.

	* app/tools/gimprectangletool.c
	(gimp_rectangle_tool_button_press): Remember "other side".
	(gimp_rectangle_tool_active_modifier_key): When fixed-center is turned
	off, reset "other side".
	(gimp_rectangle_tool_get_other_side)
	(gimp_rectangle_tool_get_other_side_coord)
	(gimp_rectangle_tool_set_other_side_coord): New functions.

svn path=/trunk/; revision=22854
2007-06-29 16:37:50 +00:00