dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

use 64 bit integers to avoid an overflow. Fixes bug #457209.

Browse source 
2007-07-17  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/scale-funcs.c (scale_region_no_resample): use
	64 bit integers to avoid an overflow. Fixes bug #457209.

svn path=/trunk/; revision=22947
This commit is contained in:
Sven Neumann 2007-07-17 16:52:39 +00:00 committed by Sven Neumann
parent ca8bac4c0c
commit cd7a6f3e6c
2 changed files with 19 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ChangeLog
View file

@ -1,3 +1,8 @@
2007-07-17 Sven Neumann <sven@gimp.org>
* app/paint-funcs/scale-funcs.c (scale_region_no_resample): use
64 bit integers to avoid an overflow. Fixes bug #457209.
2007-07-17 Sven Neumann <sven@gimp.org>
* app/widgets/gimpcolormapeditor.c: gracefully deal with empty

17
app/paint-funcs/scale-funcs.c
View file

@ -100,18 +100,29 @@ scale_region_no_resample (PixelRegion *srcPR,
/* the data pointers... */
x_src_offsets = g_new (gint, width * bytes);
y_src_offsets = g_new (gint, height);
src = g_new (guchar, orig_width * bytes);
dest = g_new (guchar, width * bytes);
/* pre-calc the scale tables */
offset = x_src_offsets;
for (x = 0; x < width; x++)
for (b = 0; b < bytes; b++)
*offset++ = b + bytes * ((x * orig_width + orig_width / 2) / width);
{
/* need to use 64 bit integers here to avoid an overflow */
gint o = ((gint64) x *
(gint64) orig_width + orig_width / 2) / (gint64) width;
for (b = 0; b < bytes; b++)
*offset++ = o * bytes + b;
}
offset = y_src_offsets;
for (y = 0; y < height; y++)
*offset++ = (y * orig_height + orig_height / 2) / height;
{
/* need to use 64 bit integers here to avoid an overflow */
*offset++ = (((gint64) y * (gint64) orig_height + orig_height / 2) /
(gint64) height);
}
/* do the scaling */
row_bytes = width * bytes;