dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libgimp*: revert using g_set_str() outside app/

Browse source
This commit is contained in:
Michael Natterer 2025-07-10 23:27:54 +02:00
parent 734610c8f6
commit 50ce759eca
6 changed files with 23 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
libgimpthumb/gimpthumbnail.c
View file

@ -312,7 +312,8 @@ gimp_thumbnail_set_property (GObject *object,
thumbnail->image_filesize = g_value_get_int64 (value);
break;
case PROP_IMAGE_MIMETYPE:
g_set_str (&thumbnail->image_mimetype, g_value_get_string (value));
g_free (thumbnail->image_mimetype);
thumbnail->image_mimetype = g_value_dup_string (value);
break;
case PROP_IMAGE_WIDTH:
thumbnail->image_width = g_value_get_int (value);
@ -321,7 +322,8 @@ gimp_thumbnail_set_property (GObject *object,
thumbnail->image_height = g_value_get_int (value);
break;
case PROP_IMAGE_TYPE:
g_set_str (&thumbnail->image_type, g_value_get_string (value));
g_free (thumbnail->image_type);
thumbnail->image_type = g_value_dup_string (value);
break;
case PROP_IMAGE_NUM_LAYERS:
thumbnail->image_num_layers = g_value_get_int (value);

4
libgimpwidgets/gimpcellrenderertoggle.c
View file

@ -217,7 +217,9 @@ gimp_cell_renderer_toggle_set_property (GObject *object,
switch (param_id)
{
case PROP_ICON_NAME:
g_set_str (&toggle->icon_name, g_value_get_string (value));
if (toggle->icon_name)
g_free (toggle->icon_name);
toggle->icon_name = g_value_dup_string (value);
break;
case PROP_ICON_SIZE:

10
libgimpwidgets/gimpcontroller.c
View file

@ -164,12 +164,15 @@ gimp_controller_set_property (GObject *object,
switch (property_id)
{
case PROP_NAME:
g_set_str (&priv->name, g_value_get_string (value));
if (priv->name)
g_free (priv->name);
priv->name = g_value_dup_string (value);
break;
case PROP_STATE:
g_set_str (&priv->state, g_value_get_string (value));
if (priv->state)
g_free (priv->state);
priv->state = g_value_dup_string (value);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
break;
@ -193,7 +196,6 @@ gimp_controller_get_property (GObject *object,
case PROP_STATE:
g_value_set_string (value, priv->state);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
break;

3
libgimpwidgets/gimpdialog.c
View file

@ -248,7 +248,8 @@ gimp_dialog_set_property (GObject *object,
break;
case PROP_HELP_ID:
g_set_str (&private->help_id, g_value_get_string (value));
g_free (private->help_id);
private->help_id = g_value_dup_string (value);
gimp_help_set_help_data (GTK_WIDGET (object), NULL, private->help_id);
break;

7
libgimpwidgets/gimplabelstringwidget.c
View file

@ -179,10 +179,11 @@ gimp_label_string_widget_set_property (GObject *object,
switch (property_id)
{
case PROP_VALUE:
if (g_set_str (&widget->value, g_value_get_string (value)))
if (g_strcmp0 (widget->value, g_value_get_string (value)) != 0)
{
g_signal_emit (object,
gimp_label_string_widget_signals[VALUE_CHANGED], 0);
g_free (widget->value);
widget->value = g_value_dup_string (value);
g_signal_emit (object, gimp_label_string_widget_signals[VALUE_CHANGED], 0);
}
break;
case PROP_WIDGET:

10
libgimpwidgets/gimpunitstore.c
View file

@ -244,25 +244,23 @@ gimp_unit_store_set_property (GObject *object,
private->resolutions = g_new0 (gdouble, private->num_values);
}
break;
case PROP_HAS_PIXELS:
gimp_unit_store_set_has_pixels (GIMP_UNIT_STORE (object),
g_value_get_boolean (value));
break;
case PROP_HAS_PERCENT:
gimp_unit_store_set_has_percent (GIMP_UNIT_STORE (object),
g_value_get_boolean (value));
break;
case PROP_SHORT_FORMAT:
g_set_str (&private->short_format, g_value_get_string (value));
g_free (private->short_format);
private->short_format = g_value_dup_string (value);
if (! private->short_format)
private->short_format = g_strdup ("%a");
break;
case PROP_LONG_FORMAT:
g_set_str (&private->long_format, g_value_get_string (value));
g_free (private->long_format);
private->long_format = g_value_dup_string (value);
if (! private->long_format)
private->long_format = g_strdup ("%a");
break;