mirror of
https://gitea.wildfiregames.com/0ad/0ad
synced 2026-06-16 21:34:08 -07:00
e16c4c4800
The ModifiersManager system component provides an interface to add and remove modifiers, and get modified stats. The goal is to merge all the different stat-modifying systems 0 A.D. has implemented over the years. This commit makes technologies and auras use ModifiersManager. Some cheats and AI bonuses also have a similar stat-modifying effect that have not yet been updated. Further, this system component makes it possible for e.g. triggers to easily add modifiers, enabling the writing of Castle Blood Automatic, RPG or Tower Defense maps without the need for mods or hacks. The 'Modifier' name was preferred over 'Modification' as it is shorter and more readable, along with the logic that 'modifiers' store 'modifications' and this stores modifiers. Renaming of other functions and classes has been left for future work for now. Internally, this uses a JS data structure. If performance issues arise with it in the future, this data structure or the whole component could be moved to C++. The performance has been tested to be about as fast as the current implementations (and specifically much faster for global auras with no icons). Testing showed that sending value modification messages was by far the slowest part. Comments by: leper, Stan, elexis Differential Revision: https://code.wildfiregames.com/D274 This was SVN commit r22767.
87 lines
3.2 KiB
C++
87 lines
3.2 KiB
C++
/* Copyright (C) 2017 Wildfire Games.
|
|
* This file is part of 0 A.D.
|
|
*
|
|
* 0 A.D. is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* 0 A.D. is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with 0 A.D. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "simulation2/system/ComponentTest.h"
|
|
|
|
#include "ps/Filesystem.h"
|
|
|
|
class TestComponentScripts : public CxxTest::TestSuite
|
|
{
|
|
public:
|
|
void setUp()
|
|
{
|
|
g_VFS = CreateVfs();
|
|
g_VFS->Mount(L"", DataDir()/"mods"/"mod", VFS_MOUNT_MUST_EXIST);
|
|
g_VFS->Mount(L"", DataDir()/"mods"/"public", VFS_MOUNT_MUST_EXIST, 1); // ignore directory-not-found errors
|
|
CXeromyces::Startup();
|
|
}
|
|
|
|
void tearDown()
|
|
{
|
|
CXeromyces::Terminate();
|
|
g_VFS.reset();
|
|
}
|
|
|
|
static void load_script(const ScriptInterface& scriptInterface, const VfsPath& pathname)
|
|
{
|
|
CVFSFile file;
|
|
TS_ASSERT_EQUALS(file.Load(g_VFS, pathname), PSRETURN_OK);
|
|
CStr content = file.DecodeUTF8(); // assume it's UTF-8
|
|
TSM_ASSERT(L"Running script "+pathname.string(), scriptInterface.LoadScript(pathname, content));
|
|
}
|
|
|
|
static void Script_LoadComponentScript(ScriptInterface::CxPrivate* pCxPrivate, const VfsPath& pathname)
|
|
{
|
|
CComponentManager* componentManager = static_cast<CComponentManager*> (pCxPrivate->pCBData);
|
|
TS_ASSERT(componentManager->LoadScript(VfsPath(L"simulation/components") / pathname));
|
|
}
|
|
|
|
static void Script_LoadHelperScript(ScriptInterface::CxPrivate* pCxPrivate, const VfsPath& pathname)
|
|
{
|
|
CComponentManager* componentManager = static_cast<CComponentManager*> (pCxPrivate->pCBData);
|
|
TS_ASSERT(componentManager->LoadScript(VfsPath(L"simulation/helpers") / pathname));
|
|
}
|
|
|
|
void test_scripts()
|
|
{
|
|
if (!VfsFileExists(L"simulation/components/tests/setup.js"))
|
|
{
|
|
debug_printf("WARNING: Skipping component scripts tests (can't find binaries/data/mods/public/simulation/components/tests/setup.js)\n");
|
|
return;
|
|
}
|
|
|
|
VfsPaths paths;
|
|
TS_ASSERT_OK(vfs::GetPathnames(g_VFS, L"simulation/components/tests/", L"test_*.js", paths));
|
|
TS_ASSERT_OK(vfs::GetPathnames(g_VFS, L"simulation/helpers/tests/", L"test_*.js", paths));
|
|
paths.push_back(VfsPath(L"simulation/components/tests/setup_test.js"));
|
|
for (const VfsPath& path : paths)
|
|
{
|
|
CSimContext context;
|
|
CComponentManager componentManager(context, g_ScriptRuntime, true);
|
|
|
|
ScriptTestSetup(componentManager.GetScriptInterface());
|
|
|
|
componentManager.GetScriptInterface().RegisterFunction<void, VfsPath, Script_LoadComponentScript> ("LoadComponentScript");
|
|
componentManager.GetScriptInterface().RegisterFunction<void, VfsPath, Script_LoadHelperScript> ("LoadHelperScript");
|
|
|
|
componentManager.LoadComponentTypes();
|
|
|
|
load_script(componentManager.GetScriptInterface(), L"simulation/components/tests/setup.js");
|
|
load_script(componentManager.GetScriptInterface(), path);
|
|
}
|
|
}
|
|
};
|