mirror of
https://gitea.wildfiregames.com/0ad/0ad
synced 2026-08-15 14:43:32 -07:00
2520c45220
Since #7786, the GUI tick completed normally after calling `closePageCallback` instead of being cancelled like previously. Since `Engine.EndGame` deletes the internal `g_Game` pointer, every Engine call after it that tried to access `g_Game` caused a segfault. This patch solves it by moving `Engine.EndGame` to the very end, right before closing the session page. In order to follow the convention that only functions directly closing the page are called `closePageCallback`, that function is in turn renamed to `closeSession`. Additionally, this allows only resolving the promise with a bool (`showSummary`) and then only calling `getNextPageOpenRequest` at the end of `init` for reasons of simplicity.
113 lines
2.7 KiB
JavaScript
113 lines
2.7 KiB
JavaScript
/**
|
|
* This class constructs and positions the menu buttons and assigns the handlers defined in MenuButtons.
|
|
*/
|
|
class Menu
|
|
{
|
|
constructor(pauseControl, playerViewControl, chat, closeSession)
|
|
{
|
|
this.menuButton = Engine.GetGUIObjectByName("menuButton");
|
|
this.menuButton.onPress = this.toggle.bind(this);
|
|
registerHotkeyChangeHandler(this.rebuild.bind(this));
|
|
|
|
this.isOpen = false;
|
|
this.lastTick = undefined;
|
|
|
|
this.menuButtonPanel = Engine.GetGUIObjectByName("menuButtonPanel");
|
|
const menuButtons = this.menuButtonPanel.children;
|
|
this.margin = menuButtons[0].size.top;
|
|
this.buttonHeight = menuButtons[0].size.bottom;
|
|
|
|
const handlerNames = this.getHandlerNames();
|
|
if (handlerNames.length > menuButtons.length)
|
|
throw new Error(
|
|
"There are " + handlerNames.length + " menu buttons defined, " +
|
|
"but only " + menuButtons.length + " objects!");
|
|
|
|
this.buttons = handlerNames.map((handlerName, i) =>
|
|
{
|
|
const handler = new MenuButtons.prototype[handlerName](menuButtons[i], pauseControl, playerViewControl, chat);
|
|
this.initButton(handler, menuButtons[i], i, closeSession);
|
|
return handler;
|
|
});
|
|
|
|
this.endPosition = this.margin + this.buttonHeight * (1 + handlerNames.length);
|
|
this.menuButtonPanel.size.top = -this.endPosition;
|
|
this.menuButtonPanel.size.bottom = 0;
|
|
}
|
|
|
|
rebuild()
|
|
{
|
|
this.menuButton.tooltip = sprintf(translate("Press %(hotkey)s to toggle this menu."), {
|
|
"hotkey": colorizeHotkey("%(hotkey)s", this.menuButton.hotkey),
|
|
});
|
|
}
|
|
|
|
/**
|
|
* This function may be overwritten to change the button order.
|
|
*/
|
|
getHandlerNames()
|
|
{
|
|
return Object.keys(MenuButtons.prototype);
|
|
}
|
|
|
|
toggle()
|
|
{
|
|
this.isOpen = !this.isOpen;
|
|
this.startAnimation();
|
|
}
|
|
|
|
close()
|
|
{
|
|
this.isOpen = false;
|
|
this.startAnimation();
|
|
}
|
|
|
|
initButton(handler, button, i, closeSession)
|
|
{
|
|
button.onPress = () =>
|
|
{
|
|
this.close();
|
|
handler.onPress(closeSession);
|
|
};
|
|
button.size.top = this.buttonHeight * (i + 1) + this.margin;
|
|
button.size.bottom = this.buttonHeight * (i + 2);
|
|
button.hidden = false;
|
|
}
|
|
|
|
startAnimation()
|
|
{
|
|
this.lastTick = Date.now();
|
|
this.menuButtonPanel.onTick = this.onTick.bind(this);
|
|
}
|
|
|
|
/**
|
|
* Animate menu panel.
|
|
*/
|
|
onTick()
|
|
{
|
|
const tickLength = Date.now() - this.lastTick;
|
|
this.lastTick = Date.now();
|
|
|
|
const maxOffset =
|
|
this.endPosition + (
|
|
this.isOpen ?
|
|
-this.menuButtonPanel.size.bottom :
|
|
+this.menuButtonPanel.size.top);
|
|
|
|
|
|
if (maxOffset <= 0)
|
|
{
|
|
delete this.menuButtonPanel.onTick;
|
|
return;
|
|
}
|
|
|
|
const offset = Math.min(this.Speed * tickLength, maxOffset) * (this.isOpen ? +1 : -1);
|
|
this.menuButtonPanel.size.top += offset;
|
|
this.menuButtonPanel.size.bottom += offset;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Number of pixels per millisecond to move.
|
|
*/
|
|
Menu.prototype.Speed = 1.2;
|