Itms
490a3a27f6
Fix the cache directory appearing during tests.
...
Summary: Refs #4419 .
Test Plan: When running tests, make sure nothing is created.
Reviewers: leper
Reviewed By: leper
Subscribers: leper, Vulcan
Differential Revision: https://code.wildfiregames.com/D1
This was SVN commit r19062.
2016-12-25 22:03:30 +00:00
wraitii
40fd373c83
Revert [19043]
...
This was SVN commit r19054.
2016-12-21 12:36:41 +00:00
wraitii
8e8da9aee4
Fix a bug introduced by a fix of a bug introduced by a fix of a bug (x100) in the vertex pathfinder. Revealed by automated tests on another branch of mine. Revert back to pre-new pathfinder behavior of not returning paths in some cases, since that is most likely less broken than now - but probably still a little broken.
...
This was SVN commit r19043.
2016-12-18 10:02:36 +00:00
wraitii
9288837472
Fix misleading indentation warning on gcc, introduced by [19024]. Reported by elexis. Fixes #3785
...
This was SVN commit r19041.
2016-12-13 13:34:31 +00:00
wraitii
e7e5631135
Better fix to #3785 . Fixes #3785
...
This was SVN commit r19024.
2016-12-06 23:25:26 +00:00
Itms
6ae374dbee
Fix the update of shared dirty visibility masks when changing diplomacy.
...
The previous code worked in case new mutual allies were added, but, when
some were removed, it was suboptimal in terms of performance and it made
some units visible in the FoW.
Fixes #4266
This was SVN commit r18994.
2016-11-24 14:57:09 +00:00
Itms
a27dc31b0e
Remove some obsolete backref logic from the deserializer. It was introduced in earlier versions of the SpiderMonkey API.
...
Name some variables more logically in one test.
Fixes #4244
This was SVN commit r18993.
2016-11-24 14:47:49 +00:00
elexis
417c84870c
Actually remove trailing tabs from source/.
...
This was SVN commit r18991.
2016-11-23 14:09:58 +00:00
elexis
6149dd3841
Actually remove trailing whitespace for non-header files as well.
...
This was SVN commit r18989.
2016-11-23 13:02:58 +00:00
elexis
944ba16eb4
End source files with a newline.
...
This was SVN commit r18988.
2016-11-23 11:27:54 +00:00
elexis
b18f74da44
Remove trailing whitespace and whitespace in empty lines of source/ except source/third_party/.
...
This was SVN commit r18987.
2016-11-23 11:18:37 +00:00
elexis
aa26863d5c
Fix an OOS on rejoin caused by ParamNode.cpp using an invalid node cache. Patch by leper, fixes #4316 .
...
Reuse the temple of vesta inheritance from 06bf79b7e8 which was affected
by this bug.
This was SVN commit r18942.
2016-11-15 14:01:15 +00:00
elexis
3008533c8e
Add a template manager test that reveals an inheritance error in ParamNode.cpp which can trigger an OOS on rejoin. Patch by leper, refs #4316 .
...
This was SVN commit r18941.
2016-11-15 13:51:29 +00:00
elexis
2bf1dbfd13
An awesome Rejoin-test tool by wraitii and Itms, fixes #4242 , refs #3460 .
...
Contrary to the serializationtest, initializes the secondary simstate
only once
before progressively applying updates.
Thus reproducing actual multiplayer rejoining, enabling developers to
analyze OOS reports solely from the replay file of the rejoined and a
non-rejoined client.
This was SVN commit r18940.
2016-11-15 13:26:58 +00:00
elexis
2ec3f3ebaa
Add parenthesis suggested by gcc 5.4 following 3e59ac76ee, refs #4278 .
...
This was SVN commit r18924.
2016-11-12 16:07:23 +00:00
mimo
3e59ac76ee
fix UnitMotion when inside the obstruction, refs #4278
...
This was SVN commit r18921.
2016-11-11 13:14:30 +00:00
elexis
4898e94c81
Remove unneeded braces and whitespace in empty lines.
...
This was SVN commit r18882.
2016-10-28 16:11:59 +00:00
elexis
5a384f4eaf
Fix an OOS on rejoin when a ptolemian lighthouse revealing the shoreline was built prior. Patch by Itms and wraitii, fixes #4277 .
...
Serialize the mapsize in the pathfinder and the reveal shoreline flag in
the range manager.
Reload the rangemanager data after other components have been
deserialized.
Use the SerializeCommon pattern in the pathfinder to avoid code
duplication.
Move the shoreline logic from the Vision component to the range manager.
Remove unused interface mocks from the rangemanager test following
b05879e151 .
This was SVN commit r18879.
2016-10-28 15:34:24 +00:00
wraitii
7f8f820e35
Fix an oversight in d8c11434a8/18823, fixes #4270 .
...
This was SVN commit r18835.
2016-10-16 20:17:31 +00:00
elexis
0991c22026
Take vision range techs into account on ownership change (capturing or defeat). Solves an OOS, reviewed by wraitii, fixes #4279 , refs #3989 .
...
This was SVN commit r18833.
2016-10-15 18:22:10 +00:00
Itms
9c2404e40e
Some tweaks in order to fix the non-graphical test modes (serialization test, etc.), and possible future non-visual players like headless game servers.
...
The internal data of the component, which is serialized, should not
depend on the presence of a visual Unit.
Also remove a misleading comment about a simple initialization code.
Refs #4270
This was SVN commit r18824.
2016-10-10 10:56:13 +00:00
Itms
ef7486c5d3
Fix a number of things in cmpVisualActor:
...
* Rewrite the Update function, add more details and information in
comments, and properly serialize everything that function needs.
* Fix the broken deserialization code by using a sane helper function.
* Fix the `SelectMovementAnimation` function.
Fixes #4270 .
This was SVN commit r18823.
2016-10-10 10:49:49 +00:00
Itms
d8c11434a8
Save the animation sync offset, for consistency's sake.
...
Refs #4270
This was SVN commit r18822.
2016-10-10 10:41:36 +00:00
Itms
79b37bd4dc
Improve style and whitespace in CCmpVisualActor.
...
Refs #4270
This was SVN commit r18821.
2016-10-10 10:37:58 +00:00
Itms
0030f6ad2b
In CCmpVisualActor, m_Unit is not initialized when running without graphics, so we must check that pointer everytime. Also make one call consistent with the rest of the file.
...
Fixes #4238 , refs #3952
This was SVN commit r18812.
2016-10-08 08:49:35 +00:00
Itms
636da605bb
Following e757fb84d5: also regenerate the JS values for AI maps upon deserialization.
...
Fixes #4247 , refs #4191
This was SVN commit r18797.
2016-10-01 12:29:44 +00:00
Itms
58704fa140
Remove a function relying on systems that are not optimized at all. This function is not actually used by Petra.
...
If it is needed at some point, this map should be handled and updated
the same way as the passability map and territory map are.
Refs #4191
This was SVN commit r18760.
2016-09-24 15:21:20 +00:00
Itms
e757fb84d5
More clever map updates for the AI.
...
This patch fixes frequent memory issues by removing several dummy
allocations and a lot of memory footwork.
Fixes #4191
This was SVN commit r18759.
2016-09-24 15:16:55 +00:00
Itms
caef42084d
Add missing JSAutoRequest calls. (hopefully all of them have been spotted now)
...
Patch by echotangoecho, refs #4053
This was SVN commit r18730.
2016-09-18 09:34:45 +00:00
Itms
8284cc4302
SpiderMonkey 38 upgrade: 35/35
...
Some comments for the next SpiderMonkey upgrade. That's all folks, fixes
#3708
This was SVN commit r18689.
2016-09-02 16:55:13 +00:00
Itms
2a33c4476f
SpiderMonkey 38 upgrade: 34/35
...
Use the C++ API for Maps. Patch by leper.
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1121332
This was SVN commit r18688.
2016-09-02 16:54:00 +00:00
Itms
0cc23c1964
SpiderMonkey 38 upgrade: 33/35
...
Remove a workaround. Note that this removal is incomplete. Based on
patch by leper.
This was SVN commit r18687.
2016-09-02 16:53:22 +00:00
Itms
9b794593db
SpiderMonkey 38 upgrade: 32/35
...
JS_GetStringCharsAndLength was removed, use
JS_Get{Latin1,TwoByte}StringCharsAndLength instead.
Actually handle strings in both the Latin1 and TwoByte cases since we
need to.
This saves some space when serializing and also when running as they are
stored that way in the vm.
Also handle the error case.
Patch by leper.
For more information:
https://blog.mozilla.org/javascript/2014/07/21/slimmer-and-faster-javascript-strings-in-firefox/
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1037869
This was SVN commit r18686.
2016-09-02 16:51:09 +00:00
Itms
ffd4207c30
SpiderMonkey 38 upgrade: 24/35
...
Work around upstream API breakage by moving from a define to a const
member and not using the namespace explicitly.
This is caused by https://bugzilla.mozilla.org/show_bug.cgi?id=896116
and this patch by leper was submitted at
https://bugzilla.mozilla.org/show_bug.cgi?id=1236373
This was SVN commit r18678.
2016-09-02 16:40:01 +00:00
Itms
ef6d1c77c8
SpiderMonkey 38 upgrade: 23/35
...
JS_GetArrayBufferData now takes an AutoCheckCannotGC parameter. Patch by
leper.
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1061288
This was SVN commit r18677.
2016-09-02 16:38:31 +00:00
Itms
2db0fb27ae
SpiderMonkey 38 upgrade: 21/35
...
The naming conventions for typed array types changed. Patch by leper.
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1021790
This was SVN commit r18675.
2016-09-02 16:36:40 +00:00
Itms
8747b1c098
SpiderMonkey 38 upgrade: 17/35
...
JS_GetUint*Array now takes an AutoCheckCannotGC parameter. Based on
patch by leper.
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1061288
This was SVN commit r18671.
2016-09-02 16:33:10 +00:00
Itms
ef764d5d64
SpiderMonkey 38 upgrade: 15/35
...
Temporary workaround dropping of parent parameter from JS_NewObject* by
switching to JS_NewObjectWithGivenProto.
We should just drop support for serializing the parent since upstream is
dropping the parent parameter from all those functions.
Patch by leper.
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1136906 and
https://bugzilla.mozilla.org/show_bug.cgi?id=1136345
This was SVN commit r18669.
2016-09-02 16:30:35 +00:00
Itms
c3710c9632
SpiderMonkey 38 upgrade: 14/35
...
JS_NewObject has no parent or proto arg anymore, use
JS_NewObjectWithGivenProto instead. Patch by leper.
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1136906
https://bugzilla.mozilla.org/show_bug.cgi?id=1127443 and
https://bugzilla.mozilla.org/show_bug.cgi?id=1136345
This was SVN commit r18668.
2016-09-02 16:29:21 +00:00
Itms
8d15411abf
SpiderMonkey 38 upgrade: 13/35
...
Update JS_NewObject to JS_NewPlainObject, with new parameters. Patch by
leper.
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1136906 and
https://bugzilla.mozilla.org/show_bug.cgi?id=1125356
This was SVN commit r18667.
2016-09-02 16:28:17 +00:00
Itms
c99ae7ca1c
SpiderMonkey 38 upgrade: 12/35
...
Major update to the JSClass stubs. Based on patch by leper.
https://bugzilla.mozilla.org/show_bug.cgi?id=1103152
This was SVN commit r18666.
2016-09-02 16:26:54 +00:00
Itms
b01300c222
SpiderMonkey 38 upgrade: 11/35
...
Renamed JS_CallHeapFooTracer to JS_CallFooTracer. Patch by leper.
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1052388
This was SVN commit r18665.
2016-09-02 16:25:42 +00:00
Itms
761abd587e
SpiderMonkey 38 upgrade: 10/35
...
Use operator= instead of .set(). Patch by leper.
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1128110
This was SVN commit r18664.
2016-09-02 16:24:46 +00:00
Itms
c7c3ef9f92
SpiderMonkey 38 upgrade: 09/35
...
Use .toFoo() instead of JSVAL_TO_FOO. Patch by leper.
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=952650
This was SVN commit r18663.
2016-09-02 16:23:44 +00:00
leper
014a6d621b
Keep mounting the cache directory in tests. Fixes oversight in 493990f472.
...
This was SVN commit r18623.
2016-08-22 01:00:23 +00:00
leper
9998592542
Remove unused variable.
...
This was SVN commit r18620.
2016-08-21 20:35:08 +00:00
elexis
6eaf76d653
Actually seed the random number generator used in the simulation. Reviewed by sanderd17, fixes #4127 .
...
This was SVN commit r18604.
2016-08-14 16:28:54 +00:00
elexis
416049e4b4
Remove charge attack from the templates which isn't implemented nor designed yet. Patch by fatherbushido, fixes #4139 .
...
Remove the unused "recharge" attack timer which was introduced in
b21e798243 but should have been removed with 4e5c5e2d8f .
This was SVN commit r18599.
2016-08-11 14:35:50 +00:00
Itms
bb1f86f515
Remove duplication of the Hexify function.
...
Remove the useless extern keyword from function declarations in
ps/Util.h.
Patch by echotangoecho, refs #4095
This was SVN commit r18591.
2016-08-08 12:50:39 +00:00
Itms
e3cdb2253d
Fix calls to CXeromyces::Terminate in the main loop to fix several possible memory leaks.
...
Make init/shutdown order consistent in some places.
This was SVN commit r18589.
2016-08-08 08:32:57 +00:00