dallasgroot/0ad
1
0
Fork 0
mirror of https://gitea.wildfiregames.com/0ad/0ad synced 2026-06-16 05:13:58 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Enable eslint rule 'no-extra-boolean-cast'

Browse source 
Enable https://eslint.org/docs/latest/rules/no-extra-boolean-cast

Ref: #8068
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
This commit is contained in:
Ralph Sennhauser 2025-06-13 18:23:18 +02:00
parent 6a62dae166
commit 8b98a7a27c
No known key found for this signature in database
16 changed files with 19 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
binaries/data/mods/mod/gui/modmod/modmod.js
View file

@ -98,7 +98,7 @@ function loadMods()
*/
function getMod(folder)
{
return !!g_Mods[folder] ? g_Mods[folder] : g_FakeMod;
return g_Mods[folder] ? g_Mods[folder] : g_FakeMod;
}
function loadEnabledMods()
@ -248,7 +248,7 @@ function disableMod()
break;
}
if (!!g_Mods[disabledMod])
if (g_Mods[disabledMod])
g_ModsDisabled.push(disabledMod);
// Remove mods that required the removed mod and cascade

2
binaries/data/mods/public/gamesettings/attributes/MapPreview.js
View file

@ -21,7 +21,7 @@ GameSettings.prototype.Attributes.MapPreview = class MapPreview extends GameSett
fromInitAttributes(attribs)
{
if (!!this.getLegacySetting(attribs, "mapPreview"))
if (this.getLegacySetting(attribs, "mapPreview"))
this.value = this.getLegacySetting(attribs, "mapPreview");
}

2
binaries/data/mods/public/gamesettings/attributes/MapSize.js
View file

@ -15,7 +15,7 @@ GameSettings.prototype.Attributes.MapSize = class MapSize extends GameSetting
fromInitAttributes(attribs)
{
if (!!this.getLegacySetting(attribs, "Size"))
if (this.getLegacySetting(attribs, "Size"))
this.setSize(this.getLegacySetting(attribs, "Size"));
}

2
binaries/data/mods/public/gamesettings/attributes/PlayerCiv.js
View file

@ -102,7 +102,7 @@ GameSettings.prototype.Attributes.PlayerCiv = class PlayerCiv extends GameSettin
_set(playerIndex, value)
{
const map = this._getMapData(playerIndex);
if (!!map)
if (map)
{
this.values[playerIndex] = map;
this.locked[playerIndex] = true;

2
binaries/data/mods/public/gamesettings/attributes/PlayerPlacement.js
View file

@ -15,7 +15,7 @@ GameSettings.prototype.Attributes.PlayerPlacement = class PlayerPlacement extend
fromInitAttributes(attribs)
{
if (!!this.getLegacySetting(attribs, "PlayerPlacement"))
if (this.getLegacySetting(attribs, "PlayerPlacement"))
this.value = this.getLegacySetting(attribs, "PlayerPlacement");
}

4
binaries/data/mods/public/gamesettings/attributes/Relic.js
View file

@ -21,9 +21,9 @@ GameSettings.prototype.Attributes.Relic = class Relic extends GameSetting
fromInitAttributes(attribs)
{
if (!!this.getLegacySetting(attribs, "RelicCount"))
if (this.getLegacySetting(attribs, "RelicCount"))
this.setCount(this.getLegacySetting(attribs, "RelicCount"));
if (!!this.getLegacySetting(attribs, "RelicDuration"))
if (this.getLegacySetting(attribs, "RelicDuration"))
this.setDuration(this.getLegacySetting(attribs, "RelicDuration"));
}

2
binaries/data/mods/public/gamesettings/attributes/SeaLevelRise.js
View file

@ -16,7 +16,7 @@ GameSettings.prototype.Attributes.SeaLevelRise = class SeaLevelRise extends Game
fromInitAttributes(attribs)
{
if (!!this.getLegacySetting(attribs, "SeaLevelRiseTime"))
if (this.getLegacySetting(attribs, "SeaLevelRiseTime"))
this.setValue(this.getLegacySetting(attribs, "SeaLevelRiseTime"));
}

2
binaries/data/mods/public/gamesettings/attributes/TriggerScripts.js
View file

@ -16,7 +16,7 @@ GameSettings.prototype.Attributes.TriggerScripts = class TriggerScripts extends
fromInitAttributes(attribs)
{
if (!!this.getLegacySetting(attribs, "TriggerScripts"))
if (this.getLegacySetting(attribs, "TriggerScripts"))
this.customScripts = new Set(this.getLegacySetting(attribs, "TriggerScripts"));
}

2
binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/AIDescription.js
View file

@ -20,7 +20,7 @@ class AIDescription
render()
{
let AI = g_GameSettings.playerAI.get(this.playerIndex);
if (!!AI)
if (AI)
AI = g_Settings.AIDescriptions.find(desc => desc.id == AI.bot);
this.aiDescription.caption = AI ? AI.data.description : this.NoAIDescription;
}

2
binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIBehavior.js
View file

@ -14,7 +14,7 @@ AIGameSettingControls.AIBehavior = class extends AIGameSettingControlDropdown
const ai = g_GameSettings.playerAI.get(this.playerIndex);
this.setHidden(!ai);
if (!!ai)
if (ai)
this.setSelectedValue(ai.behavior);
}

2
binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIDifficulty.js
View file

@ -14,7 +14,7 @@ AIGameSettingControls.AIDifficulty = class extends AIGameSettingControlDropdown
const ai = g_GameSettings.playerAI.get(this.playerIndex);
this.setHidden(!ai);
if (!!ai)
if (ai)
this.setSelectedValue(ai.difficulty);
}

2
binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AISelection.js
View file

@ -22,7 +22,7 @@ AIGameSettingControls.AISelection = class extends AIGameSettingControlDropdown
{
const ai = g_GameSettings.playerAI.get(this.playerIndex);
this.setHidden(!ai);
if (!!ai)
if (ai)
this.setSelectedValue(ai.bot);
else
this.setSelectedValue(undefined);

2
binaries/data/mods/public/simulation/components/StatusEffectsReceiver.js
View file

@ -68,7 +68,7 @@ StatusEffectsReceiver.prototype.AddStatus = function(baseCode, data, attacker =
let temp;
do
temp = statusCode + "_" + i++;
while (!!this.activeStatusEffects[temp]);
while (this.activeStatusEffects[temp]);
statusCode = temp;
}
}

2
binaries/data/mods/public/simulation/helpers/Attack.js
View file

@ -336,7 +336,7 @@ AttackHelper.prototype.HandleAttackEffects = function(target, data, bonusMultipl
});
// We do not want an entity to get XP from active Status Effects.
if (!!data.attackData.StatusEffect)
if (data.attackData.StatusEffect)
return true;
const cmpPromotion = Engine.QueryInterface(data.attacker, IID_Promotion);

4
binaries/data/mods/public/simulation/helpers/InitGame.js
View file

@ -49,12 +49,12 @@ function InitGame(settings)
if (settings.PlayerData[i])
{
if(!!settings.PlayerData[i].Removed)
if(settings.PlayerData[i].Removed)
{
cmpPlayer.Defeat(undefined);
continue;
}
else if (!!settings.PlayerData[i].AI)
else if (settings.PlayerData[i].AI)
{
cmpAIManager.AddPlayer(settings.PlayerData[i].AI, i, +settings.PlayerData[i].AIDiff, settings.PlayerData[i].AIBehavior || "random");
cmpPlayer.SetAI(true);

2
eslint.config.mjs
View file

@ -34,7 +34,7 @@ const configEslintRecommended = {
"no-dupe-keys": "warn",
"no-duplicate-case": "warn",
"no-empty": "warn",
"no-extra-boolean-cast": "off",
"no-extra-boolean-cast": "warn",
"no-func-assign": "warn",
"no-irregular-whitespace": "warn",
"no-obj-calls": "warn",