diff --git a/binaries/data/mods/mod/gui/modmod/modmod.js b/binaries/data/mods/mod/gui/modmod/modmod.js index 73ed374e3e..e4e9b7ffa9 100644 --- a/binaries/data/mods/mod/gui/modmod/modmod.js +++ b/binaries/data/mods/mod/gui/modmod/modmod.js @@ -98,7 +98,7 @@ function loadMods() */ function getMod(folder) { - return !!g_Mods[folder] ? g_Mods[folder] : g_FakeMod; + return g_Mods[folder] ? g_Mods[folder] : g_FakeMod; } function loadEnabledMods() @@ -248,7 +248,7 @@ function disableMod() break; } - if (!!g_Mods[disabledMod]) + if (g_Mods[disabledMod]) g_ModsDisabled.push(disabledMod); // Remove mods that required the removed mod and cascade diff --git a/binaries/data/mods/public/gamesettings/attributes/MapPreview.js b/binaries/data/mods/public/gamesettings/attributes/MapPreview.js index b438e585fc..77b8eb3fbd 100644 --- a/binaries/data/mods/public/gamesettings/attributes/MapPreview.js +++ b/binaries/data/mods/public/gamesettings/attributes/MapPreview.js @@ -21,7 +21,7 @@ GameSettings.prototype.Attributes.MapPreview = class MapPreview extends GameSett fromInitAttributes(attribs) { - if (!!this.getLegacySetting(attribs, "mapPreview")) + if (this.getLegacySetting(attribs, "mapPreview")) this.value = this.getLegacySetting(attribs, "mapPreview"); } diff --git a/binaries/data/mods/public/gamesettings/attributes/MapSize.js b/binaries/data/mods/public/gamesettings/attributes/MapSize.js index e3c553417c..d94ccc425c 100644 --- a/binaries/data/mods/public/gamesettings/attributes/MapSize.js +++ b/binaries/data/mods/public/gamesettings/attributes/MapSize.js @@ -15,7 +15,7 @@ GameSettings.prototype.Attributes.MapSize = class MapSize extends GameSetting fromInitAttributes(attribs) { - if (!!this.getLegacySetting(attribs, "Size")) + if (this.getLegacySetting(attribs, "Size")) this.setSize(this.getLegacySetting(attribs, "Size")); } diff --git a/binaries/data/mods/public/gamesettings/attributes/PlayerCiv.js b/binaries/data/mods/public/gamesettings/attributes/PlayerCiv.js index 9d799afa7c..27a8156bce 100644 --- a/binaries/data/mods/public/gamesettings/attributes/PlayerCiv.js +++ b/binaries/data/mods/public/gamesettings/attributes/PlayerCiv.js @@ -102,7 +102,7 @@ GameSettings.prototype.Attributes.PlayerCiv = class PlayerCiv extends GameSettin _set(playerIndex, value) { const map = this._getMapData(playerIndex); - if (!!map) + if (map) { this.values[playerIndex] = map; this.locked[playerIndex] = true; diff --git a/binaries/data/mods/public/gamesettings/attributes/PlayerPlacement.js b/binaries/data/mods/public/gamesettings/attributes/PlayerPlacement.js index de46510837..f46a23481f 100644 --- a/binaries/data/mods/public/gamesettings/attributes/PlayerPlacement.js +++ b/binaries/data/mods/public/gamesettings/attributes/PlayerPlacement.js @@ -15,7 +15,7 @@ GameSettings.prototype.Attributes.PlayerPlacement = class PlayerPlacement extend fromInitAttributes(attribs) { - if (!!this.getLegacySetting(attribs, "PlayerPlacement")) + if (this.getLegacySetting(attribs, "PlayerPlacement")) this.value = this.getLegacySetting(attribs, "PlayerPlacement"); } diff --git a/binaries/data/mods/public/gamesettings/attributes/Relic.js b/binaries/data/mods/public/gamesettings/attributes/Relic.js index bb42b3a445..5f55a0b8e4 100644 --- a/binaries/data/mods/public/gamesettings/attributes/Relic.js +++ b/binaries/data/mods/public/gamesettings/attributes/Relic.js @@ -21,9 +21,9 @@ GameSettings.prototype.Attributes.Relic = class Relic extends GameSetting fromInitAttributes(attribs) { - if (!!this.getLegacySetting(attribs, "RelicCount")) + if (this.getLegacySetting(attribs, "RelicCount")) this.setCount(this.getLegacySetting(attribs, "RelicCount")); - if (!!this.getLegacySetting(attribs, "RelicDuration")) + if (this.getLegacySetting(attribs, "RelicDuration")) this.setDuration(this.getLegacySetting(attribs, "RelicDuration")); } diff --git a/binaries/data/mods/public/gamesettings/attributes/SeaLevelRise.js b/binaries/data/mods/public/gamesettings/attributes/SeaLevelRise.js index b220cc313f..3700793500 100644 --- a/binaries/data/mods/public/gamesettings/attributes/SeaLevelRise.js +++ b/binaries/data/mods/public/gamesettings/attributes/SeaLevelRise.js @@ -16,7 +16,7 @@ GameSettings.prototype.Attributes.SeaLevelRise = class SeaLevelRise extends Game fromInitAttributes(attribs) { - if (!!this.getLegacySetting(attribs, "SeaLevelRiseTime")) + if (this.getLegacySetting(attribs, "SeaLevelRiseTime")) this.setValue(this.getLegacySetting(attribs, "SeaLevelRiseTime")); } diff --git a/binaries/data/mods/public/gamesettings/attributes/TriggerScripts.js b/binaries/data/mods/public/gamesettings/attributes/TriggerScripts.js index 6daf04d7b3..3454d55170 100644 --- a/binaries/data/mods/public/gamesettings/attributes/TriggerScripts.js +++ b/binaries/data/mods/public/gamesettings/attributes/TriggerScripts.js @@ -16,7 +16,7 @@ GameSettings.prototype.Attributes.TriggerScripts = class TriggerScripts extends fromInitAttributes(attribs) { - if (!!this.getLegacySetting(attribs, "TriggerScripts")) + if (this.getLegacySetting(attribs, "TriggerScripts")) this.customScripts = new Set(this.getLegacySetting(attribs, "TriggerScripts")); } diff --git a/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/AIDescription.js b/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/AIDescription.js index 5c72a148af..a26f77dfef 100644 --- a/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/AIDescription.js +++ b/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/AIDescription.js @@ -20,7 +20,7 @@ class AIDescription render() { let AI = g_GameSettings.playerAI.get(this.playerIndex); - if (!!AI) + if (AI) AI = g_Settings.AIDescriptions.find(desc => desc.id == AI.bot); this.aiDescription.caption = AI ? AI.data.description : this.NoAIDescription; } diff --git a/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIBehavior.js b/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIBehavior.js index cfe4f1af4f..1a5fe7ea14 100644 --- a/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIBehavior.js +++ b/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIBehavior.js @@ -14,7 +14,7 @@ AIGameSettingControls.AIBehavior = class extends AIGameSettingControlDropdown const ai = g_GameSettings.playerAI.get(this.playerIndex); this.setHidden(!ai); - if (!!ai) + if (ai) this.setSelectedValue(ai.behavior); } diff --git a/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIDifficulty.js b/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIDifficulty.js index fd715e0d4c..dfb56a7433 100644 --- a/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIDifficulty.js +++ b/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIDifficulty.js @@ -14,7 +14,7 @@ AIGameSettingControls.AIDifficulty = class extends AIGameSettingControlDropdown const ai = g_GameSettings.playerAI.get(this.playerIndex); this.setHidden(!ai); - if (!!ai) + if (ai) this.setSelectedValue(ai.difficulty); } diff --git a/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AISelection.js b/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AISelection.js index b4cbbc4a94..0fe80e7df8 100644 --- a/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AISelection.js +++ b/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AISelection.js @@ -22,7 +22,7 @@ AIGameSettingControls.AISelection = class extends AIGameSettingControlDropdown { const ai = g_GameSettings.playerAI.get(this.playerIndex); this.setHidden(!ai); - if (!!ai) + if (ai) this.setSelectedValue(ai.bot); else this.setSelectedValue(undefined); diff --git a/binaries/data/mods/public/simulation/components/StatusEffectsReceiver.js b/binaries/data/mods/public/simulation/components/StatusEffectsReceiver.js index 96b1f1123f..d3bc39b6f9 100644 --- a/binaries/data/mods/public/simulation/components/StatusEffectsReceiver.js +++ b/binaries/data/mods/public/simulation/components/StatusEffectsReceiver.js @@ -68,7 +68,7 @@ StatusEffectsReceiver.prototype.AddStatus = function(baseCode, data, attacker = let temp; do temp = statusCode + "_" + i++; - while (!!this.activeStatusEffects[temp]); + while (this.activeStatusEffects[temp]); statusCode = temp; } } diff --git a/binaries/data/mods/public/simulation/helpers/Attack.js b/binaries/data/mods/public/simulation/helpers/Attack.js index e1bd334a85..dfa13251ff 100644 --- a/binaries/data/mods/public/simulation/helpers/Attack.js +++ b/binaries/data/mods/public/simulation/helpers/Attack.js @@ -336,7 +336,7 @@ AttackHelper.prototype.HandleAttackEffects = function(target, data, bonusMultipl }); // We do not want an entity to get XP from active Status Effects. - if (!!data.attackData.StatusEffect) + if (data.attackData.StatusEffect) return true; const cmpPromotion = Engine.QueryInterface(data.attacker, IID_Promotion); diff --git a/binaries/data/mods/public/simulation/helpers/InitGame.js b/binaries/data/mods/public/simulation/helpers/InitGame.js index 034a5e67cd..3db0154de5 100644 --- a/binaries/data/mods/public/simulation/helpers/InitGame.js +++ b/binaries/data/mods/public/simulation/helpers/InitGame.js @@ -49,12 +49,12 @@ function InitGame(settings) if (settings.PlayerData[i]) { - if(!!settings.PlayerData[i].Removed) + if(settings.PlayerData[i].Removed) { cmpPlayer.Defeat(undefined); continue; } - else if (!!settings.PlayerData[i].AI) + else if (settings.PlayerData[i].AI) { cmpAIManager.AddPlayer(settings.PlayerData[i].AI, i, +settings.PlayerData[i].AIDiff, settings.PlayerData[i].AIBehavior || "random"); cmpPlayer.SetAI(true); diff --git a/eslint.config.mjs b/eslint.config.mjs index 0cbc63fdd6..82e85929cd 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -34,7 +34,7 @@ const configEslintRecommended = { "no-dupe-keys": "warn", "no-duplicate-case": "warn", "no-empty": "warn", - "no-extra-boolean-cast": "off", + "no-extra-boolean-cast": "warn", "no-func-assign": "warn", "no-irregular-whitespace": "warn", "no-obj-calls": "warn",