dallasgroot/0ad
1
0
Fork 0
mirror of https://gitea.wildfiregames.com/0ad/0ad synced 2026-06-16 05:13:58 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Cleanup Atlas SectionLayout

Browse source 
Don't declare empty constructor and destructor, avoid c-style cast and
remove TODO about a bug that can't be reproduced any longer.

Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
This commit is contained in:
Ralph Sennhauser 2026-06-03 19:37:01 +02:00
parent e3afa15966
commit 0599848330
No known key found for this signature in database
2 changed files with 3 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
source/tools/atlas/AtlasUI/ScenarioEditor/SectionLayout.cpp
View file

@ -1,4 +1,4 @@
/* Copyright (C) 2025 Wildfire Games.
/* Copyright (C) 2026 Wildfire Games.
* This file is part of 0 A.D.
*
* 0 A.D. is free software: you can redistribute it and/or modify
@ -271,14 +271,6 @@ void SidebarButton::OnClick(wxCommandEvent& WXUNUSED(event))
//////////////////////////////////////////////////////////////////////////
SectionLayout::SectionLayout()
{
}
SectionLayout::~SectionLayout()
{
}
void SectionLayout::SetWindow(wxWindow* window)
{
m_HorizSplitter = new SnapSplitterWindow(
@ -299,9 +291,6 @@ void SectionLayout::SetCanvas(wxWindow* canvas)
void SectionLayout::Build(ScenarioEditor& scenarioEditor)
{
// TODO: wxWidgets bug (http://sourceforge.net/tracker/index.php?func=detail&aid=1298803&group_id=9863&atid=109863)
// - pressing menu keys (e.g. alt+f) with notebook tab focussed causes application to freeze
m_SidebarBook = new SidebarBook(m_HorizSplitter, m_VertSplitter);
Sidebar* sidebar;
@ -330,7 +319,7 @@ void SectionLayout::Build(ScenarioEditor& scenarioEditor)
void SectionLayout::SelectPage(const wxString& classname)
{
std::map<std::wstring, int>::iterator it = m_PageMappings.find((std::wstring)classname.wc_str());
std::map<std::wstring, int>::iterator it = m_PageMappings.find(classname.ToStdWstring());
if (it != m_PageMappings.end())
m_SidebarBook->SetSelection(it->second);
}

5
source/tools/atlas/AtlasUI/ScenarioEditor/SectionLayout.h
View file

@ -1,4 +1,4 @@
/* Copyright (C) 2025 Wildfire Games.
/* Copyright (C) 2026 Wildfire Games.
* This file is part of 0 A.D.
*
* 0 A.D. is free software: you can redistribute it and/or modify
@ -42,9 +42,6 @@ class wxWindow;
class SectionLayout
{
public:
SectionLayout();
~SectionLayout();
void SetWindow(wxWindow* window);
wxWindow* GetCanvasParent();
void SetCanvas(wxWindow*);