Use Symbols to store JS object references when serialising and delete ObjectIDCache
When serialising JS objects, we keep track of any encountered object,
and serialize it only once. Any further serialisation instead stores an
ID referring to the original object (essentially an opaque pointer).
The trouble of course is to have a unique, persistent identifier for
such an object.
svn uses an ObjectIDCache, essentially a "JS Object -> ID" map (which
internally is essentially a "JS heap pointer -> ID" map).
JS, since ES15, includes a "Symbol" primitive type, which is a unique,
immutable identifier. They are also not iterable by for..in or
GetOwnPropertyName or related.
This means they can be used to store the tag directly on the object
(since it's impossible overwrite a user property).
Thanks to this, we can forgo ObjectIDCache in the serializers, and since
following D2897 it becomes unused, we can delete it, along with the
Finalization code it used.
Part of SM52 migration, stage: SM45-compatible changes.
Patch by: Itms
Tested By: Freagarach
Refs #4893
Differential Revision: https://code.wildfiregames.com/D3085
This was SVN commit r24167.
2020-11-11 22:40:19 -08:00
|
|
|
/* Copyright (C) 2020 Wildfire Games.
|
2014-11-13 03:19:28 -08:00
|
|
|
* This file is part of 0 A.D.
|
|
|
|
|
*
|
|
|
|
|
* 0 A.D. is free software: you can redistribute it and/or modify
|
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
|
|
|
* (at your option) any later version.
|
|
|
|
|
*
|
|
|
|
|
* 0 A.D. is distributed in the hope that it will be useful,
|
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
|
*
|
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
|
* along with 0 A.D. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
*/
|
2016-11-23 03:18:37 -08:00
|
|
|
|
2020-11-14 02:57:50 -08:00
|
|
|
#ifndef INCLUDED_SCRIPTCONTEXT
|
|
|
|
|
#define INCLUDED_SCRIPTCONTEXT
|
2014-11-13 03:19:28 -08:00
|
|
|
|
|
|
|
|
#include "ScriptTypes.h"
|
|
|
|
|
#include "ScriptExtraHeaders.h"
|
|
|
|
|
|
2018-12-28 06:58:35 -08:00
|
|
|
#include <sstream>
|
|
|
|
|
|
2020-11-12 01:34:40 -08:00
|
|
|
constexpr int STACK_CHUNK_SIZE = 8192;
|
|
|
|
|
|
|
|
|
|
// Those are minimal defaults. The runtime for the main game is larger and GCs upon a larger growth.
|
2020-11-14 02:57:50 -08:00
|
|
|
constexpr int DEFAULT_CONTEXT_SIZE = 16 * 1024 * 1024;
|
2020-11-12 01:34:40 -08:00
|
|
|
constexpr int DEFAULT_HEAP_GROWTH_BYTES_GCTRIGGER = 2 * 1024 * 1024;
|
2014-11-13 03:19:28 -08:00
|
|
|
|
|
|
|
|
/**
|
2020-11-14 00:46:32 -08:00
|
|
|
* Abstraction around a SpiderMonkey JSRuntime/JSContext.
|
|
|
|
|
*
|
2020-11-14 02:57:50 -08:00
|
|
|
* A single ScriptContext, with the associated runtime and context,
|
2020-11-14 00:46:32 -08:00
|
|
|
* should only be used on a single thread.
|
2014-11-13 03:19:28 -08:00
|
|
|
*
|
2020-11-14 02:57:50 -08:00
|
|
|
* (One means to share data between threads and contexts is to create
|
2014-11-13 03:19:28 -08:00
|
|
|
* a ScriptInterface::StructuredClone.)
|
|
|
|
|
*/
|
2016-08-07 10:44:27 -07:00
|
|
|
|
2020-11-14 02:57:50 -08:00
|
|
|
class ScriptContext
|
2014-11-13 03:19:28 -08:00
|
|
|
{
|
|
|
|
|
public:
|
2020-11-14 02:57:50 -08:00
|
|
|
ScriptContext(int contextSize, int heapGrowthBytesGCTrigger);
|
|
|
|
|
~ScriptContext();
|
2014-11-13 03:19:28 -08:00
|
|
|
|
2020-11-12 01:34:40 -08:00
|
|
|
/**
|
2020-11-14 02:57:50 -08:00
|
|
|
* Returns a context, in which any number of ScriptInterfaces compartments can live.
|
|
|
|
|
* Each context should only ever be used on a single thread.
|
|
|
|
|
* @param parentContext Parent context from the parent thread, with which we share some thread-safe data
|
|
|
|
|
* @param contextSize Maximum size in bytes of the new context
|
2020-11-12 01:34:40 -08:00
|
|
|
* @param heapGrowthBytesGCTrigger Size in bytes of cumulated allocations after which a GC will be triggered
|
|
|
|
|
*/
|
2020-11-14 02:57:50 -08:00
|
|
|
static shared_ptr<ScriptContext> CreateContext(
|
|
|
|
|
int contextSize = DEFAULT_CONTEXT_SIZE,
|
2020-11-12 01:34:40 -08:00
|
|
|
int heapGrowthBytesGCTrigger = DEFAULT_HEAP_GROWTH_BYTES_GCTRIGGER);
|
|
|
|
|
|
2014-11-13 03:19:28 -08:00
|
|
|
/**
|
2020-11-14 02:57:50 -08:00
|
|
|
* MaybeIncrementalGC tries to determine whether a context-wide garbage collection would free up enough memory to
|
2014-11-13 03:19:28 -08:00
|
|
|
* be worth the amount of time it would take. It does this with our own logic and NOT some predefined JSAPI logic because
|
|
|
|
|
* such functionality currently isn't available out of the box.
|
|
|
|
|
* It does incremental GC which means it will collect one slice each time it's called until the garbage collection is done.
|
|
|
|
|
* This can and should be called quite regularly. The delay parameter allows you to specify a minimum time since the last GC
|
2016-08-07 10:44:27 -07:00
|
|
|
* in seconds (the delay should be a fraction of a second in most cases though).
|
|
|
|
|
* It will only start a new incremental GC or another GC slice if this time is exceeded. The user of this function is
|
2014-11-13 03:19:28 -08:00
|
|
|
* responsible for ensuring that GC can run with a small enough delay to get done with the work.
|
2015-01-24 06:46:52 -08:00
|
|
|
*/
|
2014-11-13 03:19:28 -08:00
|
|
|
void MaybeIncrementalGC(double delay);
|
2015-01-24 06:46:52 -08:00
|
|
|
void ShrinkingGC();
|
2016-08-02 09:12:11 -07:00
|
|
|
|
2020-11-14 00:46:32 -08:00
|
|
|
/**
|
|
|
|
|
* This is used to keep track of compartments which should be prepared for a GC.
|
|
|
|
|
*/
|
|
|
|
|
void RegisterCompartment(JSCompartment* cmpt);
|
|
|
|
|
void UnRegisterCompartment(JSCompartment* cmpt);
|
2016-08-02 09:12:11 -07:00
|
|
|
|
2020-11-14 00:46:32 -08:00
|
|
|
JSRuntime* GetJSRuntime() const { return m_rt; }
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* GetGeneralJSContext returns the context without starting a GC request and without
|
|
|
|
|
* entering any compartment. It should only be used in specific situations, such as
|
|
|
|
|
* creating a new compartment, or as an unsafe alternative to GetJSRuntime.
|
|
|
|
|
* If you need the compartmented context of a ScriptInterface, you should create a
|
|
|
|
|
* ScriptInterface::Request and use the context from that.
|
|
|
|
|
*/
|
|
|
|
|
JSContext* GetGeneralJSContext() const { return m_cx; }
|
2014-11-13 03:19:28 -08:00
|
|
|
|
|
|
|
|
private:
|
2016-08-02 09:12:11 -07:00
|
|
|
|
2020-11-14 00:46:32 -08:00
|
|
|
JSRuntime* m_rt;
|
|
|
|
|
JSContext* m_cx;
|
2016-08-07 10:44:27 -07:00
|
|
|
|
2020-11-14 00:46:32 -08:00
|
|
|
void PrepareCompartmentsForIncrementalGC() const;
|
|
|
|
|
std::list<JSCompartment*> m_Compartments;
|
2016-08-02 09:12:11 -07:00
|
|
|
|
2020-11-14 02:57:50 -08:00
|
|
|
int m_ContextSize;
|
2014-11-13 03:19:28 -08:00
|
|
|
int m_HeapGrowthBytesGCTrigger;
|
|
|
|
|
int m_LastGCBytes;
|
|
|
|
|
double m_LastGCCheck;
|
|
|
|
|
};
|
|
|
|
|
|
2020-11-14 02:57:50 -08:00
|
|
|
#endif // INCLUDED_SCRIPTCONTEXT
|