Replay: name replay folders after matchID instead of a per-machine index
Replay folders were named YYYY-MM-DD_NNNN, a per-machine sequence
counter. The same multiplayer match got a different folder name per
participant, and unrelated matches could share a name, making it hard
to correlate replays across players (rating aggregation, replay
sharing, bug reports) without parsing commands.txt first.
The engine already generates a matchID once per match, synced to all
participants before the match starts. Replay folders are now named
YYYY-MM-DD_<matchID>, so the same match produces the same folder name
everywhere.
The date comes from a new "startTime" attribute, set once by the host
(StartTime.js, alongside MatchID.js) and synced like matchID, instead
of each machine reading its own local clock. createDateIndexSubdirectory
is untouched (still used by OOS logs and serialization tests); a new
createReplaySubdirectory is added for replays only, following the same
collision-handling pattern (incrementing suffix) as the existing
function. This also means resuming a match (network rejoin, or a
singleplayer game reloaded via StartSavedGame, both of which reuse the
same matchID) saves an additional replay instead of overwriting the
original.
Fixes #8922
2026-07-06 22:49:19 -07:00
|
|
|
/* Copyright (C) 2026 Wildfire Games.
|
2023-12-02 16:30:12 -08:00
|
|
|
* This file is part of 0 A.D.
|
2009-04-18 10:00:33 -07:00
|
|
|
*
|
2023-12-02 16:30:12 -08:00
|
|
|
* 0 A.D. is free software: you can redistribute it and/or modify
|
2009-04-18 10:00:33 -07:00
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
|
|
|
* (at your option) any later version.
|
|
|
|
|
*
|
2023-12-02 16:30:12 -08:00
|
|
|
* 0 A.D. is distributed in the hope that it will be useful,
|
2009-04-18 10:00:33 -07:00
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
|
*
|
|
|
|
|
* You should have received a copy of the GNU General Public License
|
2023-12-02 16:30:12 -08:00
|
|
|
* along with 0 A.D. If not, see <http://www.gnu.org/licenses/>.
|
2009-04-18 10:00:33 -07:00
|
|
|
*/
|
|
|
|
|
|
2010-02-17 15:21:49 -08:00
|
|
|
#ifndef PS_UTIL_H
|
|
|
|
|
#define PS_UTIL_H
|
|
|
|
|
|
2011-02-10 08:06:28 -08:00
|
|
|
#include "lib/file/vfs/vfs_path.h"
|
2022-04-12 10:39:05 -07:00
|
|
|
#include "lib/os_path.h"
|
|
|
|
|
#include "lib/status.h"
|
2025-08-03 08:30:17 -07:00
|
|
|
#include "lib/types.h"
|
2022-04-12 10:39:05 -07:00
|
|
|
#include "ps/CStr.h"
|
2011-02-10 08:06:28 -08:00
|
|
|
|
2025-08-03 08:30:17 -07:00
|
|
|
#include <cstddef>
|
|
|
|
|
#include <string>
|
|
|
|
|
|
2022-02-13 11:30:28 -08:00
|
|
|
class Tex;
|
2011-02-10 08:06:28 -08:00
|
|
|
|
2016-08-08 05:50:39 -07:00
|
|
|
const wchar_t* ErrorString(int err);
|
2006-04-23 16:14:18 -07:00
|
|
|
|
2022-04-12 10:39:05 -07:00
|
|
|
CStr GetStatusAsString(Status status);
|
|
|
|
|
|
2016-08-08 05:50:39 -07:00
|
|
|
OsPath createDateIndexSubdirectory(const OsPath& parentDir);
|
2016-02-15 07:57:23 -08:00
|
|
|
|
Replay: name replay folders after matchID instead of a per-machine index
Replay folders were named YYYY-MM-DD_NNNN, a per-machine sequence
counter. The same multiplayer match got a different folder name per
participant, and unrelated matches could share a name, making it hard
to correlate replays across players (rating aggregation, replay
sharing, bug reports) without parsing commands.txt first.
The engine already generates a matchID once per match, synced to all
participants before the match starts. Replay folders are now named
YYYY-MM-DD_<matchID>, so the same match produces the same folder name
everywhere.
The date comes from a new "startTime" attribute, set once by the host
(StartTime.js, alongside MatchID.js) and synced like matchID, instead
of each machine reading its own local clock. createDateIndexSubdirectory
is untouched (still used by OOS logs and serialization tests); a new
createReplaySubdirectory is added for replays only, following the same
collision-handling pattern (incrementing suffix) as the existing
function. This also means resuming a match (network rejoin, or a
singleplayer game reloaded via StartSavedGame, both of which reuse the
same matchID) saves an additional replay instead of overwriting the
original.
Fixes #8922
2026-07-06 22:49:19 -07:00
|
|
|
OsPath createReplaySubdirectory(const OsPath& parentDir, const std::wstring& matchID, double startTimeMillis);
|
|
|
|
|
|
2016-08-08 05:50:39 -07:00
|
|
|
Status tex_write(Tex* t, const VfsPath& filename);
|
|
|
|
|
|
|
|
|
|
std::string Hexify(const std::string& s);
|
2018-08-08 05:59:05 -07:00
|
|
|
std::string Hexify(const u8* s, size_t length);
|
2011-02-10 08:06:28 -08:00
|
|
|
|
2010-02-17 15:21:49 -08:00
|
|
|
#endif // PS_UTIL_H
|