52928e04a5
This is untested on my side, because the bug only happens on native
builds with meson (our CI has cross-builds with meson and native builds
with autotools and I only do cross-builds locally) but I think/hope it
will work.
Basically we were using .full_path() because these rc files were also
used as input of some configure_file() calls which doesn't like custom
target objects as input (it wants strings or file objects). Yet a bug
in meson didn't like the colon used in native Windows full paths ('C:'
and such) when used in windows.compile_resources(). This has been fixed
by Luca Bacci in: https://github.com/mesonbuild/meson/pull/9368
Yet we just cannot depend on very early meson (or worse dev meson code).
On the other hand, if the input is a custom_tgt object, it uses the
object ID which we give as first parameter of custom_target() so we know
it's appropriately named without colons (such as 'gimp_plugins_rc').
Thus we should not bump into this issue again.
For the few usage in configure_file(), I just add a .full_path() only
when needed at call time.
Last but not least, I replace the bogus `meson --version` call by a
`python3 -c 'exit()'` as advised by Eli Schwartz:
2afa019c70 (note_1284951)
The reason is that it is apparently possible (or will be when some
reimplementation of meson will be done) that the `meson` executable
itself does not exist. On the other hand, `python3` should always be
there, as a mandatory dependency of the build tool.
In order to use an appropriate `python3`, I made the
pythonmod.find_installation() check required in our build (which should
not be a problem since it's a meson requirement as well), even when the
-Dpython option is false (this one depends on other requirements too
anyway, such as version and pygobject). This way I can call this meson
variable of discovered python in my bogus call, instead of calling a
(potentially different) python from PATH environment.
85 lines
1.8 KiB
Meson
85 lines
1.8 KiB
Meson
|
|
plugin_name = 'metadata-editor'
|
|
|
|
plugin_sources = [
|
|
'metadata-editor.c',
|
|
'metadata-impexp.c',
|
|
'metadata-tags.c',
|
|
'metadata-xml.c',
|
|
]
|
|
|
|
if platform_windows
|
|
plugin_rc = configure_file(
|
|
input : gimp_plugins_rc.full_path(),
|
|
output: plugin_name + '.rc',
|
|
copy: true,
|
|
)
|
|
plugin_sources += windows.compile_resources(
|
|
plugin_rc,
|
|
args: [
|
|
'--define', 'ORIGINALFILENAME_STR="@0@"'.format(plugin_name+'.exe'),
|
|
'--define', 'INTERNALNAME_STR="@0@"' .format(plugin_name),
|
|
'--define', 'TOP_SRCDIR="@0@"' .format(meson.source_root()),
|
|
],
|
|
include_directories: [
|
|
rootInclude, appInclude,
|
|
],
|
|
)
|
|
endif
|
|
|
|
executable(plugin_name,
|
|
plugin_sources,
|
|
dependencies: [
|
|
libgimpui_dep,
|
|
gexiv2,
|
|
],
|
|
install: true,
|
|
install_dir: gimpplugindir / 'plug-ins' / plugin_name,
|
|
)
|
|
|
|
###############################################################################
|
|
|
|
plugin_name = 'metadata-viewer'
|
|
|
|
plugin_sources = [
|
|
'metadata-viewer.c',
|
|
'metadata-tags.c',
|
|
]
|
|
|
|
if platform_windows
|
|
plugin_rc = configure_file(
|
|
input : gimp_plugins_rc.full_path(),
|
|
output: plugin_name + '.rc',
|
|
copy: true,
|
|
)
|
|
plugin_sources += windows.compile_resources(
|
|
plugin_rc,
|
|
args: [
|
|
'--define', 'ORIGINALFILENAME_STR="@0@"'.format(plugin_name+'.exe'),
|
|
'--define', 'INTERNALNAME_STR="@0@"' .format(plugin_name),
|
|
'--define', 'TOP_SRCDIR="@0@"' .format(meson.source_root()),
|
|
],
|
|
include_directories: [
|
|
rootInclude, appInclude,
|
|
],
|
|
)
|
|
endif
|
|
|
|
executable(plugin_name,
|
|
plugin_sources,
|
|
include_directories: [ rootInclude, ],
|
|
dependencies: [
|
|
gtk3, gegl, gexiv2,
|
|
],
|
|
link_with: [
|
|
libgimp,
|
|
libgimpbase,
|
|
libgimpcolor,
|
|
libgimpconfig,
|
|
libgimpmath,
|
|
libgimpui,
|
|
libgimpwidgets,
|
|
],
|
|
install: true,
|
|
install_dir: gimpplugindir / 'plug-ins' / plugin_name,
|
|
)
|