d59a7af38c
Simplifies chooser widgets (e.g. GimpBrushSelect) by eliminating attributes (e.g. opacity) of chosen resource. See #8745, but this commit fixes that by first refactoring the code. Refactors GUI widgets (e.g. GimpBrushSelectButton and GimpBrushSelect etc.) Refactor by "Extract class" GimpResourceSelectButton from GimpBrushSelectButton etc. This moves common code into an inherited class (formerly called GimpSelectButton) but the subclasses still exist. The subclasses mainly just do drawing now. Refactor by "Extract module" GimpResourceSelect from GimpBrushSelect etc. Moves common code into one file, generic at runtime on type of GimpResource, that is, the new code dispatches on type i.e. switch statements. In the future, when core is changed some of that can be deleted. The files gimpbrushselect.[c,h] etc. are deleted. The module adapts the API from core to the API of callbacks to libgimp. Note that core is running the resource chooser (select) widgets remotely. Core is still calling back over the wire via PDB with more attributes than necessary. The new design gets the attributes from the resource themselves, instead of receiving them from core callback. The libgimp side adapts by discarding unneeded attributes. In the future, core (running choosers for plugins) can be simplified also. Fix gimp_prop_chooser_brush_new same as other resources. Finish changes, and clean style. Annotations
115 lines
3.5 KiB
Text
115 lines
3.5 KiB
Text
# GIMP - The GNU Image Manipulation Program
|
|
# Copyright (C) 1995 Spencer Kimball and Peter Mattis
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
# "Perlized" from C source by Manish Singh <yosh@gimp.org>
|
|
|
|
sub brushes_popup {
|
|
$blurb = 'Invokes the GIMP brush selection dialog.';
|
|
$help = 'Opens a dialog letting a user choose a brush.';
|
|
|
|
&andy_pdb_misc('1998');
|
|
|
|
@inargs = (
|
|
{ name => 'brush_callback', type => 'string', non_empty => 1,
|
|
desc => 'The callback PDB proc to call when user chooses a brush' },
|
|
{ name => 'popup_title', type => 'string',
|
|
desc => 'Title of the brush selection dialog' },
|
|
{ name => 'initial_brush_name', type => 'string', null_ok => 1,
|
|
desc => 'The name of the brush to set as the initial choice' }
|
|
);
|
|
|
|
%invoke = (
|
|
code => <<'CODE'
|
|
{
|
|
if (gimp->no_interface ||
|
|
! gimp_pdb_lookup_procedure (gimp->pdb, brush_callback) ||
|
|
! gimp_pdb_dialog_new (gimp, context, progress,
|
|
gimp_data_factory_get_container (gimp->brush_factory),
|
|
popup_title, brush_callback, initial_brush_name,
|
|
NULL))
|
|
success = FALSE;
|
|
}
|
|
CODE
|
|
);
|
|
}
|
|
|
|
sub brushes_close_popup {
|
|
$blurb = 'Close the brush selection dialog.';
|
|
$help = 'Closes an open brush selection dialog.';
|
|
|
|
&andy_pdb_misc('1998');
|
|
|
|
@inargs = (
|
|
{ name => 'brush_callback', type => 'string', non_empty => 1,
|
|
desc => 'The name of the callback registered for this pop-up' }
|
|
);
|
|
|
|
%invoke = (
|
|
code => <<'CODE'
|
|
{
|
|
if (gimp->no_interface ||
|
|
! gimp_pdb_lookup_procedure (gimp->pdb, brush_callback) ||
|
|
! gimp_pdb_dialog_close (gimp, gimp_data_factory_get_container (gimp->brush_factory),
|
|
brush_callback))
|
|
success = FALSE;
|
|
}
|
|
CODE
|
|
);
|
|
}
|
|
|
|
sub brushes_set_popup {
|
|
$blurb = 'Sets the selected brush in a brush selection dialog.';
|
|
$help = $blurb;
|
|
|
|
&andy_pdb_misc('1998');
|
|
|
|
@inargs = (
|
|
{ name => 'brush_callback', type => 'string', non_empty => 1,
|
|
desc => 'The name of the callback registered for this pop-up' },
|
|
{ name => 'brush_name', type => 'string',
|
|
desc => 'The name of the brush to set as selected' }
|
|
);
|
|
|
|
%invoke = (
|
|
code => <<'CODE'
|
|
{
|
|
if (gimp->no_interface ||
|
|
! gimp_pdb_lookup_procedure (gimp->pdb, brush_callback) ||
|
|
! gimp_pdb_dialog_set (gimp, gimp_data_factory_get_container (gimp->brush_factory),
|
|
brush_callback, brush_name,
|
|
NULL))
|
|
success = FALSE;
|
|
}
|
|
CODE
|
|
);
|
|
}
|
|
|
|
|
|
@headers = qw("core/gimp.h"
|
|
"core/gimpdatafactory.h");
|
|
|
|
@procs = qw(brushes_popup
|
|
brushes_close_popup
|
|
brushes_set_popup);
|
|
|
|
%exports = (app => [@procs], lib => [@procs]);
|
|
|
|
$desc = 'Brush UI';
|
|
$doc_title = 'gimpbrushselect';
|
|
$doc_short_desc = 'Methods of a font chooser dialog';
|
|
$doc_long_desc = 'A dialog letting a user choose a brush. Read more at gimpfontselect.';
|
|
|
|
1;
|