No description
d32a24f4e9
After testing a bit more, I realized that the thread was constantly re-rendering
the thumbnails, even though I didn't touch the "white-background"
button/argument.
This was not just a completely invisible problem, it actually affected the page
selection (it was very hard to select pages by clicking on them, it was randomly
working, and more often not selecting anything). This is how I realized there
was a problem.
The reason was simply that I was never actually calling g_cond_wait() because of
a first_loop flag I forgot to set.
Note that docs of g_cond_wait() explains that it is possible that "spurious
wakeup" happen. At first I thought I had this issue, which is why this commit
also adds a boolean flag to check after a wakeup, to make sure that I was in the
"condition met" case and not the "spurious wakeup" one.
Even though I realized afterwards the real reason was much more stupid, I still
left this additional check.
Fortunately this issue doesn't seem to affect the 2.10 code. Or to be more
accurate: the continuous render very likely happens there too, yet it doesn't
break page selection interaction with GTK+2 as far as I can see.
(cherry picked from commit
|
||
|---|---|---|
| app | ||
| app-tools | ||
| build | ||
| cursors | ||
| data | ||
| desktop | ||
| devel-docs | ||
| docs | ||
| etc | ||
| icons | ||
| libgimp | ||
| libgimpbase | ||
| libgimpcolor | ||
| libgimpconfig | ||
| libgimpmath | ||
| libgimpmodule | ||
| libgimpthumb | ||
| libgimpwidgets | ||
| m4macros | ||
| menus | ||
| modules | ||
| pdb | ||
| plug-ins | ||
| po | ||
| po-libgimp | ||
| po-plug-ins | ||
| po-python | ||
| po-script-fu | ||
| po-tags | ||
| po-tips | ||
| po-windows-installer | ||
| themes | ||
| tools | ||
| .dir-locals.el | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .gitmodules | ||
| .kateconfig | ||
| acinclude.m4 | ||
| AUTHORS | ||
| authors.dtd | ||
| authors.xml | ||
| authors.xsl | ||
| authors4gimp-web.xsl | ||
| autogen.sh | ||
| ChangeLog.pre-1-0 | ||
| ChangeLog.pre-1-2 | ||
| ChangeLog.pre-2-0 | ||
| ChangeLog.pre-2-2 | ||
| ChangeLog.pre-2-4 | ||
| ChangeLog.pre-2-6 | ||
| ChangeLog.pre-git | ||
| config.h.win32 | ||
| configure.ac | ||
| COPYING | ||
| gimp-zip.in | ||
| gimp.doap | ||
| gimp.pc.in | ||
| gimpthumb.pc.in | ||
| gimpui.pc.in | ||
| HACKING | ||
| INSTALL.in | ||
| LICENSE | ||
| MAINTAINERS | ||
| Makefile.am | ||
| NEWS | ||
| NEWS.pre-2-0 | ||
| NEWS.pre-2-2 | ||
| NEWS.pre-2-4 | ||
| NEWS.pre-2-6 | ||
| NEWS.pre-2-8 | ||
| NEWS.pre-2-10 | ||
| README | ||
| README.i18n | ||
------------------------------
GNU Image Manipulation Program
2.10 Stable Branch
------------------------------
This is a stable release in the GIMP 2.10 series.
GIMP 2.10 replaces earlier GIMP 2.x versions. It is advised that you
uninstall them before installing GIMP 2.10. If you want to keep your
older GIMP 2.x installation in parallel to GIMP 2.10, you have to
choose a separate prefix which is not in your default library search
path. Otherwise your previous GIMP installation will start to use the
new libraries. You have been warned.
If you think you found a bug in this version, please make sure that it
hasn't been reported earlier and that it is not just new stuff that is
still being worked on and obviously not quite finished yet.
If you want to hack on GIMP, please read the file HACKING. For
detailed installation instructions, see the file INSTALL.
1. Web Resources
================
GIMP's home page is at:
https://www.gimp.org/
Please be sure to visit this site for information, documentation,
tutorials, news, etc. All things GIMP-ish are available from there.
The automated plug-in registry is located at:
https://registry.gimp.org/
There you can get the latest versions of plug-ins, using a convenient
forms-based interface.
The latest version of GIMP can be found at:
https://www.gimp.org/downloads/
2. Mailing Lists
================
We have several mailing lists dedicated to GIMP user and development
discussion. There is more info at
https://www.gimp.org/mail_lists.html
Links to several archives of the mailing lists are included in that page.
Gimp-user-list is a mailing list dedicated to user problems, hints and
tips, discussion of cool effects, etc. Gimp-developer-list is oriented
to GIMP core and plug-in developers. Gimp-gui-list is for discussing
about GIMP interface to improve user experience. Most people will only
want to be subscribed to gimp-user-list. If you want to help develop
GIMP, the gimp-developer mailing list is a good starting point; if you
want to help with GUI design, the gimp-gui list is where you want to
subscribe.
3. IRC
======
And finally, for the real junkies, there is an IRC channel devoted to
GIMP. On GIMPNet (a private free software oriented network) there is
#gimp. Many of the developers hang out there. Some of the GIMPNet
servers are:
irc.gimp.org:6667
irc.us.gimp.org:6667
irc.eu.gimp.org:6667
4. Customizing
==============
The look of GIMP's interface can be customized like any other GTK app
by editing the ~/.gtkrc-2.0 file or by using "themes" (ready-made
customizations). For downloadable themes and further details, see
http://art.gnome.org/themes/gtk2 . Additionally, GIMP reads the file
~/.config/GIMP/2.10/gtkrc so you can have settings that only apply to GIMP.
Included is a set of keybindings similar to those in Adobe Photoshop.
You can find them in the ps-menurc file. To use them, copy this file
to ~/.config/GIMP/2.10/menurc. You can also manually change the keybindings
to any of your choice by editing ~/.config/GIMP/2.10/menurc.
Have fun,
Spencer Kimball
Peter Mattis
Federico Mena
Manish Singh
Sven Neumann
Michael Natterer
Dave Neary
Martin Nordholts
Jehan