dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
Gimp/plug-ins/common
History
Jehan 1584a9ba50 plug-ins: fix the thread rendering the thumbnails all the time. 
After testing a bit more, I realized that the thread was constantly re-rendering
the thumbnails, even though I didn't touch the "white-background"
button/argument.
This was not just a completely invisible problem, it actually affected the page
selection (it was very hard to select pages by clicking on them, it was randomly
working, and more often not selecting anything). This is how I realized there
was a problem.

The reason was simply that I was never actually calling g_cond_wait() because of
a first_loop flag I forgot to set.

Note that docs of g_cond_wait() explains that it is possible that "spurious
wakeup" happen. At first I thought I had this issue, which is why this commit
also adds a boolean flag to check after a wakeup, to make sure that I was in the
"condition met" case and not the "spurious wakeup" one.
Even though I realized afterwards the real reason was much more stupid, I still
left this additional check.

Fortunately this issue doesn't seem to affect the 2.10 code. Or to be more
accurate: the continuous render very likely happens there too, yet it doesn't
break page selection interaction with GTK+2 as far as I can see.
2023-04-22 01:29:42 +02:00
..
.gitignore plug-ins: fix generated common plug-in files and file-wbmp localization. 2022-07-07 21:27:39 +02:00
align-layers.c plug-ins: Port align-layers to GimpProcedureConfig 2023-03-16 00:15:14 -04:00
animation-optimize.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
animation-play.c plug-ins: fix freeing NULL object. 2023-01-27 14:18:20 +01:00
blinds.c plug-ins: Restore original preview when disabled 2023-04-09 12:19:24 +00:00
border-average.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
busy-dialog.c plug-ins, libgimp: override set_i18n() for all our core plug-ins. 2022-06-05 01:57:02 +02:00
checkerboard.c plug-ins, libgimp: override set_i18n() for all our core plug-ins. 2022-06-05 01:57:02 +02:00
cml-explorer.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
colormap-remap.c plug-ins: G_APPLICATION_DEFAULT_FLAGS exists since GLib 2.74. 2023-01-29 15:02:11 +01:00
compose.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
contrast-retinex.c plug-ins: Restore original preview when disabled 2023-04-09 12:19:24 +00:00
crop-zealous.c plug-ins: more placeholders removed from menu paths. 2023-04-12 22:07:08 +02:00
curve-bend.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
decompose.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
depth-merge.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
despeckle.c plug-ins: Restore original preview when disabled 2023-04-09 12:19:24 +00:00
destripe.c plug-ins: Update GimpPreview format in despeckle 2023-04-14 02:25:36 +00:00
file-aa.c plug-ins: Port file-aa to GimpSaveProcedureDialog 2023-04-05 02:05:33 +00:00
file-cel.c plug-ins: get rid of various gimp_image_set_file() calls. 2023-02-13 22:54:16 +01:00
file-compressor.c plug-ins, libgimp: override set_i18n() for all our core plug-ins. 2022-06-05 01:57:02 +02:00
file-csource.c plug-ins: Restore mnemonics to file-csource 2023-03-30 04:07:33 +00:00
file-desktop-link.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
file-dicom.c plug-ins: get rid of various gimp_image_set_file() calls. 2023-02-13 22:54:16 +01:00
file-gbr.c plug-ins: Port file-gbr, file-psp to new API. 2023-04-02 12:43:50 +00:00
file-gegl.c plug-ins: get rid of various gimp_image_set_file() calls. 2023-02-13 22:54:16 +01:00
file-gif-load.c plug-ins: more improvements in file-gif-load 2023-03-25 13:37:54 -04:00
file-gif-save.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
file-gih.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
file-glob.c plug-ins: override set_i18n() for file-glob. 2022-06-08 20:59:09 +02:00
file-header.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
file-heif.c plug-ins: Port file-heif to GimpProcedureDialog 2023-03-22 20:05:27 +00:00
file-html-table.c plug-ins: Port file-html-table to... 2023-04-16 16:38:17 +00:00
file-jp2-load.c plug-ins: Port JPEG2000 to GimpProcedureConfig 2023-03-31 14:09:48 +00:00
file-jpegxl.c plug-in: Initial support for CMYK/A JPEGXL export 2022-12-14 21:43:38 +00:00
file-mng.c plug-ins: Port file-mng to GimpSaveProcedureDialog 2023-04-15 23:13:04 +00:00
file-pat.c plug-ins: typo and spacing fixes 2023-03-26 19:20:48 +00:00
file-pcx.c plug-ins: Add option to override PCX 1 bit palette 2023-03-27 15:53:05 +00:00
file-pdf-load.c plug-ins: fix the thread rendering the thumbnails all the time. 2023-04-22 01:29:42 +02:00
file-pdf-save.c plug-ins: Make PDF background color fill optional 2023-02-10 18:35:14 +00:00
file-pix.c plug-ins: get rid of various gimp_image_set_file() calls. 2023-02-13 22:54:16 +01:00
file-png.c plug-ins: get rid of various gimp_image_set_file() calls. 2023-02-13 22:54:16 +01:00
file-pnm.c plug-ins: Port file-pnm to GimpSaveProcedureDialog 2023-04-02 02:55:17 +00:00
file-ps.c plug-ins: get rid of various gimp_image_set_file() calls. 2023-02-13 22:54:16 +01:00
file-psp.c plug-ins: Port file-gbr, file-psp to new API. 2023-04-02 12:43:50 +00:00
file-qoi.c plug-ins: Add import/export support for QOI file 2023-03-30 18:41:56 +00:00
file-raw-data.c plug-ins: get rid of various gimp_image_set_file() calls. 2023-02-13 22:54:16 +01:00
file-sunras.c plug-ins: Port file-sunras widgets to use... 2023-03-21 18:54:15 +00:00
file-svg.c plug-ins: get rid of various gimp_image_set_file() calls. 2023-02-13 22:54:16 +01:00
file-tga.c plug-ins: Port file-tga widgets to use... 2023-03-23 02:45:55 +00:00
file-wbmp.c plug-ins: get rid of various gimp_image_set_file() calls. 2023-02-13 22:54:16 +01:00
file-wmf.c plug-ins: get rid of various gimp_image_set_file() calls. 2023-02-13 22:54:16 +01:00
file-xbm.c plug-ins: Port file-xbm to GimpSaveProcedureDialog 2023-04-19 12:32:06 +00:00
file-xmc.c plug-ins: get rid of various gimp_image_set_file() calls. 2023-02-13 22:54:16 +01:00
file-xpm.c plug-ins: Port file-xpm widget to use... 2023-03-26 02:19:07 +00:00
file-xwd.c plug-ins: get rid of various gimp_image_set_file() calls. 2023-02-13 22:54:16 +01:00
film.c Fix plugins to use new GimpResource. 2023-01-14 17:43:26 +01:00
gimprc.common plug-ins: fix generated common plug-in files and file-wbmp localization. 2022-07-07 21:27:39 +02:00
gradient-map.c Fix plugins to use new GimpResource. 2023-01-14 17:43:26 +01:00
grid.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
guillotine.c plug-ins: more placeholders removed from menu paths. 2023-04-12 22:07:08 +02:00
hot.c plug-ins: more placeholders removed from menu paths. 2023-04-12 22:07:08 +02:00
jigsaw.c plug-ins: Restore original preview when disabled 2023-04-09 12:19:24 +00:00
mail.c plug-ins: don't use "Send" placeholder either. 2023-04-12 22:07:08 +02:00
Makefile.am plug-ins: metadata import/export for JPEG XL format 2022-10-05 14:15:26 +00:00
meson.build plug-ins: fix QOI meson script 2023-03-31 14:15:57 +02:00
mkgen.pl plug-ins: remove deprecated API support from common/mkgen.pl 2019-09-03 13:25:25 +02:00
nl-filter.c plug-ins: Restore original preview when disabled 2023-04-09 12:19:24 +00:00
plugin-browser.c plug-ins: more placeholders removed from menu paths. 2023-04-12 22:07:08 +02:00
plugin-defs.pl plug-ins: metadata import/export for JPEG XL format 2022-10-05 14:15:26 +00:00
procedure-browser.c plug-ins: more placeholders removed from menu paths. 2023-04-12 22:07:08 +02:00
qbist.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
sample-colorize.c Fix plugins to use new GimpResource. 2023-01-14 17:43:26 +01:00
smooth-palette.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
sparkle.c plug-ins: fix typos in sparkle 2023-04-14 10:54:05 +00:00
sphere-designer.c plug-ins: Make sure we initalize GimpVector4 2022-07-08 09:50:25 +02:00
tile-small.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
tile.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
unit-editor.c plug-ins: more placeholders removed from menu paths. 2023-04-12 22:07:08 +02:00
van-gogh-lic.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
warp.c plug-ins: label and documentation of plug-ins localized plug-in side. 2022-07-05 12:23:51 +02:00
wavelet-decompose.c plug-ins: Port wavelet decompose in to... 2023-03-20 11:50:25 +00:00
web-browser.c plug-ins, libgimp: override set_i18n() for all our core plug-ins. 2022-06-05 01:57:02 +02:00
web-page.c plug-ins: remove the "Acquire" of the menu path. 2023-04-12 22:07:08 +02:00