dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
Gimp/libgimpconfig/gimpcolorconfig.c
Michael Natterer 77dac3ea60 Bug 555562 - GIMP should ask before applying working space profile 
Get rid of the "configurable RGB working space profile".

Instead, turn GimpColorConfig's "rgb-profile" property into a
"Preferred RGB profile" thing that is only a hint and never used
without explicit user interaction. Present it next to the built-in
profile in the profile combo boxes and call it "Preferred" in the
prefs dialog and its tooltip.

Most importantly, don't use it as the image's profile when the image
is not tagged with a profile. Untagged images are now always in the
sRGB or linear RGB built-in color spaces.

This commit reduces the "Apply color profile" dialog on file import to
a simple "Convert to built-in RGB", but that dialog is about to be
moved to the core and improved anyway.
2015-08-20 16:02:22 +02:00

638 lines
21 KiB
C
Raw Blame History

/* LIBGIMP - The GIMP Library
* Copyright (C) 1995 Spencer Kimball and Peter Mattis
*
* GimpColorConfig class
* Copyright (C) 2004 Stefan Döhla <stefan@doehla.de>
*
* This library is free software: you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Library General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not, see
* <http://www.gnu.org/licenses/>.
*/
#include "config.h"
#include <cairo.h>
#include <gegl.h>
#include <gdk-pixbuf/gdk-pixbuf.h>
#include "libgimpbase/gimpbase.h"
#include "libgimpcolor/gimpcolor.h"
#include "gimpconfigtypes.h"
#include "gimpcolorconfig-enums.h"
#include "gimpcolorconfig.h"
#include "gimpconfig-error.h"
#include "gimpconfig-iface.h"
#include "gimpconfig-params.h"
#include "gimpconfig-path.h"
#include "libgimp/libgimp-intl.h"
/**
* SECTION: gimpcolorconfig
* @title: GimpColorConfig
* @short_description: Color management settings.
*
* Color management settings.
**/
#define COLOR_MANAGEMENT_MODE_BLURB \
_("Mode of operation for color management.")
#define DISPLAY_PROFILE_BLURB \
_("The color profile of your (primary) monitor.")
#define DISPLAY_PROFILE_FROM_GDK_BLURB \
_("When enabled, GIMP will try to use the display color profile from " \
"the windowing system. The configured monitor profile is then only " \
"used as a fallback.")
#define RGB_PROFILE_BLURB \
_("The preferred RGB working space color profile. It will be offered " \
"next to the built-in RGB profile when a color profile can be chosen.")
#define CMYK_PROFILE_BLURB \
_("The CMYK color profile used to convert between RGB and CMYK.")
#define PRINTER_PROFILE_BLURB \
_("The color profile to use for soft proofing from your image's " \
"color space to some other color space, including " \
"soft proofing to a printer or other output device profile. ")
#define DISPLAY_RENDERING_INTENT_BLURB \
_("How colors are converted from your image's color space to your " \
"display device. Relative colorimetric is usually the best choice. " \
"Unless you use a LUT monitor profile (most monitor profiles are " \
"matrix), choosing perceptual intent really gives you relative " \
"colorimetric." )
#define DISPLAY_USE_BPC_BLURB \
_("Do use black point compensation (unless you know you have a reason " \
"not to). ")
#define SIMULATION_RENDERING_INTENT_BLURB \
_("How colors are converted from your image's color space to the " \
"output simulation device (usually your monitor). " \
"Try them all and choose what looks the best. ")
#define SIMULATION_USE_BPC_BLURB \
_("Try with and without black point compensation "\
"and choose what looks best. ")
#define SIMULATION_GAMUT_CHECK_BLURB \
_("When enabled, the print simulation will mark colors " \
"which can not be represented in the target color space.")
#define OUT_OF_GAMUT_COLOR_BLURB \
_("The color to use for marking colors which are out of gamut.")
enum
{
PROP_0,
PROP_MODE,
PROP_RGB_PROFILE,
PROP_CMYK_PROFILE,
PROP_DISPLAY_PROFILE,
PROP_DISPLAY_PROFILE_FROM_GDK,
PROP_PRINTER_PROFILE,
PROP_DISPLAY_RENDERING_INTENT,
PROP_DISPLAY_USE_BPC,
PROP_SIMULATION_RENDERING_INTENT,
PROP_SIMULATION_USE_BPC,
PROP_SIMULATION_GAMUT_CHECK,
PROP_OUT_OF_GAMUT_COLOR,
PROP_DISPLAY_MODULE
};
static void gimp_color_config_finalize (GObject *object);
static void gimp_color_config_set_property (GObject *object,
guint property_id,
const GValue *value,
GParamSpec *pspec);
static void gimp_color_config_get_property (GObject *object,
guint property_id,
GValue *value,
GParamSpec *pspec);
static void gimp_color_config_set_rgb_profile (GimpColorConfig *config,
const gchar *filename,
GError **error);
static void gimp_color_config_set_cmyk_profile (GimpColorConfig *config,
const gchar *filename,
GError **error);
static void gimp_color_config_set_display_profile (GimpColorConfig *config,
const gchar *filename,
GError **error);
static void gimp_color_config_set_printer_profile (GimpColorConfig *config,
const gchar *filename,
GError **error);
G_DEFINE_TYPE_WITH_CODE (GimpColorConfig, gimp_color_config, G_TYPE_OBJECT,
G_IMPLEMENT_INTERFACE (GIMP_TYPE_CONFIG, NULL)
gimp_type_set_translation_domain (g_define_type_id,
GETTEXT_PACKAGE "-libgimp"))
#define parent_class gimp_color_config_parent_class
static void
gimp_color_config_class_init (GimpColorConfigClass *klass)
{
GObjectClass *object_class = G_OBJECT_CLASS (klass);
GimpRGB color;
gimp_rgba_set_uchar (&color, 0x80, 0x80, 0x80, 0xff);
object_class->finalize = gimp_color_config_finalize;
object_class->set_property = gimp_color_config_set_property;
object_class->get_property = gimp_color_config_get_property;
GIMP_CONFIG_INSTALL_PROP_ENUM (object_class, PROP_MODE,
"mode", COLOR_MANAGEMENT_MODE_BLURB,
GIMP_TYPE_COLOR_MANAGEMENT_MODE,
GIMP_COLOR_MANAGEMENT_DISPLAY,
GIMP_PARAM_STATIC_STRINGS);
GIMP_CONFIG_INSTALL_PROP_PATH (object_class, PROP_RGB_PROFILE,
"rgb-profile", RGB_PROFILE_BLURB,
GIMP_CONFIG_PATH_FILE, NULL,
GIMP_PARAM_STATIC_STRINGS);
GIMP_CONFIG_INSTALL_PROP_PATH (object_class, PROP_CMYK_PROFILE,
"cmyk-profile", CMYK_PROFILE_BLURB,
GIMP_CONFIG_PATH_FILE, NULL,
GIMP_PARAM_STATIC_STRINGS);
GIMP_CONFIG_INSTALL_PROP_PATH (object_class, PROP_DISPLAY_PROFILE,
"display-profile", DISPLAY_PROFILE_BLURB,
GIMP_CONFIG_PATH_FILE, NULL,
GIMP_PARAM_STATIC_STRINGS);
GIMP_CONFIG_INSTALL_PROP_BOOLEAN (object_class, PROP_DISPLAY_PROFILE_FROM_GDK,
"display-profile-from-gdk",
DISPLAY_PROFILE_FROM_GDK_BLURB,
FALSE,
GIMP_PARAM_STATIC_STRINGS);
GIMP_CONFIG_INSTALL_PROP_PATH (object_class, PROP_PRINTER_PROFILE,
"printer-profile", PRINTER_PROFILE_BLURB,
GIMP_CONFIG_PATH_FILE, NULL,
GIMP_PARAM_STATIC_STRINGS);
GIMP_CONFIG_INSTALL_PROP_ENUM (object_class, PROP_DISPLAY_RENDERING_INTENT,
"display-rendering-intent",
DISPLAY_RENDERING_INTENT_BLURB,
GIMP_TYPE_COLOR_RENDERING_INTENT,
GIMP_COLOR_RENDERING_INTENT_RELATIVE_COLORIMETRIC,
GIMP_PARAM_STATIC_STRINGS);
GIMP_CONFIG_INSTALL_PROP_BOOLEAN (object_class, PROP_DISPLAY_USE_BPC,
"display-use-black-point-compensation",
DISPLAY_USE_BPC_BLURB,
TRUE,
GIMP_PARAM_STATIC_STRINGS);
GIMP_CONFIG_INSTALL_PROP_ENUM (object_class, PROP_SIMULATION_RENDERING_INTENT,
"simulation-rendering-intent",
SIMULATION_RENDERING_INTENT_BLURB,
GIMP_TYPE_COLOR_RENDERING_INTENT,
GIMP_COLOR_RENDERING_INTENT_PERCEPTUAL,
GIMP_PARAM_STATIC_STRINGS);
GIMP_CONFIG_INSTALL_PROP_BOOLEAN (object_class, PROP_SIMULATION_USE_BPC,
"simulation-use-black-point-compensation",
SIMULATION_USE_BPC_BLURB,
FALSE,
GIMP_PARAM_STATIC_STRINGS);
GIMP_CONFIG_INSTALL_PROP_BOOLEAN (object_class, PROP_SIMULATION_GAMUT_CHECK,
"simulation-gamut-check",
SIMULATION_GAMUT_CHECK_BLURB,
FALSE,
GIMP_PARAM_STATIC_STRINGS);
GIMP_CONFIG_INSTALL_PROP_RGB (object_class, PROP_OUT_OF_GAMUT_COLOR,
"out-of-gamut-color",
OUT_OF_GAMUT_COLOR_BLURB,
FALSE, &color,
GIMP_PARAM_STATIC_STRINGS);
GIMP_CONFIG_INSTALL_PROP_STRING (object_class, PROP_DISPLAY_MODULE,
"display-module", NULL,
"CdisplayLcms",
GIMP_PARAM_STATIC_STRINGS);
}
static void
gimp_color_config_init (GimpColorConfig *config)
{
}
static void
gimp_color_config_finalize (GObject *object)
{
GimpColorConfig *color_config = GIMP_COLOR_CONFIG (object);
if (color_config->rgb_profile)
g_free (color_config->rgb_profile);
if (color_config->cmyk_profile)
g_free (color_config->cmyk_profile);
if (color_config->display_profile)
g_free (color_config->display_profile);
if (color_config->printer_profile)
g_free (color_config->printer_profile);
if (color_config->display_module)
g_free (color_config->display_module);
G_OBJECT_CLASS (parent_class)->finalize (object);
}
static void
gimp_color_config_set_property (GObject *object,
guint property_id,
const GValue *value,
GParamSpec *pspec)
{
GimpColorConfig *color_config = GIMP_COLOR_CONFIG (object);
GError *error = NULL;
switch (property_id)
{
case PROP_MODE:
color_config->mode = g_value_get_enum (value);
break;
case PROP_RGB_PROFILE:
gimp_color_config_set_rgb_profile (color_config,
g_value_get_string (value),
&error);
break;
case PROP_CMYK_PROFILE:
gimp_color_config_set_cmyk_profile (color_config,
g_value_get_string (value),
&error);
break;
case PROP_DISPLAY_PROFILE:
gimp_color_config_set_display_profile (color_config,
g_value_get_string (value),
&error);
break;
case PROP_DISPLAY_PROFILE_FROM_GDK:
color_config->display_profile_from_gdk = g_value_get_boolean (value);
break;
case PROP_PRINTER_PROFILE:
gimp_color_config_set_printer_profile (color_config,
g_value_get_string (value),
&error);
break;
case PROP_DISPLAY_RENDERING_INTENT:
color_config->display_intent = g_value_get_enum (value);
break;
case PROP_DISPLAY_USE_BPC:
color_config->display_use_black_point_compensation = g_value_get_boolean (value);
break;
case PROP_SIMULATION_RENDERING_INTENT:
color_config->simulation_intent = g_value_get_enum (value);
break;
case PROP_SIMULATION_USE_BPC:
color_config->simulation_use_black_point_compensation = g_value_get_boolean (value);
break;
case PROP_SIMULATION_GAMUT_CHECK:
color_config->simulation_gamut_check = g_value_get_boolean (value);
break;
case PROP_OUT_OF_GAMUT_COLOR:
color_config->out_of_gamut_color = *(GimpRGB *) g_value_get_boxed (value);
break;
case PROP_DISPLAY_MODULE:
g_free (color_config->display_module);
color_config->display_module = g_value_dup_string (value);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
break;
}
if (error)
{
g_message ("%s", error->message);
g_clear_error (&error);
}
}
static void
gimp_color_config_get_property (GObject *object,
guint property_id,
GValue *value,
GParamSpec *pspec)
{
GimpColorConfig *color_config = GIMP_COLOR_CONFIG (object);
switch (property_id)
{
case PROP_MODE:
g_value_set_enum (value, color_config->mode);
break;
case PROP_RGB_PROFILE:
g_value_set_string (value, color_config->rgb_profile);
break;
case PROP_CMYK_PROFILE:
g_value_set_string (value, color_config->cmyk_profile);
break;
case PROP_DISPLAY_PROFILE:
g_value_set_string (value, color_config->display_profile);
break;
case PROP_DISPLAY_PROFILE_FROM_GDK:
g_value_set_boolean (value, color_config->display_profile_from_gdk);
break;
case PROP_PRINTER_PROFILE:
g_value_set_string (value, color_config->printer_profile);
break;
case PROP_DISPLAY_RENDERING_INTENT:
g_value_set_enum (value, color_config->display_intent);
break;
case PROP_DISPLAY_USE_BPC:
g_value_set_boolean (value, color_config->display_use_black_point_compensation);
break;
case PROP_SIMULATION_RENDERING_INTENT:
g_value_set_enum (value, color_config->simulation_intent);
break;
case PROP_SIMULATION_USE_BPC:
g_value_set_boolean (value, color_config->simulation_use_black_point_compensation);
break;
case PROP_SIMULATION_GAMUT_CHECK:
g_value_set_boolean (value, color_config->simulation_gamut_check);
break;
case PROP_OUT_OF_GAMUT_COLOR:
g_value_set_boxed (value, &color_config->out_of_gamut_color);
break;
case PROP_DISPLAY_MODULE:
g_value_set_string (value, color_config->display_module);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
break;
}
}
GimpColorProfile *
gimp_color_config_get_rgb_color_profile (GimpColorConfig *config,
GError **error)
{
GimpColorProfile *profile = NULL;
g_return_val_if_fail (GIMP_IS_COLOR_CONFIG (config), NULL);
g_return_val_if_fail (error == NULL || *error == NULL, NULL);
if (config->rgb_profile)
{
GFile *file = g_file_new_for_path (config->rgb_profile);
profile = gimp_color_profile_new_from_file (file, error);
if (profile && ! gimp_color_profile_is_rgb (profile))
{
g_object_unref (profile);
profile = NULL;
g_set_error (error, GIMP_CONFIG_ERROR, 0,
_("Color profile '%s' is not for RGB color space."),
gimp_file_get_utf8_name (file));
}
g_object_unref (file);
}
return profile;
}
GimpColorProfile *
gimp_color_config_get_cmyk_color_profile (GimpColorConfig *config,
GError **error)
{
GimpColorProfile *profile = NULL;
g_return_val_if_fail (GIMP_IS_COLOR_CONFIG (config), NULL);
g_return_val_if_fail (error == NULL || *error == NULL, NULL);
if (config->cmyk_profile)
{
GFile *file = g_file_new_for_path (config->cmyk_profile);
profile = gimp_color_profile_new_from_file (file, error);
if (profile && ! gimp_color_profile_is_cmyk (profile))
{
g_object_unref (profile);
profile = NULL;
g_set_error (error, GIMP_CONFIG_ERROR, 0,
_("Color profile '%s' is not for CMYK color space."),
gimp_file_get_utf8_name (file));
}
g_object_unref (file);
}
return profile;
}
GimpColorProfile *
gimp_color_config_get_display_color_profile (GimpColorConfig *config,
GError **error)
{
GimpColorProfile *profile = NULL;
g_return_val_if_fail (GIMP_IS_COLOR_CONFIG (config), NULL);
g_return_val_if_fail (error == NULL || *error == NULL, NULL);
if (config->display_profile)
{
GFile *file = g_file_new_for_path (config->display_profile);
profile = gimp_color_profile_new_from_file (file, error);
g_object_unref (file);
}
return profile;
}
GimpColorProfile *
gimp_color_config_get_printer_color_profile (GimpColorConfig *config,
GError **error)
{
GimpColorProfile *profile = NULL;
g_return_val_if_fail (GIMP_IS_COLOR_CONFIG (config), NULL);
g_return_val_if_fail (error == NULL || *error == NULL, NULL);
if (config->printer_profile)
{
GFile *file = g_file_new_for_path (config->printer_profile);
profile = gimp_color_profile_new_from_file (file, error);
g_object_unref (file);
}
return profile;
}
/* private functions */
static void
gimp_color_config_set_rgb_profile (GimpColorConfig *config,
const gchar *filename,
GError **error)
{
gboolean success = TRUE;
if (filename)
{
GimpColorProfile *profile;
GFile *file = g_file_new_for_path (filename);
profile = gimp_color_profile_new_from_file (file, error);
if (profile)
{
if (! gimp_color_profile_is_rgb (profile))
{
g_set_error (error, GIMP_CONFIG_ERROR, 0,
_("Color profile '%s' is not for RGB color space."),
gimp_file_get_utf8_name (file));
success = FALSE;
}
g_object_unref (profile);
}
else
{
success = FALSE;
}
g_object_unref (file);
}
if (success)
{
g_free (config->rgb_profile);
config->rgb_profile = g_strdup (filename);
}
}
static void
gimp_color_config_set_cmyk_profile (GimpColorConfig *config,
const gchar *filename,
GError **error)
{
gboolean success = TRUE;
if (filename)
{
GimpColorProfile *profile;
GFile *file = g_file_new_for_path (filename);
profile = gimp_color_profile_new_from_file (file, error);
if (profile)
{
if (! gimp_color_profile_is_cmyk (profile))
{
g_set_error (error, GIMP_CONFIG_ERROR, 0,
_("Color profile '%s' is not for CMYK color space."),
gimp_file_get_utf8_name (file));
success = FALSE;
}
g_object_unref (profile);
}
else
{
success = FALSE;
}
g_object_unref (file);
}
if (success)
{
g_free (config->cmyk_profile);
config->cmyk_profile = g_strdup (filename);
}
}
static void
gimp_color_config_set_display_profile (GimpColorConfig *config,
const gchar *filename,
GError **error)
{
gboolean success = TRUE;
if (filename)
{
GimpColorProfile *profile;
GFile *file = g_file_new_for_path (filename);
profile = gimp_color_profile_new_from_file (file, error);
if (profile)
{
g_object_unref (profile);
}
else
{
success = FALSE;
}
g_object_unref (file);
}
if (success)
{
g_free (config->display_profile);
config->display_profile = g_strdup (filename);
}
}
static void
gimp_color_config_set_printer_profile (GimpColorConfig *config,
const gchar *filename,
GError **error)
{
gboolean success = TRUE;
if (filename)
{
GimpColorProfile *profile;
GFile *file = g_file_new_for_path (filename);
profile = gimp_color_profile_new_from_file (file, error);
if (profile)
{
g_object_unref (profile);
}
else
{
success = FALSE;
}
g_object_unref (file);
}
if (success)
{
g_free (config->printer_profile);
config->printer_profile = g_strdup (filename);
}
}
Reference in a new issue View git blame Copy permalink