4ee3a9caa1
There are 2 parts for this fix: - First expect the GimpPdbDialog to possibly disappear while gimp_pdb_dialog_run_callback() is running. This can indeed happen as this core dialog is tied to a PDB call. If the calling processus crashes (which may happen, and has to be expected for third-party plug-ins), then this dialog may just end up closing at anytime (signal "plug-in-closed" from the plug-in manager which implies a GTK_RESPONSE_CLOSE, hence dialog destruction). To account for this, we check the dialog availability with a weak pointer and returns the info to the caller as well. - Don't connect to "value-changed" on the spacing adjustment because when a crash happened, I had cases when the adjustment was finalized while being set (crash in GTK code). This one is a bit harder to explain (I had to look long at backtraces) but having a proper signal "spacing-changed" on the GimpBrushFactoryView is actually much cleaner code than relying on a public object anyway and it fixes this crash. Note: this fix is related to my previous commit. When running gimp_brush_select_new() from Python code, the plug-in crashed when trying to run the callback, which also resulted into core crash (and this part is obviously not acceptable at all).
69 lines
2.8 KiB
C
69 lines
2.8 KiB
C
/* GIMP - The GNU Image Manipulation Program
|
|
* Copyright (C) 1995 Spencer Kimball and Peter Mattis
|
|
*
|
|
* gimpbrushfactoryview.h
|
|
* Copyright (C) 2001 Michael Natterer <mitch@gimp.org>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef __GIMP_BRUSH_FACTORY_VIEW_H__
|
|
#define __GIMP_BRUSH_FACTORY_VIEW_H__
|
|
|
|
#include "gimpdatafactoryview.h"
|
|
|
|
|
|
#define GIMP_TYPE_BRUSH_FACTORY_VIEW (gimp_brush_factory_view_get_type ())
|
|
#define GIMP_BRUSH_FACTORY_VIEW(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), GIMP_TYPE_BRUSH_FACTORY_VIEW, GimpBrushFactoryView))
|
|
#define GIMP_BRUSH_FACTORY_VIEW_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST ((klass), GIMP_TYPE_BRUSH_FACTORY_VIEW, GimpBrushFactoryViewClass))
|
|
#define GIMP_IS_BRUSH_FACTORY_VIEW(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), GIMP_TYPE_BRUSH_FACTORY_VIEW))
|
|
#define GIMP_IS_BRUSH_FACTORY_VIEW_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE ((klass), GIMP_TYPE_BRUSH_FACTORY_VIEW))
|
|
#define GIMP_BRUSH_FACTORY_VIEW_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS ((obj), GIMP_TYPE_BRUSH_FACTORY_VIEW, GimpBrushFactoryViewClass))
|
|
|
|
|
|
typedef struct _GimpBrushFactoryViewClass GimpBrushFactoryViewClass;
|
|
|
|
struct _GimpBrushFactoryView
|
|
{
|
|
GimpDataFactoryView parent_instance;
|
|
|
|
GtkWidget *spacing_scale;
|
|
GtkAdjustment *spacing_adjustment;
|
|
|
|
gboolean change_brush_spacing;
|
|
GQuark spacing_changed_handler_id;
|
|
};
|
|
|
|
struct _GimpBrushFactoryViewClass
|
|
{
|
|
GimpDataFactoryViewClass parent_class;
|
|
|
|
/* Signals */
|
|
|
|
void (* spacing_changed) (GimpBrushFactoryView *view);
|
|
};
|
|
|
|
|
|
GType gimp_brush_factory_view_get_type (void) G_GNUC_CONST;
|
|
|
|
GtkWidget * gimp_brush_factory_view_new (GimpViewType view_type,
|
|
GimpDataFactory *factory,
|
|
GimpContext *context,
|
|
gboolean change_brush_spacing,
|
|
gint view_size,
|
|
gint view_border_width,
|
|
GimpMenuFactory *menu_factory);
|
|
|
|
|
|
#endif /* __GIMP_BRUSH_FACTORY_VIEW_H__ */
|