0f65d3923e
This is the result of a UX session with Aryeom. Just showing a message forbidding editing of non-rasterized text/link/vector layers is problematic, because it doesn't help people understand how to unblock their situation (if they really want to just edit directly the layer). Additionally we are now blinking the layer. A possible alternative could have been to pop a dialog up, with the same message but also with a quick-action button to allow rasterize in a click (similar to how we are popping a dialog up to revert the rasterization when clicking on a text layer with the text tool or a vector layer with the path tool). The problem is that even though the need to edit directly a non-raster layer arises from time to time, most of the time, when you use such layers, you don't intend to edit these (unlike editing text/path with matching tools, you more often wanted to edit the relevant data). Therefore it is more often than not just a mistake when you try to paint directly on such a layer. I.e. that very often, you were intending to paint on another layer, or add a new layer above your non-raster layer. Therefore a dialog popping up every time you made such a mistake would be annoying and workflow-breaking. A simple error message and some blinking leave for a fluid process.
126 lines
3.6 KiB
C
126 lines
3.6 KiB
C
/* GIMP - The GNU Image Manipulation Program
|
|
* Copyright (C) 1995-2001 Spencer Kimball, Peter Mattis and others
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <gegl.h>
|
|
#include <gtk/gtk.h>
|
|
|
|
#include "libgimpwidgets/gimpwidgets.h"
|
|
|
|
#include "tools-types.h"
|
|
|
|
#include "core/gimp.h"
|
|
#include "core/gimpchannel.h"
|
|
#include "core/gimplayer.h"
|
|
|
|
#include "path/gimppath.h"
|
|
|
|
#include "widgets/gimpcontainerview.h"
|
|
#include "widgets/gimpdialogfactory.h"
|
|
#include "widgets/gimpitemtreeview.h"
|
|
#include "widgets/gimpwidgets-utils.h"
|
|
#include "widgets/gimpwindowstrategy.h"
|
|
|
|
#include "gimptools-utils.h"
|
|
|
|
|
|
static GimpItemTreeView * gimp_tools_get_tree_view_for (Gimp *gimp,
|
|
GimpItem *item);
|
|
|
|
|
|
/* public functions */
|
|
|
|
void
|
|
gimp_tools_blink_lock_box (Gimp *gimp,
|
|
GimpItem *item)
|
|
{
|
|
GimpItemTreeView *view;
|
|
|
|
g_return_if_fail (GIMP_IS_GIMP (gimp));
|
|
g_return_if_fail (GIMP_IS_ITEM (item));
|
|
|
|
view = gimp_tools_get_tree_view_for (gimp, item);
|
|
gimp_item_tree_view_blink_lock (view, item);
|
|
}
|
|
|
|
void
|
|
gimp_tools_blink_item (Gimp *gimp,
|
|
GimpItem *item)
|
|
{
|
|
GimpItemTreeView *view;
|
|
|
|
g_return_if_fail (GIMP_IS_GIMP (gimp));
|
|
g_return_if_fail (GIMP_IS_ITEM (item));
|
|
|
|
view = gimp_tools_get_tree_view_for (gimp, item);
|
|
gimp_item_tree_view_blink_item (view, item);
|
|
}
|
|
|
|
void
|
|
gimp_tools_show_tool_options (Gimp *gimp)
|
|
{
|
|
GdkMonitor *monitor;
|
|
|
|
g_return_if_fail (GIMP_IS_GIMP (gimp));
|
|
|
|
monitor = gimp_get_monitor_at_pointer ();
|
|
|
|
gimp_window_strategy_show_dockable_dialog (GIMP_WINDOW_STRATEGY (gimp_get_window_strategy (gimp)),
|
|
gimp,
|
|
gimp_dialog_factory_get_singleton (),
|
|
monitor, "gimp-tool-options");
|
|
}
|
|
|
|
|
|
/* Private functions */
|
|
|
|
static GimpItemTreeView *
|
|
gimp_tools_get_tree_view_for (Gimp *gimp,
|
|
GimpItem *item)
|
|
{
|
|
GtkWidget *dockable;
|
|
GimpItemTreeView *view;
|
|
GdkMonitor *monitor;
|
|
const gchar *identifier;
|
|
|
|
g_return_val_if_fail (GIMP_IS_GIMP (gimp), NULL);
|
|
g_return_val_if_fail (GIMP_IS_ITEM (item), NULL);
|
|
|
|
if (GIMP_IS_LAYER (item))
|
|
identifier = "gimp-layer-list";
|
|
else if (GIMP_IS_CHANNEL (item))
|
|
identifier = "gimp-channel-list";
|
|
else if (GIMP_IS_PATH (item))
|
|
identifier = "gimp-path-list";
|
|
else
|
|
g_return_val_if_reached (NULL);
|
|
|
|
monitor = gimp_get_monitor_at_pointer ();
|
|
dockable = gimp_window_strategy_show_dockable_dialog (GIMP_WINDOW_STRATEGY (gimp_get_window_strategy (gimp)),
|
|
gimp,
|
|
gimp_dialog_factory_get_singleton (),
|
|
monitor,
|
|
identifier);
|
|
|
|
if (! dockable)
|
|
return NULL;
|
|
|
|
view = GIMP_ITEM_TREE_VIEW (gtk_bin_get_child (GTK_BIN (dockable)));
|
|
|
|
return view;
|
|
}
|