87810ae6fe
This commit doesn't actually changes anything, but it fixes the gimp_histogram_new() call, since the argument is supposed to be a GimpTRCType, not a boolean. Yet GIMP_TRC_LINEAR is the first value in the enum type, so it's indeed the same as FALSE. I also set the "trc" property to "gimp:levels" config object explicitly, to the same TRC value as the histogram, so that this doesn't depend on the default anymore (which is linear too, right now; so this part doesn't change a thing here again), and therefore would survive to any possible default change in the future. Note that it was considered to set this all to non-linear, just as it used to be in 2.10, as requested in #15738. After discussing it with Øyvind on IRC, we concluded that working in linear space may be a nicer default for this feature, as we'd be doing a "meaningful rebalancing of photon count per component". Now there may be cases where doing a white-balancing in non-linear may yield better result, of course. For these case, you may still go to "Levels", set to non-linear, and hit "Auto Input Levels". This is exactly the same code runing (but in non-linear space). The "White Balance" action still needs to be the simple non-GUI option and keeping work in linear seems like the more appropriate default here.
78 lines
2.3 KiB
C
78 lines
2.3 KiB
C
/* GIMP - The GNU Image Manipulation Program
|
|
* Copyright (C) 1995 Spencer Kimball and Peter Mattis
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <gdk-pixbuf/gdk-pixbuf.h>
|
|
#include <gegl.h>
|
|
|
|
#include "core-types.h"
|
|
|
|
#include "operations/gimplevelsconfig.h"
|
|
|
|
#include "gimpdrawable.h"
|
|
#include "gimpdrawable-histogram.h"
|
|
#include "gimpdrawable-levels.h"
|
|
#include "gimpdrawable-operation.h"
|
|
#include "gimphistogram.h"
|
|
#include "gimpprogress.h"
|
|
|
|
#include "gimp-intl.h"
|
|
|
|
|
|
/* public functions */
|
|
|
|
void
|
|
gimp_drawable_levels_stretch (GimpDrawable *drawable,
|
|
GimpProgress *progress)
|
|
{
|
|
GimpLevelsConfig *config;
|
|
GimpHistogram *histogram;
|
|
GeglNode *levels;
|
|
GimpTRCType trc = GIMP_TRC_LINEAR;
|
|
|
|
g_return_if_fail (GIMP_IS_DRAWABLE (drawable));
|
|
g_return_if_fail (gimp_item_is_attached (GIMP_ITEM (drawable)));
|
|
g_return_if_fail (progress == NULL || GIMP_IS_PROGRESS (progress));
|
|
|
|
if (! gimp_item_mask_intersect (GIMP_ITEM (drawable), NULL, NULL, NULL, NULL))
|
|
return;
|
|
|
|
config = g_object_new (GIMP_TYPE_LEVELS_CONFIG, "trc", trc, NULL);
|
|
|
|
histogram = gimp_histogram_new (trc);
|
|
gimp_drawable_calculate_histogram (drawable, histogram, FALSE);
|
|
|
|
gimp_levels_config_stretch (config, histogram,
|
|
gimp_drawable_is_rgb (drawable));
|
|
|
|
g_object_unref (histogram);
|
|
|
|
levels = g_object_new (GEGL_TYPE_NODE,
|
|
"operation", "gimp:levels",
|
|
NULL);
|
|
|
|
gegl_node_set (levels,
|
|
"config", config,
|
|
NULL);
|
|
|
|
gimp_drawable_apply_operation (drawable, progress, _("Levels"),
|
|
levels);
|
|
|
|
g_object_unref (levels);
|
|
g_object_unref (config);
|
|
}
|