bf6fcac0a9
This was happening when trying to load a file before fonts were fully loaded, which may happen when loading while starting GIMP (either from CLI, or from a file browser, etc.), or simply just after start for people with a lot of fonts, whose font loading may take a long time as background task. Note that I didn't manage to reproduce properly because from reports, it seems like the problem appears where some fonts may be only partly loaded so gimp_font_get_hash() fails to load the font and get a hash. I never managed to trigger such a case and no reporters answered my call for testing of debug builds. As a consequence, I'll just assume that simply waiting for all fonts to be loaded before starting to load images would work out. Note that the crash was not happening when text layers were using the older syntax (pre-XCF 19) of text layer data, since it was not storing any font hash, which means that we were not trying to compare hashes. It would also not crash if fonts were not fully loaded yet, but we didn't have any weird intermediate state where fonts appeared in the list yet their file were not hashable (cf. what I failed to reproduce, as explained in previous paragraph). But both these cases were not ideal either anyway because then we could load the XCF apparently OK… except that the correct fonts would not be associated to the related text layers (hence as soon as you start to edit said texts, the rendering would break). So we should wait for fonts to be loaded, and that was a bug even when you can't reproduce the crash. When starting GIMP without loading an image, or simply when fonts are loaded quickly enough, it won't make any difference. So it should not make startup any slower for most common use cases and installations.
161 lines
8.8 KiB
C
161 lines
8.8 KiB
C
/* GIMP - The GNU Image Manipulation Program
|
|
* Copyright (C) 1995 Spencer Kimball and Peter Mattis
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
|
|
#ifdef GIMP_RELEASE
|
|
#define GIMP_TIMER_START()
|
|
#define GIMP_TIMER_END(message)
|
|
#else
|
|
#define GIMP_TIMER_START() \
|
|
{ GTimer *_timer = g_timer_new ();
|
|
|
|
#define GIMP_TIMER_END(message) \
|
|
g_printerr ("%s: %s took %0.4f seconds\n", \
|
|
G_STRFUNC, message, g_timer_elapsed (_timer, NULL)); \
|
|
g_timer_destroy (_timer); }
|
|
#endif
|
|
|
|
|
|
#define MIN4(a,b,c,d) MIN (MIN ((a), (b)), MIN ((c), (d)))
|
|
#define MAX4(a,b,c,d) MAX (MAX ((a), (b)), MAX ((c), (d)))
|
|
|
|
|
|
gint gimp_get_pid (void);
|
|
guint64 gimp_get_physical_memory_size (void);
|
|
gchar * gimp_get_default_language (const gchar *category);
|
|
GimpUnit * gimp_get_default_unit (void);
|
|
|
|
gchar ** gimp_properties_append (GType object_type,
|
|
gint *n_properties,
|
|
gchar **names,
|
|
GValue **values,
|
|
...) G_GNUC_NULL_TERMINATED;
|
|
gchar ** gimp_properties_append_valist (GType object_type,
|
|
gint *n_properties,
|
|
gchar **names,
|
|
GValue **values,
|
|
va_list args);
|
|
void gimp_properties_free (gint n_properties,
|
|
gchar **names,
|
|
GValue *values);
|
|
|
|
gchar * gimp_markup_extract_text (const gchar *markup);
|
|
|
|
const gchar* gimp_enum_get_value_name (GType enum_type,
|
|
gint value);
|
|
|
|
gboolean gimp_get_fill_params (GimpContext *context,
|
|
GimpFillType fill_type,
|
|
GeglColor **color,
|
|
GimpPattern **pattern,
|
|
GError **error);
|
|
|
|
/* Common values for the n_snap_lines parameter of
|
|
* gimp_constrain_line.
|
|
*/
|
|
#define GIMP_CONSTRAIN_LINE_90_DEGREES 2
|
|
#define GIMP_CONSTRAIN_LINE_45_DEGREES 4
|
|
#define GIMP_CONSTRAIN_LINE_15_DEGREES 12
|
|
|
|
void gimp_constrain_line (gdouble start_x,
|
|
gdouble start_y,
|
|
gdouble *end_x,
|
|
gdouble *end_y,
|
|
gint n_snap_lines,
|
|
gdouble offset_angle,
|
|
gdouble xres,
|
|
gdouble yres);
|
|
|
|
gint gimp_file_compare (GFile *file1,
|
|
GFile *file2);
|
|
gboolean gimp_file_is_executable (GFile *file);
|
|
gchar * gimp_file_get_extension (GFile *file);
|
|
GFile * gimp_file_with_new_extension (GFile *file,
|
|
GFile *ext_file);
|
|
gboolean gimp_file_delete_recursive (GFile *file,
|
|
GError **error);
|
|
|
|
gchar * gimp_data_input_stream_read_line_always
|
|
(GDataInputStream *stream,
|
|
gsize *length,
|
|
GCancellable *cancellable,
|
|
GError **error);
|
|
|
|
gboolean gimp_data_input_stream_read_char (GDataInputStream *input,
|
|
gchar *value,
|
|
GError **error);
|
|
gboolean gimp_data_input_stream_read_short (GDataInputStream *input,
|
|
gint16 *value,
|
|
GError **error);
|
|
gboolean gimp_data_input_stream_read_long (GDataInputStream *input,
|
|
gint32 *value,
|
|
GError **error);
|
|
gboolean gimp_data_input_stream_read_ucs2_text (GDataInputStream *input,
|
|
gchar **value,
|
|
GError **error);
|
|
gboolean gimp_data_input_stream_rle_decode (GDataInputStream *input,
|
|
gchar *buffer,
|
|
gsize buffer_size,
|
|
gint32 height,
|
|
GError **error);
|
|
|
|
gboolean gimp_ascii_strtoi (const gchar *nptr,
|
|
gchar **endptr,
|
|
gint base,
|
|
gint *result);
|
|
gboolean gimp_ascii_strtod (const gchar *nptr,
|
|
gchar **endptr,
|
|
gdouble *result);
|
|
|
|
gchar * gimp_appstream_to_pango_markup (const gchar *as_text);
|
|
void gimp_appstream_to_pango_markups (const gchar *as_text,
|
|
gchar **introduction,
|
|
GList **release_items);
|
|
|
|
gint gimp_g_list_compare (GList *list1,
|
|
GList *list2);
|
|
|
|
GimpTRCType gimp_suggest_trc_for_component_type (GimpComponentType component_type,
|
|
GimpTRCType old_trc);
|
|
|
|
GimpAsync * gimp_idle_run_async (GimpRunAsyncFunc func,
|
|
gpointer user_data);
|
|
GimpAsync * gimp_idle_run_async_full (gint priority,
|
|
GimpRunAsyncFunc func,
|
|
gpointer user_data,
|
|
GDestroyNotify user_data_destroy_func);
|
|
|
|
GimpImage * gimp_create_image_from_buffer (Gimp *gimp,
|
|
GeglBuffer *buffer,
|
|
const gchar *image_name);
|
|
|
|
gint gimp_view_size_get_larger (gint view_size);
|
|
gint gimp_view_size_get_smaller (gint view_size);
|
|
|
|
#ifdef G_OS_WIN32
|
|
gboolean gimp_win32_have_wintab (void);
|
|
gboolean gimp_win32_have_windows_ink (void);
|
|
#endif
|
|
|
|
gint gimp_version_cmp (const gchar *v1,
|
|
const gchar *v2);
|
|
|
|
GList * gimp_get_type_children (GType type,
|
|
GList *types,
|
|
GList *excluded);
|