bf6fcac0a9
This was happening when trying to load a file before fonts were fully loaded, which may happen when loading while starting GIMP (either from CLI, or from a file browser, etc.), or simply just after start for people with a lot of fonts, whose font loading may take a long time as background task. Note that I didn't manage to reproduce properly because from reports, it seems like the problem appears where some fonts may be only partly loaded so gimp_font_get_hash() fails to load the font and get a hash. I never managed to trigger such a case and no reporters answered my call for testing of debug builds. As a consequence, I'll just assume that simply waiting for all fonts to be loaded before starting to load images would work out. Note that the crash was not happening when text layers were using the older syntax (pre-XCF 19) of text layer data, since it was not storing any font hash, which means that we were not trying to compare hashes. It would also not crash if fonts were not fully loaded yet, but we didn't have any weird intermediate state where fonts appeared in the list yet their file were not hashable (cf. what I failed to reproduce, as explained in previous paragraph). But both these cases were not ideal either anyway because then we could load the XCF apparently OK… except that the correct fonts would not be associated to the related text layers (hence as soon as you start to edit said texts, the rendering would break). So we should wait for fonts to be loaded, and that was a bug even when you can't reproduce the crash. When starting GIMP without loading an image, or simply when fonts are loaded quickly enough, it won't make any difference. So it should not make startup any slower for most common use cases and installations.
34 lines
1.5 KiB
C
34 lines
1.5 KiB
C
/* GIMP - The GNU Image Manipulation Program
|
|
* Copyright (C) 1995-2002 Spencer Kimball, Peter Mattis, and others
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
|
|
void gimp_data_factories_init (Gimp *gimp);
|
|
void gimp_data_factories_add_builtin (Gimp *gimp);
|
|
void gimp_data_factories_clear (Gimp *gimp);
|
|
void gimp_data_factories_exit (Gimp *gimp);
|
|
|
|
gboolean gimp_data_factories_wait (Gimp *gimp);
|
|
|
|
gint64 gimp_data_factories_get_memsize (Gimp *gimp,
|
|
gint64 *gui_size);
|
|
void gimp_data_factories_data_clean (Gimp *gimp);
|
|
|
|
void gimp_data_factories_load (Gimp *gimp,
|
|
GimpInitStatusFunc status_callback);
|
|
void gimp_data_factories_save (Gimp *gimp);
|