Commit graph

15133 commits

Author SHA1 Message Date
Massimo Valentini
5d2933c51c app: don't pass a NULL widget to gtk_widget_event
<Alt>C C <Ctrl>1 <ESC> used to print:

(gimp-2.8:1): Gtk-CRITICAL **: IA__gtk_widget_event:
                assertion `GTK_IS_WIDGET (widget)' failed
2012-07-05 18:08:01 +02:00
Massimo Valentini
b874c8af1e Bug 679082: Crash after using Rotate tool 2012-06-30 13:05:55 +02:00
Massimo Valentini
bf503ea7dd app: compress motion events up to the first release event
I'm not sure if it'd be better to compress only sequence
of contiguous motion events, thinking to the case of anticipating
a motion event before a modifier key press/release.
2012-06-24 13:23:10 +02:00
Massimo Valentini
bf8e42330b Bug 677375: tools do not strictly follow mouse...
pointer (missing motion events)

Disable calls gimp_help_set_help_data for shell->canavs
2012-06-18 18:14:42 +02:00
Michael Natterer
310a8c4458 app: get the help_id from the right action in gimp_editor_add_action_button()
(cherry picked from commit 4fbf01baef)
2012-06-12 22:52:24 +02:00
Michael Natterer
d81669a671 Bug 677974 - GIMP suggests XCF as default export format
Only auto-add .xcf if it's a save (not an export) dialog, instead do
not auto-add anything and ask the user to enter an extension, that's
less mysterious than saving in the last-exported format which the user
maybe doesn't remember or want.
(cherry picked from commit 2f8d45611c)
2012-06-12 22:36:10 +02:00
Michael Natterer
687fbf4583 Bug 677823 - Shift + mouse click to link all layers does not work
This got lost during layer group porting, reimplement it, but restrict
"all layers" to the clicked layer's branch in the tree.
(cherry picked from commit 67b5a509b6)
2012-06-12 21:41:39 +02:00
Massimo Valentini
a4ecfde635 Bug 677375: tools do not strictly follow mouse...
pointer (missing motion events)
2012-06-10 17:20:43 +02:00
Massimo Valentini
41ce828243 Bug 645345: 'Color Management' display filter causes performance problems 2012-06-09 15:36:34 +02:00
Michael Natterer
242d71fd73 Bug 677262 - move the layer with the arrow keys, broken after...
commit 9ce8d4fae2. Fix the return_val
logic added in that commit, and make sure we always swallow arroy key
events, because we don't want focus keynav away from the canvas.
(cherry picked from commit f400bc49ca)
2012-06-08 00:23:39 +02:00
Massimo Valentini
c3bf36f3d6 app: remove a weak ptr when the object lives longer than the ptr
Closing the display filter editor with a filter selected
in the listview on the right, used to produce (quitting GIMP):

==32359== Invalid write of size 8
==32359==    at 0x8808DF5: g_nullify_pointer (glib/glib/gutils.c:2099)
==32359==    by 0x8358781: weak_refs_notify (glib/gobject/gobject.c:2469)
==32359==    by 0x4C3730A: gimp_color_display_dispose (gimp-2-8/libgimpwidgets/gimpcolordisplay.c:197)
==32359==    by 0x83596A7: g_object_unref (glib/gobject/gobject.c:2986)
==32359==    by 0x4C37EFA: gimp_color_display_stack_dispose (gimp-2-8/libgimpwidgets/gimpcolordisplaystack.c:150)
==32359==    by 0x83596A7: g_object_unref (glib/gobject/gobject.c:2986)
==32359==    by 0x53F1C3: gimp_display_shell_filter_set (gimp-2-8/app/display/gimpdisplayshell-filter.c:58)
==32359==    by 0x536A50: gimp_display_shell_dispose (gimp-2-8/app/display/gimpdisplayshell.c:765)
2012-06-04 19:32:41 +02:00
Michael Natterer
9ce8d4fae2 Bug 676872 - Image Properties keyboard shortcut Alt+Return Broken
Don't swallow key events which were not handled by the keyboard
controller.
(cherry picked from commit 6c9f1b5715)
2012-05-27 19:57:43 +02:00
Daniel Sabo
668891e745 app: use an idle source to dispatch GTK menu events in ige-mac-menu
in order to work around the crashes in bug #673264 and bug #674108.
(cherry picked from commit c1786fe753)
2012-05-27 19:10:30 +02:00
Michael Natterer
4437b90b63 Bug 676821 - No drag layers in "window layers", after commit...
Remove the button_release handler again, setting dnd_widget to NULL on
container change is enough to fix the crash I've seen, I added the
other handler just out of paranoia and apparently didn't test it.
(cherry picked from commit 92a3944442)
2012-05-25 21:27:50 +02:00
Massimo Valentini
0008be8484 Bug 673773: Colour of image changes with zooming
transform a right shift by 8 in the correct
division by 255 and rounds to the nearset
2012-05-24 19:42:42 +02:00
Michael Natterer
74c20f2222 Bug 676585 - Gimp crashes when writing in Arabic and clicking right arrow
Check for pango_layout_move_cursor_visually() returning a new index of
G_MAXINT, which indicates that we moved beyond the end of the layout,
and do nothing instead of trying to access the memory there.
(cherry picked from commit 7d280abd9a)
2012-05-23 09:47:29 +02:00
Michael Natterer
a4fb9692ae Bug 676522 - Changing tabs in single-window-mode should switch the active image
Change the active image when switching tabs in single-window-mode.
(cherry picked from commit c1cfe98d35)
2012-05-23 01:27:25 +02:00
Michael Natterer
e2ad99b98e app: set GimpContainerTreeView->dnd_renderer to NULL more reliably
specifically in button_release() and when the container changes, we
can badly crash in some situations otherwise.
(cherry picked from commit 27a767ee54)
2012-05-22 13:02:33 +02:00
Michael Natterer
6899757b09 app: make file_save() aware of the difference between overwrite and export
by having two booleans "export_backward" and "export_forward" in the
api instead of just an "export" one that would destroy the "imported
from" state. This change fixes the state of the "Overwrite" menu item,
so it stays visible until the file got either saved or exported to
another filename.

This also reverts commit a4beeecf2b, so
Ctrl-S is always invokable even if invisible.
(cherry picked from commit 39c18e9a48)
2012-05-18 18:59:10 +02:00
Michael Natterer
4fdb1ec90a Bug 676279 - Ctrl or Shift causes selection tools to reset...
Make sure to not override the logic that separates the tool option's
selection mode from the one determined by modifiers, by blindly
calling gimp_modifiers_to_channel_op(state) on a zero state.
(cherry picked from commit 2d882dd64f)
2012-05-17 23:35:05 +02:00
Michael Natterer
741daccf02 Revert "app (gimprc): Delete dead assignment"
This reverts commit d6d2a0bbd1
and allows more than one unknown gimprc token again.

Fixes Bug 674096 - Strange behavior with gimprc
(cherry picked from commit 8851ec0b6e)
2012-05-17 01:19:20 +02:00
Michael Natterer
be2feeb111 Bug 676164 - Text Tool selects hidden layers
Also fix the other layer picking functions to not pick invisible
layers.
(cherry picked from commit b50e924df0)
2012-05-17 00:18:44 +02:00
Daniel Sabo
82533e7734 Bug 675875 - Gimp Quartz doesn't respond to file open events from finder
Add Carbon based apple events responder for kAEOpenDocuments
(cherry picked from commit 7d62e8370a)
2012-05-16 23:03:02 +02:00
Michael Natterer
8d6004e063 Bug 676107 - Picking logic doesn't take group visibility into account
gimp_layer_get_opacity_at(): use gimp_item_is_visible() not
get_visible() so we use the layer's effective visibility.
(cherry picked from commit 4d1173570a)
2012-05-15 19:48:56 +02:00
Michael Natterer
1e402a46f0 Bug 675994 - Opening image with a saved selection breaks histogram updating
In fact, it broke much more than that because the way XCF loading
replaced the image's mask prevented the image's "mask-changed" signal
from ever being emitted. Add private API gimp_image_take_mask() which
properly sets the mask and use it for image construction and the XCF
selection loading hack.
(cherry picked from commit ab4c613a70)
2012-05-14 01:47:14 +02:00
Michael Natterer
36bb8a625b app: default to half the physical memory for the tile-cache-size setting
Wanted to do this for ages but forgot...
2012-05-13 20:21:00 +02:00
Michael Natterer
46127dc789 Move gimpdir and thumbnails to proper places on OSX
gimpdir goes to ~/Library/Gimp/x.y
thumbnails go to ~/Library/Caches/org.freedesktop.thumbnails

The thumbnail location is not standardized yet, but is the only
location that makes sense. Also fix user install to search old
gimpdirs to migrate in both Library and the classic location.
Remove the obsolete CABON_CFLAGS from all makefiles.
(cherry picked from commit 9112d68488)
2012-05-12 14:44:08 +02:00
Michael Muré
cb2de50697 cage tool: fix handle added in the wrong side of the cage
This happened when:
1) cage still open
2) clicking on the edge between the first and the last handle
2012-05-11 12:42:53 +09:00
Michael Muré
f8bcdcb9a5 Bug 675825 - (cage) simply using cage transform tool makes gimp to crash.
Just check if there is enough handles before closing
2012-05-11 12:04:49 +09:00
Michael Henning
fa8a5a63ab Bug 568098 - Healing Tool doesn't work at the layer borders.
Fixes the row stride for the brush mask.
2012-05-10 20:13:27 +02:00
Michael Natterer
e5ef544559 app: make the popup previews transient to their parent's toplevel
so they don't appear below the dock. Seems to happen on OSX only,
but is the right things to do on all platforms.
(cherry picked from commit ffb559547c)
2012-05-10 19:51:19 +02:00
Michael Natterer
062d38d141 Bug 675399 - Mention that the image was at least exported in the close...
If the image was exported, mention it in the close warning dialog.
(cherry picked from commit 57d4680ab3)
2012-05-10 01:11:54 +02:00
Michael Natterer
c4d14752a7 Bug 630173 - a dockable open from an existing one appears under it
Show the new dock with gtk_widget_show_now(), which waits until it's
mapped, then call gdk_window_raise() explicitly. How sick...
(cherry picked from commit bd3f892f79)
2012-05-09 00:23:10 +02:00
Michael Natterer
7f37903b11 app: make GimpContainerPopup transient to its parent toplevel
so it doesn't appear under the dock it's invoked from. Only
needed on OSX, but the right thing to do on all platforms.
(cherry picked from commit 3545140ad8)
2012-05-08 21:36:05 +02:00
Michael Natterer
7ef8a96465 app: don't call gimp_image_flush() when cancelling GimpImageMapTool
because the tool might be cancelled from some other place opening an
undo group, so flushing the image would update menus and whatnot while
that other operation is running, with unforeseeable side
effects. Also, flusing the image here is not needed because we didn't
change anything in the image. Instead, make sure manually that the
display is updated correctly after restoring GimpImageMapTool's
temporary editing.
(cherry picked from commit e7e8c9ef0a)
2012-05-05 21:48:13 +02:00
Michael Natterer
32a0c6355e app: fix UI tag matching to always work case-insensitively
Add gimp_tag_has_prefix() and use it in GimpTagEntry when completing
patrially entered tag names, and fix two uses of strcmp() in
GimpTagPopup to use gimp_tag_compare_with_string().
(cherry picked from commit 30b4fe8510)
2012-05-05 19:00:32 +02:00
Michael Natterer
4c66e50763 app: make sure Ctrl+E doesn't invoke "Export to" when it's invisible 2012-05-05 00:17:51 +02:00
Enrico Schröder
8cd272bb80 Heal: Make HealTool work when brush is partially outside of layer
Fix for bug 568098 https://bugzilla.gnome.org/show_bug.cgi?id=568098
Removes condition for not applying heal when (destination)brush is partially outside of layer.
Instead heal is not applied when brush is completely outside.
2012-04-24 22:21:25 +03:00
Michael Henning
2920344524 app: Prevent uninitialized values in the heal tool.
Previously, the black checkers of the left hand edge of the solution
matrix were not being assigned a value.
2012-04-24 22:08:44 +03:00
Michael Natterer
24e6b20be8 Bug 674373 - Resizing Mask size is making gimp to crash
gimp_transform_tool_real_transform(): make sure we clip layer masks
and channels to their original extents also when transforming them
completely (not just a selection of them).
2012-04-21 22:42:53 +02:00
Mikael Magnusson
0025f9f354 fix typo "equalizee" 2012-04-12 01:28:30 +02:00
Nils Philippsen
ff6c2807be app: add a little more headroom to the smudge buffer
This fixes crashes when smudging with sizes <= 1.4, filed against Fedora
(rhbz#810850).
2012-04-11 19:04:58 +02:00
Michael Natterer
e1dcba190e app: don't leak one TempBuf per blurred brush mask/pixmap 2012-04-04 11:35:59 +02:00
Michael Natterer
531709c8db Depend on ATK 2.2.0, GTK+ 2.24.10, GdkPixbuf 2.24.1
And do some final NEWS adjustments for RC1
2012-04-03 00:53:04 +02:00
Øyvind Kolås
36c52537e4 bump babl req versions to 0.1.10 and gegl to 0.2.0 2012-04-02 23:11:07 +01:00
Michael Natterer
9252922651 Depend on GEGL 0.1.9 and use the new gegk-0.1 pkg-config file 2012-04-02 12:33:26 +02:00
Michael Natterer
90706f8427 app: make sure explicitly saved color tool settings don't end up in "recent"
reset the "time" property after applying the stored setting, otherwise
explicitly storing the config as setting will also copy the time, and
the stored object will be considered to be among the automatically
stored recently used settings
2012-04-02 11:50:47 +02:00
Michael Natterer
657a2661b2 app: fix saving of the settings' timestamp in color tool config classes
we override serialize_property() and are responsible for doing it
ourselves.
2012-04-02 11:49:22 +02:00
Martin Nordholts
08cbf159c1 app/tests: Update gegl_buffer_get() code so it builds 2012-04-01 11:44:12 +02:00
Michael Natterer
817d516da4 Depend on Babl 0.1.8 2012-03-30 10:13:23 +02:00