Commit graph

8694 commits

Author SHA1 Message Date
Michael Natterer
b831c0c32d made validation error messages more human-readable and prepared the code
2006-11-23  Michael Natterer  <mitch@gimp.org>

	* app/pdb/gimpprocedure.c (gimp_procedure_validate_args): made
	validation error messages more human-readable and prepared the
	code for validating return values.
2006-11-23 12:42:58 +00:00
Sven Neumann
f95a118603 special case invalid drawable and image IDs and try to give a somewhat
2006-11-23  Sven Neumann  <sven@gimp.org>

	* app/pdb/gimpprocedure.c (gimp_procedure_validate_args): special
	case invalid drawable and image IDs and try to give a somewhat
	more helpful error message (addresses bug #378334).
2006-11-23 09:17:07 +00:00
Sven Neumann
be67311b0b marked the new functions as new in 2.4.
2006-11-23  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/image.pdb: marked the new functions as new in
2.4.

	* app/pdb/image_cmds.c
	* libgimp/gimpimage_pdb.c: regenerated.
2006-11-23 06:41:08 +00:00
Simon Budig
7968dcdc56 Cosmetic reordering - Simon 2006-11-22 22:54:53 +00:00
Simon Budig
ff68bde625 Added functions to easily determine the position of a
2006-11-22  Simon Budig  <simon@gimp.org>

	* tools/pdbgen/pdb/image.pdb: Added functions to easily determine
	the position of a layer/channel/vectors object in its respective
	stack.

	* libgimp/gimp.def: added new symbols

	* app/pdb/image_cmds.c
	* app/pdb/internal_procs.c
	* libgimp/gimpimage_pdb.[ch]: regenerated.
2006-11-22 22:36:24 +00:00
Simon Budig
d27db948d7 Enable scrolling while dragging the nodes of a path. Fix warning when
2006-11-22  Simon Budig  <simon@gimp.org>

	* app/tools/gimpvectortool.c: Enable scrolling while dragging
	the nodes of a path. Fix warning when deleting the last node
	of a stroke.
2006-11-22 20:50:39 +00:00
Michael Natterer
a10d6099cb add support for G_TYPE_INT properties.
2006-11-22  Michael Natterer  <mitch@gimp.org>

	* app/actions/actions.c (action_select_property): add support for
	G_TYPE_INT properties.

	* app/actions/tools-actions.c
	* app/actions/tools-commands.[ch]: add actions and callback which
	affect the foreground select tool's stroke-width property.

	* app/tools/gimpforegroundselecttool.c: map tool-action-value-2
	(tool tip size) to the new action.

	* app/tools/gimppaintoptions-gui.c: fixed visibility of the brush
	scale slider.
2006-11-22 20:38:36 +00:00
Michael Natterer
3b903bae0c applied modified patch from Adrian Likins which adds a GRand to the
2006-11-22  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpbrushcore.[ch]: applied modified patch from Adrian
	Likins which adds a GRand to the GimpBrushCore struct and uses it
	instead of using g_random_foo() functions. Fixes bug #377981.
2006-11-22 20:22:32 +00:00
Sven Neumann
aa09e29272 don't raise and focus the error console for not so severe error messages.
2006-11-22  Sven Neumann  <sven@gimp.org>

	* app/gui/gui-message.c (gui_message_error_console): don't raise
	and focus the error console for not so severe error messages. Fixes
	bug #322210 and bug #373254.

	* app/widgets/gimperrorconsole.c (gimp_error_console_init): reduced
	font sizes in error console.
2006-11-22 16:33:31 +00:00
Simon Budig
d3543f1b06 load the channels in the proper order. fixes bug #378003. Thanks to Chris
2006-11-22  Simon Budig  <simon@gimp.org>

	* app/xcf/xcf-load.c: load the channels in the proper order.
	fixes bug #378003. Thanks to Chris Mohler for spotting this.
2006-11-22 10:19:53 +00:00
Michael Natterer
7d30e91cf5 the pixmap's size is width * height * bpp, not just width * height.
2006-11-21  Michael Natterer  <mitch@gimp.org>

	* tools/pdbgen/pdb/brush.pdb (brush_get_pixels): the pixmap's size
	is width * height * bpp, not just width * height.

	* app/pdb/brush_cmds.c: regenerated.
2006-11-21 22:43:41 +00:00
Sven Neumann
226b2e6333 check argument types before assigning them. Allows to use a batch
2006-11-21  Sven Neumann  <sven@gimp.org>

	* app/batch.c (batch_run_cmd): check argument types before
	assigning them. Allows to use a batch processor processor without
	a run-mode parameter.
2006-11-21 14:26:03 +00:00
Simon Budig
73b1863a28 app/vectors/gimpstroke.[ch] tools/pdbgen/pdb/vectors.pdb Applied patch
2006-11-20  Simon Budig  <simon@gimp.org>

	* app/vectors/gimpstroke.[ch]
	* tools/pdbgen/pdb/vectors.pdb
	* plug-ins/pygimp/pygimp-vectors.c: Applied patch from
	Joao S. O. Bueno Calligaris that adds some missing transformations
	to the PDB-API for strokes. Fixes bug #129598.

	* app/pdb/internal_procs.c
	* app/pdb/vectors_cmds.c
	* libgimp/gimpvectors_pdb.[ch]: regenerated.
2006-11-20 15:34:30 +00:00
Michael Natterer
170901c5eb applied patch from Jernej Simoncic which enables environment variables and
2006-11-18  Michael Natterer  <mitch@gimp.org>

	* app/plug-in/plug-in-rc.c (plug_in_def_deserialize): applied
	patch from Jernej Simoncic which enables environment variables and
	${gimp_foo} variables in plug-in filename and converts them to
	filesystem encoding. Fixes bug #375349.

	(plug_in_rc_write): write UTF-8 filenames to pluginrc.
2006-11-18 16:19:47 +00:00
Michael Natterer
02de3076c9 Got rid of the word "editor" were it was good for nothing but exposing an
2006-11-17  Michael Natterer  <mitch@gimp.org>

	Got rid of the word "editor" were it was good for nothing but
	exposing an implementation detail in public API and installed
	files.  Fixes bug #345251:

	* app/actions/colormap-editor-actions.[ch]
	* app/actions/colormap-editor-commands.[ch]
	* app/actions/sample-point-editor-actions.[ch]
	* app/actions/sample-point-editor-commands.[ch]
	* menus/colormap-editor-menu.xml
	* menus/sample-point-editor-menu.xml
	* menus/selection-editor-menu.xml
	* menus/undo-editor-menu.xml: removed.

	* app/actions/colormap-actions.[ch]
	* app/actions/colormap-commands.[ch]
	* app/actions/sample-points-actions.[ch]
	* app/actions/sample-points-commands.[ch]
	* menus/colormap-menu.xml
	* menus/sample-points-menu.xml
	* menus/selection-menu.xml
	* menus/undo-menu.xml: added.

	* app/actions/Makefile.am
	* menus/Makefile.am
	* app/actions/actions.c
	* app/menus/menus.c
	* app/menus/plug-in-menus.c
	* app/plug-in/gimppluginprocedure.c
	* app/widgets/gimpcolormapeditor.c
	* app/widgets/gimpsamplepointeditor.c
	* app/widgets/gimpselectioneditor.c
	* app/widgets/gimpundoeditor.c
	* plug-ins/common/colormap-remap.c: changed accordingly.
2006-11-17 22:07:07 +00:00
Michael Natterer
4ce3fda9e7 don't pass GRAY images to plug_in_icc_profile_apply_rgb().
2006-11-17  Michael Natterer  <mitch@gimp.org>

	* app/file/file-open.c (file_open_profile_apply_rgb): don't pass
	GRAY images to plug_in_icc_profile_apply_rgb().
2006-11-17 20:04:13 +00:00
Simon Budig
bacc2e29cf Fix the registration to properly test for the parameter types.
2006-11-17  Simon Budig  <simon@gimp.org>

	* app/plug-in/gimppluginprocedure.c: Fix the registration to
	properly test for the parameter types.
2006-11-17 18:35:44 +00:00
Simon Budig
a8411dc754 Hack up gimp_value_set_item() to do the correct thing for subtypes of
2006-11-17  Simon Budig  <simon@gimp.org>

	* app/core/gimpparamspecs.c: Hack up gimp_value_set_item() to do
	the correct thing for subtypes of GimpItems.

	* app/actions/plug-in-commands.c: Don't rely on the GimpValues for
	type checking, pass the param specs to the _collect functions and
	use them for typechecking.
2006-11-17 16:56:37 +00:00
Michael Natterer
c8cb6bfcf4 app/actions/tools-actions.c added actions and callbacks for the new paint
2006-11-17  Michael Natterer  <mitch@gimp.org>

	* app/actions/tools-actions.c
	* app/actions/tools-commands.[ch]: added actions and callbacks for
	the new paint options brush scale property. Assigned new
	shortcuts: '<' and '>' are now changing tool-value-1 and '[' and
	']' are changing tool-value-2

	* app/actions/context-actions.c: removed the shortcuts from the
	brush size actions.

	* app/tools/gimpbrushtool.c
	* app/tools/gimpcolortool.c: set tool-value-2 to brush-scale and
	to color-average-radius, so '[' and ']' always affect the size of
	the tip of the active tool. tool-value-1 is connected to
	context-opacity so that is changeable using '<' and '>' now.
2006-11-17 13:06:00 +00:00
Michael Natterer
6eb7089577 Made all brushes scalable from the tool options. So far only downscaling
2006-11-16  Michael Natterer  <mitch@gimp.org>

	Made all brushes scalable from the tool options. So far only
	downscaling is supported since we lack an algorithm for bitmap
	brush upscaling. Addresses bug #65030.

	* app/paint/gimppaintoptions.[ch]: added "brush-scale" property.

	* app/paint/gimpbrushcore.[ch]: separate pressure logic from brush
	scaling logic and take paint_options->brush_scale into account.
	Added gimp_brush_core_create_bound_segs() which returns BoundSegs
	of the correctly scaled brush mask for the brush preview on the
	canvas.

	* app/tools/gimpbrushtool.c: use gimp_brush_core_create_bound_segs()
	instead of doing this here (also removes all knowledge about lowlevel
	stuff from this file). Connect to notify::brush-scale of the
	paint options and invalidate the brush core's brush accordingly.

	* app/tools/gimppaintoptions-gui.c: added brush scale slider.
2006-11-16 15:11:27 +00:00
Sven Neumann
13004433f5 cursors/Makefile.am cursors/cursor-move.png cursors/gimp-tool-cursors.xcf
2006-11-15  Sven Neumann  <sven@gimp.org>

	* cursors/Makefile.am
	* cursors/cursor-move.png
	* cursors/gimp-tool-cursors.xcf
	* cursors/xbm/cursor-move-mask.xbm
	* cursors/xbm/cursor-move.xbm: added new cursor.

	* app/widgets/gimpcursor.c
	* app/widgets/widgets-enums.h: added as GIMP_CURSOR_MOVE.

	* app/tools/gimprectangletool.c: use instead of a cursor
modifier.
2006-11-15 22:43:24 +00:00
Sven Neumann
c4b8cda67d app/tools/gimprectangletool.[ch] removed function from the properties.
2006-11-15  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.[ch]
	* app/tools/gimprectangleselecttool.c: removed function from the
	properties. Added getter and setter functions instead. Redraw
the
	tool whenever the function changes.
2006-11-15 20:45:43 +00:00
Michael Natterer
35f198e7b0 use brush_scale_pixmap(), not brush_scale_mask().
2006-11-15  Michael Natterer  <mitch@gimp.org>

	* app/core/gimpbrush.c (gimp_brush_real_scale_pixmap): use
	brush_scale_pixmap(), not brush_scale_mask().
2006-11-15 18:46:10 +00:00
Sven Neumann
da2253fce0 don't use gimp_dialog_set_sensitive(); just make the entry not editable
2006-11-14  Sven Neumann  <sven@gimp.org>

	* app/dialogs/file-open-location-dialog.c: don't use
	gimp_dialog_set_sensitive(); just make the entry not editable and
	the dialog's OK button insensitive.

	* app/widgets/gimpfiledialog.c
	* app/widgets/gimpwidgets-utils.[ch]: moved gimp_dialog_set_sensitive()
	implementation into gimp_file_dialog_set_sensitive().
2006-11-14 13:46:43 +00:00
Sven Neumann
26db711437 reduced the size of the side handles to two third the size of the corner
2006-11-13  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.c: reduced the size of the side
	handles to two third the size of the corner handles.
2006-11-13 16:13:37 +00:00
Michael Natterer
baf90e745e fix g_str_has_prefix() change below. Now we can open XCF files again.
2006-11-13  Michael Natterer  <mitch@gimp.org>

	* app/xcf/xcf.c (xcf_load_invoker): fix g_str_has_prefix() change
	below. Now we can open XCF files again. Fixes bug #374657.
2006-11-13 13:11:34 +00:00
Michael Natterer
85cecec576 app/base/base.c app/core/gimp-user-install.c
2006-11-12  Michael Natterer  <mitch@gimp.org>

	* app/base/base.c
	* app/core/gimp-user-install.c
	* app/core/gimpbrushgenerated-load.c
	* app/core/gimpcontainer.c
	* app/core/gimpgradient-load.c
	* app/core/gimppalette-load.c
	* app/core/gimpparamspecs-desc.c
	* app/dialogs/tips-parser.c
	* app/menus/plug-in-menus.c
	* app/plug-in/gimppluginmanager.c
	* app/plug-in/gimppluginprocedure.c
	* app/text/gimptext-parasite.c
	* app/tools/gimpforegroundselecttool.c
	* app/widgets/gimpselectiondata.c
	* app/xcf/xcf.c: use g_str_has_prefix() instead of strncmp().
2006-11-12 20:30:50 +00:00
Michael Natterer
cb6fe48ccd Fix behavior so that when Alt is down, it appears as if no other modifier
2006-11-11  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpselectiontool.c
	(gimp_selection_tool_modifier_key): Fix behavior so that when Alt
	is down, it appears as if no other modifier was pressed.
	Fixes bug #349338.
2006-11-11 10:44:02 +00:00
Michael Natterer
1186dfd256 Properly abstract brush scaling:
2006-11-09  Michael Natterer  <mitch@gimp.org>

	Properly abstract brush scaling:

	* app/core/gimpbrush.[ch]: added virtual functions
	GimpBrush::scale_mask() and ::scale_pixmap() and default
	implementations which call the functions in base/brush-scale.c.

	* app/core/gimpbrushgenerated.c: factored out brush calculation to
	an internal utility function and call that function from ::dirty()
	and from the new ::scale_mask().

	* app/core/gimpbrushcore.c: use gimp_brush_scale_mask/pixmap()
	instead of using the lowlevel scale functions directly. Fixes the
	uglyness that we were scaling generated brushes instead of simply
	recalculating them in the right size.
2006-11-09 14:54:49 +00:00
Sven Neumann
0f0da9c766 added missing quotes in test for libcurl.
2006-11-09  Sven Neumann  <sven@gimp.org>

	* configure.in: added missing quotes in test for libcurl.

	* app/plug-in/gimppluginprocedure.c
	(gimp_plug_in_procedure_add_menu_path): try not to crash on
	invalid menu paths and avoid a string copy for the common case.

	* app/composite/gimp-composite-mmx.c: commented out unused code.
2006-11-09 09:39:36 +00:00
Sven Neumann
5c0ff0f6e2 removed dead code.
2006-11-07  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.c: removed dead code.
2006-11-08 07:22:42 +00:00
Sven Neumann
a44f83c66c simplified.
2006-11-07  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.c
(gimp_rectangle_tool_oper_update):
	simplified.
2006-11-07 22:07:22 +00:00
Sven Neumann
f47f58886a undef DEBUG_SPEW again.
2006-11-07  Sven Neumann  <sven@gimp.org>

	* app/dialogs/file-save-dialog.c: undef DEBUG_SPEW again.

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_draw):
	don't draw the handles while the rectangle is being moved.
2006-11-07 14:08:14 +00:00
Sven Neumann
b41bc68023 improved highlighting. (gimp_draw_tool_draw_arc_by_anchor): take width and
2006-11-07  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpdrawtool.[ch] (gimp_draw_tool_draw_corner):
	improved highlighting.
	(gimp_draw_tool_draw_arc_by_anchor): take width and height
	arguments instead of radius_x and radius_y.

	* app/tools/gimpiscissorstool.c
	* app/tools/gimpvectortool.c: slightly increased handle sizes.

	* app/tools/gimpmeasuretool.c: increased size of the end points.

	* app/tools/gimpperspectiveclonetool.c: increased handle size.

	* app/tools/gimprectangletool.c: renamed variables.

	* app/tools/gimpsourcetool.c: use a single define for the target
size.

	* app/tools/gimptransformtool.[ch]: increased handle size. Made
	the area that can be grabbed identical to the displayed handle.
	Replaced filled circle with a circle outline and a cross.

	* app/tools/gimptransformtool-undo.c: follow renaming of define
in
	gimptransformtool.h.
2006-11-07 11:09:51 +00:00
Sven Neumann
4d6715421f improved error reporting.
2006-11-07  Sven Neumann  <sven@gimp.org>

	* app/file/file-utils.c (file_utils_find_proc): improved error
	reporting.
2006-11-07 11:09:22 +00:00
Sven Neumann
6577834f1f app/tools/gimpdrawtool.[ch] (gimp_draw_tool_draw_corner) highlight the
2006-11-06  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpdrawtool.[ch] (gimp_draw_tool_draw_corner)
	* app/tools/gimprectangletool.c (gimp_rectangle_tool_draw):
	highlight the handles on mouse-over.
2006-11-06 17:09:07 +00:00
Sven Neumann
d27e9ead6c simplified.
* app/tools/gimprectangletool.c (gimp_rectangle_tool_draw): simplified.
2006-11-06 16:40:09 +00:00
Sven Neumann
e192b27f6d let gimp_draw_tool_draw_corner() also handle north, south, east and west
2006-11-06  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpdrawtool.[ch]: let gimp_draw_tool_draw_corner()
	also handle north, south, east and west corners and allow for
	filled corners.

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_draw): simplified.
2006-11-06 16:31:11 +00:00
Sven Neumann
194f268f89 app/tools/gimpdrawtool.[ch] changed the way that the handles are drawn.
2006-11-05  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpdrawtool.[ch]
	* app/tools/gimprectangletool.c: changed the way that the
handles
	are drawn. This is still work in progress.
2006-11-06 08:16:31 +00:00
Sven Neumann
41611db1a4 formatting.
2006-11-05  Sven Neumann  <sven@gimp.org>

	* app/xcf-save.c: formatting.
2006-11-06 08:14:46 +00:00
Sven Neumann
43b20e0673 use file_utils_uri_display_basename() instead of g_path_get_basename() to
2006-11-05  Sven Neumann  <sven@gimp.org>

	* app/dialogs/file-save-dialog.c (file_save_dialog_check_uri):
use
	file_utils_uri_display_basename() instead of
g_path_get_basename()
	to get an uri's basename.
2006-11-06 08:12:57 +00:00
Sven Neumann
f544132ca5 only save a thumbnail if we are saving as XCF. Fixes bug #25272.
2006-11-05  Sven Neumann  <sven@gimp.org>

	* app/file/file-save.c (file_save): only save a thumbnail if we
	are saving as XCF.  Fixes bug #25272.

	* tools/pdbgen/pdb/fileops.pdb: create a libgimp wrapper for the
	"gimp-file-save-thumbnail" procedure.

	* libgimp/gimpfileops_pdb.[ch]: regenerated.

	* plug-ins/common/compressor.c (save_image): ask the core to
save
	a thumbnail for compressed XCF files.
2006-11-06 08:12:37 +00:00
Michael Natterer
eae43600da *** empty log message *** 2006-11-05 18:53:13 +00:00
Michael Natterer
029f94f658 made gimp_rectangle_tool_halt() private. Get rid of some more local
2006-11-05  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangletool.[ch]: made gimp_rectangle_tool_halt()
	private. Get rid of some more local variables (use private->foo
	instead). Fixed statusbar rectangle size display. Some indentation
	cleanup.
2006-11-05 16:36:15 +00:00
Michael Natterer
cedbebfce3 remove GIMP_CONFIG_PARAM_SERIALIZE from the x0, y0, width, height,
2006-11-05  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangleoptions.c
	(gimp_rectangle_options_iface_base_init): remove
	GIMP_CONFIG_PARAM_SERIALIZE from the x0, y0, width, height,
	center-x and center-y properties. Fixes bug #346683.
2006-11-05 15:10:57 +00:00
Michael Natterer
f8edfbd1a5 app/tools/gimpcroptool.c app/tools/gimprectangleselecttool.c moved stuff
2006-11-05  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpcroptool.c
	* app/tools/gimprectangleselecttool.c
	* app/tools/gimprectangletool.[ch]: moved stuff from
	GimpTool::initialize() to GObject::constructor() and removed all
	initialize functions entirely. initialize() only needs to be
	implemented if the tool has a dialog or if initialization() can
	fail. Also moved some type-checking casts after the
	g_return_if_fail()s
2006-11-05 14:11:34 +00:00
Michael Natterer
2a64b58c97 cache the round-corners and corner-radius properties in the
2006-11-05  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangleselecttool.[ch]: cache the round-corners
	and corner-radius properties in the GimpRectSelectTool struct,
	connect to "notify" of GimpRectSelectOptions and update display
	drawing when the options change.

	* app/tools/gimpcroptool.c
	* app/tools/gimprectangleoptions.c: whitespace stuff.
2006-11-05 13:45:04 +00:00
Michael Natterer
94182f1439 app/tools/gimpcroptool.[ch] app/tools/gimpellipseselecttool.c
2006-11-05  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpcroptool.[ch]
	* app/tools/gimpellipseselecttool.c
	* app/tools/gimprectangleselecttool.[ch]
	* app/tools/gimprectangletool.[ch]: removed dispose() and
	finalize() implementations. The finalize() ones did nothing and
	dispose() was only redundantly disconnecting from signals that
	were connected using connect_object() anyway. Some cosmetic
	cleanups all over the place.
2006-11-05 12:35:59 +00:00
Sven Neumann
e2a0604174 app/actions/file-actions.c app/actions/file-commands.[ch] renamed
2006-11-05  Sven Neumann  <sven@gimp.org>

	* app/actions/file-actions.c
	* app/actions/file-commands.[ch]
	* menus/image-menu.xml.in: renamed file-open-as-layer to
	file-open-as-layers to complete the changes done to fix bug
#358082.
2006-11-05 11:35:57 +00:00
Sven Neumann
dff4ef8f57 applied patch from gg that removes duplicated code (bug #358481).
2006-11-05  Sven Neumann  <sven@gimp.org>

	* app/core/gimp-transform-region.c: applied patch from gg that
	removes duplicated code (bug #358481).
2006-11-05 09:06:47 +00:00