Commit graph

9226 commits

Author SHA1 Message Date
David Odin
91836bfce4 some more fixes by nomis.
* libgimp/gimppixelrgn.c: some more fixes by nomis.
2004-09-12 00:00:38 +00:00
David Odin
cd03397ffa nomis helped me to make some correction to the documentation.
* libgimp/gimppixelrgn.c: nomis helped me to make some correction to
  the documentation.
2004-09-11 23:43:38 +00:00
David Odin
41a86d046b more documentation.
* libgimp/gimppixelrgn.c: more documentation.
2004-09-11 23:05:56 +00:00
David Odin
35cb43787b added a default value (TRUE) for the update_preview toggle.
* plug-ins/common/edge.c: added a default value (TRUE) for the
  update_preview toggle.

* plug-ins/common/wind.c: ported to GimpPreviewArea, so the preview is
  much more useful now.
2004-09-11 21:39:36 +00:00
David Odin
e5be3aa6dc added some gtk-doc documentation to pixel region related functions. (work
* libgimp/gimppixelrgn.c: added some gtk-doc documentation to pixel
  region related functions. (work in progress)
2004-09-11 20:04:29 +00:00
Simon Budig
4a75d7271e Added boolean parameter to gimp_dialog_factories_toggle to make it
2004-09-11  Simon Budig  <simon@gimp.org>

	* app/widgets/gimpdialogfactory.[ch]: Added boolean parameter to
	gimp_dialog_factories_toggle to make it possible to ensure a visible
	toolbox.

	* app/actions/dialogs-commands.c: Use the new parameter to ensure
	toolbox visibility after the last image window closes.

	* app/display/gimpdisplayshell-callbacks.c: Changed accordingly.

	Fixes bug #137057 (the discussion is in bug #152285)
2004-09-11 19:19:26 +00:00
David Odin
004a5e0cd8 ported to GimpPreviewArea. 100 less lines of code and much more features!
* plug-ins/common/edge.c: ported to GimpPreviewArea. 100 less lines of
  code and much more features!
2004-09-11 19:11:04 +00:00
David Odin
9f0842f021 some code cleanup and small optimisations.
* plug-ins/common/oilify.c: some code cleanup and small optimisations.
2004-09-11 15:29:30 +00:00
Sven Neumann
94d0dfb6b3 fixed spelling.
2004-09-10  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/xpm.c (query): fixed spelling.
2004-09-10 17:00:28 +00:00
William Skaggs
fe876df0ed Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/widgets/gimperrorconsole.c: fix typo
2004-09-10 15:38:17 +00:00
Michael Natterer
6b4f7b3955 untabified, removed useless inclusion of <gdk/gdkkeysyms.h>.
2004-09-10  Michael Natterer  <mitch@gimp.org>

	* libgimpwidgets/gimpcolorselect.c: untabified, removed useless
	inclusion of <gdk/gdkkeysyms.h>.
2004-09-10 13:16:55 +00:00
Sven Neumann
a840af33ea ported to GimpPreviewArea. Destroy the GdkGC in unrealize() instead of in
2004-09-10  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpcolorselect.c: ported to GimpPreviewArea.
	Destroy the GdkGC in unrealize() instead of in finalize().
2004-09-10 13:04:45 +00:00
Michael Natterer
4b553f186c always call gdk_drag_status() before returning FALSE.
2004-09-10  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpcontainertreeview-dnd.c
	(gimp_container_tree_view_drop_status): always call
	gdk_drag_status() before returning FALSE.

	(gimp_container_tree_view_drag_motion): never return FALSE, an
	impossible drop location is now reported by calling
	gdk_drag_status() above. Always returning TRUE makes sure
	gimp_container_tree_view_drag_leave() is called unconditionally
	and can remove the scroll_timeout set in drag_motion().

	Fixes bug #152193 and many other obscure DND crashes caused by the
	scroll_timeout being invoked after the widget is destroyed.
2004-09-10 12:20:16 +00:00
Sven Neumann
8f3ea939a8 improved PDB blurb and help. Very loosely based on a patch attached to bug
2004-09-10  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/xpm.c: improved PDB blurb and help. Very loosely
	based on a patch attached to bug #151912.
2004-09-10 12:05:00 +00:00
Sven Neumann
b6cc80e154 tools/pdbgen/pdb/drawable.pdb corrected documentation for
2004-09-10  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/drawable.pdb
	* tools/pdbgen/pdb/image.pdb: corrected documentation for
	_gimp_drawable_thumbnail() and _gimp_image_thumbnail().

	* app/pdb/drawable_cmds.c
	* app/pdb/image_cmds.c
	* libgimp/gimpdrawable_pdb.c
	* libgimp/gimpimage_pdb.c: regenerated.

	* libgimp/gimpdrawablepreview.c (gimp_drawable_preview_draw_thumb):
	also handle GRAY and GRAYA thumbnails.
2004-09-10 09:30:06 +00:00
Sven Neumann
6a824465f5 fixed positioning of the navigation marker and handling of motion events.
2004-09-10  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppreview.c: fixed positioning of the
	navigation marker and handling of motion events.
2004-09-10 09:02:19 +00:00
Sven Neumann
e9d5536720 libgimpwidgets/gimppreview.c documented new functions.
2004-09-10  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppreview.c
	* libgimpwidgets/gimppreviewarea.c: documented new functions.
2004-09-09 22:36:15 +00:00
Sven Neumann
025e58a12d libgimp/gimpdrawablepreview.c added a navigation popup similar to the one
2004-09-09  Sven Neumann  <sven@gimp.org>

	* libgimp/gimpdrawablepreview.c
	* libgimpwidgets/gimppreview.[ch]: added a navigation popup
	similar to the one in the image window. Needs some more work.
2004-09-09 21:36:52 +00:00
David Odin
3f099b0660 added a utility function gimp_preview_area_queue_draw(), which queue the
* libgimpwidgets/gimppreviewarea.c: added a utility function
  gimp_preview_area_queue_draw(), which queue the right part of the
  preview to be redrawn. And use it in all the drawing functions. This
  fix a problem where the preview wasn't updated correctly after a
  resize.
2004-09-09 17:11:16 +00:00
Michael Natterer
094909cd8a plug-ins/common/cartoon.c plug-ins/common/despeckle.c
2004-09-09  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/cartoon.c
	* plug-ins/common/despeckle.c
	* plug-ins/common/gauss.c
	* plug-ins/common/grid.c
	* plug-ins/common/neon.c
	* plug-ins/common/noisify.c
	* plug-ins/common/photocopy.c
	* plug-ins/common/sel_gauss.c
	* plug-ins/common/sharpen.c
	* plug-ins/common/sobel.c
	* plug-ins/common/softglow.c
	* plug-ins/common/spread.c
	* plug-ins/common/struc.c
	* plug-ins/common/unsharp.c: pack all drawable previews expanding.
	Also did some general cleanups like consistently naming the dialog
	variable "dialog" and the main vbox "main_vbox".
2004-09-09 16:08:56 +00:00
Sven Neumann
b3c30779a0 right-align the preview for RTL layouts.
2004-09-09  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppreview.[ch]: right-align the preview for RTL
	layouts.
2004-09-09 15:27:34 +00:00
Sven Neumann
a514ce7db1 allow to set a maximum size and center the preview area if its allocation
2004-09-09  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppreviewarea.[ch]: allow to set a maximum size
	and center the preview area if its allocation extends the maximum.

	* libgimpwidgets/gimppreview.[ch]: derive from GtkVBox, moved the
	toggle button out of the table and put the table into an aspect
	frame. Added an API to set the preview boundaries. Set the maximum
	size of the GimpPreviewArea from that function.

	* libgimpwidgets/gimpwidgets.def: added new entries.

	* libgimp/gimpdrawablepreview.c: use gimp_preview_set_bounds().

	* plug-ins/common/gauss.c: pack the preview widget so that it
	resizes with the dialog.
2004-09-09 14:47:39 +00:00
David Odin
824b5289db optimized the case where both buffers have the same alpha for a given
* libgimpwidgets/gimppreviewarea.c (gimp_preview_area_blend)
  (gimp_preview_area_mask): optimized the case where both buffers have
  the same alpha for a given pixel.
2004-09-09 13:22:27 +00:00
Michael Natterer
fa3f37e96e app/widgets/gimpviewrendererbrush.c app/widgets/gimpviewrendererdrawable.c
2004-09-09  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpviewrendererbrush.c
	* app/widgets/gimpviewrendererdrawable.c
	* app/widgets/gimpviewrenderergradient.c
	* app/widgets/gimpviewrendererimage.c
	* app/widgets/gimpviewrendererimagefile.c
	* app/widgets/gimpviewrendererlayer.c
	* app/widgets/gimpviewrenderervectors.c: purely cosmetic cleanup.
2004-09-09 11:58:49 +00:00
Michael Natterer
d7fc14fbc8 use g_type_name(dialog_type) instead of just "pdb dialog" as name for the
2004-09-09  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimppdbdialog.c (gimp_pdb_dialog_constructor): use
	g_type_name(dialog_type) instead of just "pdb dialog" as name for
	the dialog's private context.
2004-09-09 11:48:45 +00:00
Michael Natterer
09536dbf37 changed GimpDisplay* parameter to GimpProgress* because that's what it's
2004-09-09  Michael Natterer  <mitch@gimp.org>

	* app/gui/convert-dialog.[ch] (convert_dialog_new): changed
	GimpDisplay* parameter to GimpProgress* because that's what it's
	used for.

	* app/actions/image-commands.c (image_convert_cmd_callback):
	changed accordingly.

	* app/gui/convert-dialog.c: massively cleaned up internals. Use a
	GimpViewableButton + GimpContainerEntry combo as in text options
	for selecting the custom palette. Use a filtered container which
	contains only palettes with a maximum of 256 colors.
	Fixes bug #136574
2004-09-09 11:42:39 +00:00
Michael Natterer
ff6ee61780 changed file_open_location_dialog_show() to
2004-09-09  Michael Natterer  <mitch@gimp.org>

	* app/gui/file-open-location-dialog.[ch]: changed
	file_open_location_dialog_show() to
	file_open_location_dialog_new() and return the dialog.

	* app/gui/dialogs.c
	* app/gui/dialogs-constructors.[ch]: added a constructor for it
	and let the dialog factory manage it entirely.

	* app/actions/file-commands.c
	(file_open_location_dialog_cmd_callback): use the dialog factory
	to create it.
2004-09-09 09:47:33 +00:00
Michael Natterer
abf395c0cd renamed parameter "gboolean raise_if_found" to "return_existing" and added
2004-09-09  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpdialogfactory.c
	(gimp_dialog_factory_dialog_new_internal): renamed parameter
	"gboolean raise_if_found" to "return_existing" and added
	additional parameter "gboolean present".

	(gimp_dialog_factory_dialog_new)
	(gimp_dialog_factory_dialog_raise)
	(gimp_dialog_factory_dockable_new): pass both parameters (passing
	"present" as "raise_if_found" was not quite correct).
2004-09-09 09:02:26 +00:00
David Odin
ee2e6eac86 fixed a stupid typo.
* libgimpwidgets/gimppreviewarea.c: fixed a stupid typo.
2004-09-08 14:51:02 +00:00
Sven Neumann
7f075c87d8 optimized solid color fills.
2004-09-08  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppreviewarea.c (gimp_preview_area_fill):
	optimized solid color fills.
2004-09-08 12:54:36 +00:00
Sven Neumann
1a9fdcda80 factored out common code. Reduced indentation level by closing a switch
2004-09-08  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppreviewarea.c: factored out common code.
	Reduced indentation level by closing a switch earlier.
2004-09-08 12:37:09 +00:00
David Odin
c59a6de934 use gimp_preview_area_draw when the opacity is 0 or 255, instead of
*  libgimpwidgets/gimppreviewarea.c: (gimp_preview_area_blend)
  use gimp_preview_area_draw when the opacity is 0 or 255, instead of
  duplicating code.
2004-09-08 11:52:05 +00:00
Sven Neumann
099458184b added new entries.
2004-09-07  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpwidgets.def: added new entries.

2004-09-07  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/libgimpwidgets-sections.txt
	* devel-docs/libgimpwidgets/tmpl/gimppreviewarea.sgml: added new
	GimpPreviewArea functions.
2004-09-07 21:58:56 +00:00
Sven Neumann
0a57c5815e fit output into 80 columns.
2004-09-07  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/test-preview-area.c: fit output into 80 columns.
2004-09-07 21:33:11 +00:00
Sven Neumann
585d35c748 some code cleanup.
2004-09-07  Sven Neumann  <sven@gimp.org>

	* libgimp/gimpdrawablepreview.c (gimp_drawable_preview_draw): some
	code cleanup.
2004-09-07 21:14:06 +00:00
David Odin
3568671242 added some tests for gimp_preview_area_blend() and
* libgimpwidgets/test-preview-area.c: added some tests for
  gimp_preview_area_blend() and gimp_preview_area_mask().
2004-09-07 21:04:07 +00:00
David Odin
e733ca0930 libgimpwidgets/gimppreviewarea.c added two functions:
* libgimpwidgets/gimppreviewarea.c
* libgimpwidgets/gimppreviewarea.h: added two functions:
  gimp_preview_area_blend() to draw the blending of two buffers with
  an opacity parameter, and gimp_preview_area_mask() to draw the
  blending of two buffers, with a mask buffer. The code still needs some
  polish, though.

* libgimp/gimpdrawablepreview.c
* libgimp/gimpdrawablepreview.h: use gimp_preview_area_mask() in
  gimp_drawable_preview_draw(), so the previews are now much more
  accurate (respecting the selection, if any).

Also made the buf parameter of gimp_drawable_preview_draw() a pointer
to constants.
2004-09-07 20:20:13 +00:00
Michael Natterer
567385a150 #define the constant crosshair size for the INTERSECTION grid style
2004-09-07  Michael Natterer  <mitch@gimp.org>

	* app/display/gimpdisplayshell-draw.c
	(gimp_display_shell_draw_grid): #define the constant crosshair
	size for the INTERSECTION grid style instead of using an eeky
	"const gint".
2004-09-07 19:08:55 +00:00
Michael Natterer
19d523f6c7 added a foreign entry "gimp-file-open-loaction-dialog".
2004-09-07  Michael Natterer  <mitch@gimp.org>

	* app/gui/dialogs.c (toplevel_entries): added a foreign entry
	"gimp-file-open-loaction-dialog".

	* app/gui/file-open-location-dialog.c: register the dialog
	with the toplevel dialog factory so it remembers its position.
2004-09-07 17:37:35 +00:00
Michael Natterer
5f67c6f216 app/actions/context-actions.c applied a heavily modified patch from David
2004-09-07  Michael Natterer  <mitch@gimp.org>

	* app/actions/context-actions.c
	* app/actions/context-commands.[ch]: applied a heavily modified
	patch from David Gowers which adds actions to modify the context's
	paint_mode. Fixes bug #151471.

	* menus/image-menu.xml.in: added them to the (commentd out)
	"Context" submenu.
2004-09-07 12:47:35 +00:00
Michael Natterer
a2a6572519 indentation and whitespace cleanup.
2004-09-07  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/edge.c: indentation and whitespace cleanup.

	* plug-ins/common/struc.c: minor coding style issues.
2004-09-07 12:13:29 +00:00
Michael Natterer
6d86a4da42 applied patch from Alan Horkan which improves the blurb and help texts.
2004-09-07  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/xwd.c (query): applied patch from Alan Horkan
	which improves the blurb and help texts. Fixes bug #151912.

	Unrelated: did coding style / indentation cleanup in the whole file.
2004-09-07 12:08:03 +00:00
Michael Natterer
d8a3c0c08c simplified the code that selects an image file by its URI.
2004-09-07  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpfiledialog.c (gimp_file_dialog_set_uri):
	simplified the code that selects an image file by its URI.
2004-09-07 10:45:36 +00:00
Simon Budig
20504d16a9 Added an indicator for generated brushes. Pretty straightforward,
2004-09-07  Simon Budig  <simon@gimp.org>

	* app/widgets/gimpviewrendererbrush.c: Added an indicator for
	generated brushes. Pretty straightforward, suggestions for
	improvements are welcome.
2004-09-06 23:55:24 +00:00
David Odin
e1673aa84d added a preview.
* plug-ins/common/struc.c: added a preview.
2004-09-06 20:12:32 +00:00
Simon Budig
f7e4e55d1d reordered info_dialog_hide() and crop_tool_crop_image(), which avoids the
2004-09-06  Simon Budig  <simon@gimp.org>

	* app/tools/gimpcroptool.c: reordered info_dialog_hide() and
	crop_tool_crop_image(), which avoids the repeated popping up
	of the info dialog and avoids a crash.

	Fixes bug #151712
2004-09-05 23:42:30 +00:00
David Odin
d44e08aed7 use gimp_preview_invalidate() where appropriate.
* plug-ins/common/cartoon.c: use gimp_preview_invalidate() where
  appropriate.

* plug-ins/common/photocopy.c: Added a preview.
2004-09-05 21:54:34 +00:00
Sven Neumann
4bfbd2c5c3 bumped version number to 2.1.5.
2004-09-05  Sven Neumann  <sven@gimp.org>

	* configure.in: bumped version number to 2.1.5.

	* app/widgets/gimpfiledialog.c (gimp_file_dialog_set_uri): select
	the image file, not only the folder it lives in. Fixes bug #151638.
2004-09-05 20:17:53 +00:00
David Odin
7cc418aab4 Added a preview.
* plug-ins/common/cartoon.c: Added a preview.
2004-09-05 19:59:12 +00:00
Simon Budig
096e059a00 fix handling of layers with an offset. Resize the image before cropping
2004-09-05  Simon Budig  <simon@gimp.org>

	* plug-ins/common/autocrop.c: fix handling of layers with an
	offset. Resize the image before cropping when the covered area
	of a layer is partially outside the image area. Make math more
	comprehensible.
2004-09-05 15:06:53 +00:00