which always returns a profile, instead of code that uses the ICC
blob and falls back to GimpColorConfig's profile, then falls back
to the built-in profiles.
If the passed dialog is a GimpColorProfileChooserDialog, handle its
"response" signal automatically and also destroy it when the combo box
is destroyed (before we leaked all dialogs). Remove the same callback
from all places using GimpColorProfileComboBox.
and improve gimp_color_profile_combo_box_set_active() to get the
profile's label from the ICC file if no label was provided. Simplifies
all its callers and removes code duplication.
which returns a string meant to label the profile in the GUI, it's
either the profile's description, its model, or "(unnamed profile)" as
a fallback. Use the function instead of duplicating that logic
inconsistently and imcompletely all over the place.
Add functions to get a profile's description, manufacturer, model and
copyright, and use them instead of implementing the same 10 times.
Also add a GimpColorProfile typedef which avoids both having to
include lcms globally or using a gpointer instead (which looks bad and
non-descriptive in an API).
So it works with all GObject versions, until we determine how useful
it is generally, and what API it should get for possible
libgimpwidgets inclusion.
Swallow GtkHSV back into GIMP and call it GimpColorWheel. Keep it in
modules/ for the time being. Clean up and undeprecate it. Replace
set_metrics() API by set_ring_fraction() and make it follow the size
of its parent container, making its use straightforward. Kept it clean
of GIMP color types so it can be easily adapted by e.g. Inkscape.
This symbol is not available to 64-bit applications. So put another
approach in place.
I can confirm that the code does not crash, but I do not know if it
works properly. Mitch forced me to push anyway.
Don't call gimp_input_device_store_lookup() with a NULL name. Unplug
seems broken because we always get name == NULL, I need to fix this
but at least it doesn't crash any longer (and the fix is generally
correct and not a workaround).
Create and use Cairo-compatible API for display filters. Also
includes logic changes to the display filters to deal with cairo's
ARGB32 pre-multiplied buffer format.
When a color gets set on the module via GimpColorSelector::set_color(),
make sure that the result of its transformation to CMYK doesn't
get set back on GIMP. Also, when the color profile changes, make
sure we only re-transform the RGB value to CMYK and don't set that
result back on GIMP either.
2009-03-22 Michael Natterer <mitch@gimp.org>
* modules/color-selector-wheel.c: remove GTK+ version check and
related evilness because we depend on a proper GKT+ version now.
svn path=/trunk/; revision=28195
2009-01-17 Michael Natterer <mitch@gimp.org>
* all files with a GPL header and all COPYING files:
Change licence to GPLv3 (and to LGPLv3 for libgimp).
Cleaned up some copyright headers and regenerated the parsers in
the ImageMap plugin.
svn path=/trunk/; revision=27913
2008-09-25 Michael Natterer <mitch@gimp.org>
Bug 553530 – fatal error: Segmentation fault - when attempting to
bring up color-picker:
* modules/color-selector-wheel.c: declare gtk_hsv_get_type() if
not already done by GTK+. Fixes confusion about its return value
being 32 or 64 bit on 64 bit machines.
svn path=/trunk/; revision=27054
2008-09-25 Michael Natterer <mitch@gimp.org>
Bug 549195 – Color Wheel not working (GtkHSV):
* modules/color-selector-wheel.c: change packing and size requests
of the GtkHSV and its optional GtkAligmnent depending on the GTK+
version used to make it work with both the old and the new version
of the widget. Evil hacks, better don't look :)
svn path=/trunk/; revision=27053
2008-09-03 Michael Natterer <mitch@gimp.org>
* app/display/gimpdisplayshell-callbacks.c
* libgimpwidgets/gimpcolorselect.c
* modules/color-selector-water.c
* plug-ins/ifs-compose/ifs-compose.c: instead of using
gdk_window_get_pointer() if GdkEventMotion::is_hint is TRUE,
simply always use the coords from the event and call
gdk_event_request_motions() to ask for more motion events. This is
the recommended way and also works for events from devices other
than the core pointer.
* plug-ins/ifs-compose/ifs-compose.c (design_area_motion): some
code cleanup while i was at it.
svn path=/trunk/; revision=26843
2008-08-12 Michael Natterer <mitch@gimp.org>
* modules/color-selector-wheel.c: override the wheel's
size-allocate and return a small requisition that allows to be
resized smaller again.
svn path=/trunk/; revision=26511
2008-08-11 Michael Natterer <mitch@gimp.org>
* modules/Makefile.am
* modules/*.c: renamed all modules to color-selector-foo.c,
display-filter-foo.c and controller-foo.c
svn path=/trunk/; revision=26506
2008-08-11 Michael Natterer <mitch@gimp.org>
* configure.in: check for lcms with PKG_CHECK_MODULES(). Remove
check for <lcms.h> vs. <lsmc/lsmc.h> because the pc file should
give us the right location now.
* modules/cdisplay_lcms.c
* modules/cdisplay_proof.c
* modules/colorsel_cmyk_lcms.c
* plug-ins/file-jpeg/jpeg-load.c
* plug-ins/common/lcms.c: #include <lcms.h> and nothing else.
* modules/Makefile.am
* plug-ins/file-jpeg/Makefile.am
* plug-ins/common/plugin-defs.pl: add LCMS_CFLAGS where appropriate.
* plug-ins/common/Makefile.am: regenerated.
svn path=/trunk/; revision=26503
2008-08-11 Michael Natterer <mitch@gimp.org>
* configure.in: change all LIBFOO variables to FOO_LIBS for
consistency, could get rid of some variables alltogether since
PNG_CHECK_MODULES() already defined FOO_LIBS.
* tools/Makefile.am
* modules/Makefile.am
* plug-ins/file-ico/Makefile.am
* plug-ins/file-jpeg/Makefile.am
* plug-ins/file-psd/Makefile.am
* plug-ins/file-xjt/Makefile.am
* plug-ins/common/plugin-defs.pl
* plug-ins/common/mkgen.pl: changed accordingly.
* plug-ins/common/Makefile.am: regenerated.
svn path=/trunk/; revision=26498
2008-08-08 Michael Natterer <mitch@gimp.org>
* modules/colorsel_triangle.c: removed.
* modules/colorsel_wheel.c: new module using the GtkHSV widget
which was originally developed from above triangle selector.
* modules/Makefile.am: chaged accordingly.
svn path=/trunk/; revision=26448
2008-06-12 Michael Natterer <mitch@gimp.org>
* modules/controller_midi.c: applied patch from S. Fielding which
passes the right MIDI channel from the ALSA event to midi_event().
Fixes bug #537960.
svn path=/trunk/; revision=25931
