Commit graph

1944 commits

Author SHA1 Message Date
Michael Natterer
35f0511f0c added an "Auto" button and initialize the tool with a default threshold of
2006-04-25  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpthresholdtool.c: added an "Auto" button and
	initialize the tool with a default threshold of 127 again.
	Removed some cruft and did some cleanup.
2006-04-25 18:02:30 +00:00
Sven Neumann
6a4981c82a Applied a slightly modified version of a patch from Lode Leroy (bug
2006-04-21  Sven Neumann  <sven@gimp.org>

	Applied a slightly modified version of a patch from Lode Leroy
	(bug #336183):

	* app/base/gimphistogram.[ch]: added new function
	gimp_histogram_get_threshold() that returns an optimal
	binarization threshold.

	* app/tools/gimpthresholdtool.c: use the new function to
	initialize the Threshold tool.
2006-04-21 09:40:27 +00:00
Sven Neumann
60e3301802 M ChangeLog M app/paint/gimpconvolve.c M app/paint-funcs/paint-funcs.c M
M ChangeLog
M app/paint/gimpconvolve.c
M app/paint-funcs/paint-funcs.c
M app/paint-funcs/paint-funcs.h
M app/tools/gimpiscissorstool.c
M libgimpbase/gimputils.c
M modules/colorsel_cmyk.c
M regexrepl/regex.c
2006-04-20 07:15:15 +00:00
Karine Delvare
3a8be5fa52 auto-convert rectangle to selection after creating or reiszing it.
2006-04-12  Karine Delvare  <edhel@gimp.org>

	* app/tools/gimpnewrectselecttool.c: auto-convert rectangle to
	selection after creating or reiszing it.
2006-04-12 18:34:43 +00:00
Sven Neumann
049872b361 app/*.[ch] converted tabs to spaces.
2006-04-12  Sven Neumann  <sven@gimp.org>

	* app/*.[ch]
	* app/*/*.[ch]: converted tabs to spaces.
2006-04-12 12:49:29 +00:00
Karine Delvare
440ee94145 center constraint with control key.
2006-04-08  Karine Delvare  <edhel@gimp.org>

	* app/tools/gimprectangletool.c: center constraint with control
	key.
2006-04-08 10:26:04 +00:00
Sven Neumann
cef9db57fe renamed gimp_drawable_data() to gimp_drawable_get_tiles().
2006-04-07  Sven Neumann  <sven@gimp.org>

	* app/core/gimpdrawable.[ch]: renamed gimp_drawable_data() to
	gimp_drawable_get_tiles().

	[lots of files]: changed accordingly.
2006-04-07 09:21:18 +00:00
Sven Neumann
a850005234 initialize "keep-aspect" to FALSE 2006-04-03 11:44:56 +00:00
Sven Neumann
4a8ee7f392 added a GimpSizeBox as a replacement for the InfoDialog widgets. Needs
2006-04-03  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpscaletool.c: added a GimpSizeBox as a replacement
	for the InfoDialog widgets. Needs more work ...
2006-04-03 07:50:06 +00:00
Karine Delvare
5e69f1fc12 square constraint with shift key.
2006-04-02  Karine Delvare  <edhel@gimp.org>

	* app/tools/gimprectangletool.c: square constraint with shift key.
2006-04-02 20:58:07 +00:00
Michael Natterer
4d4873a581 Silence compiler warnings about...
2006-04-02  Michael Natterer  <mitch@gimp.org>

	Silence compiler warnings about...

	* app/config/gimprc-unknown.c: ...unused return value of
	g_slist_concat().

	* app/tools/gimpdrawtool.c: ...uninitialized variabe.

	* app/xcf/xcf-save.c: ...pointer signedness.
2006-04-02 18:19:48 +00:00
Karine Delvare
a10a5713d7 don't automatically auto-shrink.
2006-04-01  Karine Delvare  <edhel@gimp.org>

	* app/tools/gimpnewrectselecttool.c: don't automatically
	auto-shrink.
2006-04-01 10:46:21 +00:00
Sven Neumann
9996bb7a2e app/dialogs/Makefile.am app/dialogs/dialogs-types.h app/dialogs/dialogs.c
2006-03-31  Sven Neumann  <sven@gimp.org>

	* app/dialogs/Makefile.am
	* app/dialogs/dialogs-types.h
	* app/dialogs/dialogs.c
	* app/dialogs/info-dialog.[ch]: good bye InfoDialog.

	* app/tools/gimpperspectivetool.[ch]
	* app/tools/gimprotatetool.[ch]
	* app/tools/gimpsheartool.[ch]
	* app/tools/gimptransformtool.[ch]: use GimpToolDialog instead of
	InfoDialog and add the widgets manually.

	* app/tools/gimpscaletool.c: commented out use of InfoDialog. This
	tools still needs to be ported to GimpToolDialog.
2006-03-31 13:36:34 +00:00
Sven Neumann
86fd6f9ccd did a global gdisp -> display substitution.
2006-03-28  Sven Neumann  <sven@gimp.org>

        * app/*: did a global gdisp -> display substitution.
2006-03-28 17:59:18 +00:00
Sven Neumann
5439aa4995 did a global gdisp -> display substitution.
2006-03-28  Sven Neumann  <sven@gimp.org>

	* app/*: did a global gdisp -> display substitution.
2006-03-28 17:55:52 +00:00
Sven Neumann
905fdfcbed did a global gimage -> image substitution.
2006-03-28  Sven Neumann  <sven@gimp.org>

	* app/*: did a global gimage -> image substitution.
2006-03-28 17:08:36 +00:00
Sven Neumann
2c2e542e2a app/tools/gimpforegroundselectoptions.c use Ctrl to switch between
2006-03-27  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpforegroundselectoptions.c
	* app/tools/gimpforegroundselecttool.c: use Ctrl to switch between
	foreground and background refinement.
2006-03-27 18:35:42 +00:00
Karine Delvare
601e45ea5a allow modifier keys to work.
2006-03-27  Karine Delvare  <edhel@gimp.org>

	* app/tools/gimpnewrectselecttool.c: allow modifier keys to work.
2006-03-27 17:58:11 +00:00
Karine Delvare
c82adc2231 app/tools/gimpcropoptions.c app/tools/gimprectangleoptions.[ch] moved
2006-03-26  Karine Delvare  <edhel@gimp.org>

	* app/tools/gimpcropoptions.c
	* app/tools/gimprectangleoptions.[ch]
	* app/tools/gimprectangletool.[ch]: moved options gui creation
	from the tool to the options.

	* app/tools/gimpselectionoptions.c
	* app/tools/gimpnewrectselecttool.[ch]
	* app/tools/gimpellipseselecttool.[ch]: ported ellipse selection
	tool to the new rectangle interface.
2006-03-26 13:50:13 +00:00
Michael Natterer
2ed407b54f app/tools/gimptool.[ch] add "gboolean proximity" parameter to
2006-03-25  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimptool.[ch]
	* app/tools/tool_manager.[ch]: add "gboolean proximity" parameter
	to GimpTool::oper_update() in order to emphasize its importance
	and to avoid peeking around in the GimpDisplayShell struct.

	* app/tools/gimpbycolorselecttool.c
	* app/tools/gimpclonetool.c
	* app/tools/gimpcolorpickertool.c
	* app/tools/gimpcolortool.c
	* app/tools/gimpcurvestool.c
	* app/tools/gimpforegroundselecttool.c
	* app/tools/gimpiscissorstool.c
	* app/tools/gimpmovetool.c
	* app/tools/gimpnewrectselecttool.c
	* app/tools/gimppainttool.c
	* app/tools/gimprectangletool.[ch]
	* app/tools/gimpselectiontool.c
	* app/tools/gimptransformtool.c
	* app/tools/gimpvectortool.c: changed accordingly. Got rid of
	quite some "display/gimpdisplayshell.h" includes.

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_canvas_tool_events): pass shell->proximity to
	tool_manager_oper_update_active().
2006-03-25 14:23:09 +00:00
Michael Natterer
0e7a40face app/tools/gimpclonetool.c app/tools/gimpcurvestool.c
2006-03-25  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimpclonetool.c
	* app/tools/gimpcurvestool.c
	* app/tools/gimpforegroundselecttool.c
	* app/tools/gimpselectiontool.c
	* app/tools/gimpvectortool.c (GimpTool::oper_update): don't push
	status messages when shell->proximity is FALSE. Make sure the old
	status message gets popped regardless of shell->proximity's
	value. Fixes stuck status bar messages.
2006-03-25 13:51:13 +00:00
Karine Delvare
8362c190a4 react to highlight notification. Fixes bug #335652.
2006-03-25  Karine Delvare  <edhel@gimp.org>

	* app/tools/gimprectangletool.c: react to highlight notification.
	Fixes bug #335652.
2006-03-25 09:38:59 +00:00
Sven Neumann
d65622407a renamed from "Rect Select" to "Rectangle Select" (bug #335715).
2006-03-24  Sven Neumann  <sven@gimp.org>

        * app/tools/gimprectselecttool.c: renamed from "Rect Select" to
        "Rectangle Select" (bug #335715).

        * app/core/gimpchannel-select.c (gimp_channel_select_rectangle):
        string change (bug #335715).

        * plug-ins/common/svg.c: follow the change to the file format
        label done in the shared-mime-info package (bug #335716).

        * configure.in: fixed the --without-libtiff case in the summary
        (bug #335764).
2006-03-24 08:15:01 +00:00
Karine Delvare
eec8acf6c9 removed properties that are rather internal states.
2006-03-21  Karine Delvare  <kdelvare@nerim.net>

	* app/tools/gimprectangletool.c: removed properties that are
	rather internal states.
2006-03-21 19:40:32 +00:00
Karine Delvare
85acd1410f app/tools/gimpnewrectselecttool.c app/tools/gimprectangleoptions.[ch] hide
2006-03-21  Karine Delvare  <kdelvare@nerim.net>

	* app/tools/gimpnewrectselecttool.c
	* app/tools/gimprectangleoptions.[ch]
	* app/tools/gimprectangletool.[ch]: hide properties accessors.
2006-03-21 17:37:24 +00:00
Karine Delvare
1cf09eaca3 use GIMP_RECTANGLE_OPTIONS_PROP_LAST instead of duplicating properties.
2006-03-21  Karine Delvare  <kdelvare@nerim.net>

	* app/tools/gimpcropoptions.c: use GIMP_RECTANGLE_OPTIONS_PROP_LAST
	instead of duplicating properties.
2006-03-21 17:13:56 +00:00
Sven Neumann
ac777da954 app/display/gimpdisplayshell-render.c app/display/gimpdisplayshell.[ch]
2006-03-17  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell-render.c
	* app/display/gimpdisplayshell.[ch]
	* app/tools/gimpforegroundselectoptions.[ch]
	* app/tools/gimpforegroundselecttool.c: allow to use red, green or
	blue for the selection preview used by the foreground selection tool.
2006-03-17 13:27:08 +00:00
Michael Natterer
b55ce9ea2d added new methods ::get_bytes() and ::flush()
2006-03-02  Michael Natterer  <mitch@gimp.org>

	* app/core/gimppickable.[ch]: added new methods ::get_bytes() and
	::flush()

	* app/core/gimpchannel.c
	* app/core/gimpdrawable.c
	* app/core/gimpimagemap.c
	* app/core/gimpprojection.c: implement ::get_bytes()

	* app/core/gimpprojection.c: implement ::flush() (immediately
	process both the idle renderer's queue and the unflushed update
	areas, to make sure that any reading from the projection will
	re-construct it).

	* app/core/gimp-edit.c
	* app/core/gimpchannel.c
	* app/core/gimpimage-contiguous-region.c
	* app/core/gimpimage-crop.c
	* app/core/gimppalette-import.c
	* app/paint/gimpclone.c
	* app/tools/gimpbycolorselecttool.c
	* app/tools/gimpiscissorstool.c
	* tools/pdbgen/pdb/image.pdb: use the pickable interface more
	consistently when reading from any drawable or the projection, and
	call gimp_pickable_flush() before doing so. Fixes bug #332933.

	* app/core/gimpimage-pick-color.c: added comment why the we don't
	call gimp_pickable_flush() here.

	* app/pdb/image_cmds.c
	* libgimp/gimpimage_pdb.c: regenerated.
2006-03-02 19:30:59 +00:00
Sven Neumann
5e7ce540c1 app/core/gimpbrush.c app/core/gimpbuffer.c app/core/gimpimagefile.c
2006-02-28  Sven Neumann  <sven@gimp.org>

	* app/core/gimpbrush.c
	* app/core/gimpbuffer.c
	* app/core/gimpimagefile.c
	* app/core/gimppattern.c
	* app/dialogs/preferences-dialog.c
	* app/tools/gimpmeasuretool.c
	* app/tools/gimprectangletool.c
	* app/tools/gimprectselecttool.c
	* app/widgets/gimpimagepropview.c
	* app/widgets/gimpsizebox.c
	* app/widgets/gimptemplateeditor.c
	* plug-ins/imagemap/imap_statusbar.c: use U+00D7 MULTIPLICATION SIGN
	instead of x when displaying sizes.
2006-02-28 12:15:51 +00:00
Karine Delvare
b6d61922f6 zero division check should be changed according to the aspect redefinition
2006-02-20  Karine Delvare  <kdelvare@nerim.net>

	* app/tools/gimprectangletool.c: zero division check should be
	changed according to the aspect redefinition
2006-02-20 18:35:01 +00:00
Simon Budig
bfdcee3e21 allow maximum jitter of 5.0.
2006-02-20  Simon Budig  <simon@gimp.org>

	* app/tools/gimppaintoptions-gui.c: allow maximum jitter of 5.0.
2006-02-20 17:25:53 +00:00
Sven Neumann
fd02e97a4f renamed to Zoom tool.
2006-02-20  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpmagnifytool.c: renamed to Zoom tool.

	* menus/image-menu.xml.in: changed accordingly.
2006-02-20 12:49:46 +00:00
Sven Neumann
3b8578942d do not unset focus-on-map for all tool dialogs.
2006-02-15  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimptooldialog.c: do not unset focus-on-map for all
	tool dialogs.

	* app/tools/gimpcolorpickertool.c
	* app/tools/gimpmeasuretool.c: explicitely do it here instead.
2006-02-15 14:48:40 +00:00
Sven Neumann
07eac03044 Added some tool shortcuts:
2006-02-14  Sven Neumann  <sven@gimp.org>

	Added some tool shortcuts:

	* app/tools/gimpcroptool.c: Shift+C
	* app/tools/gimpfuzzyselecttool.c: changed from Z to U.
	* app/tools/gimpmagnifytool.c: Z.
	* app/tools/gimpmeasuretool.c: Shift+M.
2006-02-14 11:43:54 +00:00
Sven Neumann
034a4284d1 use canonical property names.
2006-02-07  Sven Neumann  <sven@gimp.org>

	* app/tools/gimpimagemaptool.c: use canonical property names.
2006-02-07 20:04:08 +00:00
Sven Neumann
d6762ee166 applied a patch from Dennis Bjorklund that prevents a possible division by
2006-02-07  Sven Neumann  <sven@gimp.org>

	* app/tools/gimprectangletool.c: applied a patch from Dennis
	Bjorklund that prevents a possible division by zero and fixes the
	calculation of the center point.
2006-02-07 11:38:17 +00:00
Carol Spears
81f0d1230c app/tools/gimprectangletool.c: Applied patch from Joao S. O. Bueno Calligaris
that corrects status bar coordinate display
2006-02-04 05:37:20 +00:00
Karine Delvare
41b9f5af52 aspect ratio should be width / height.
2006-02-03  Karine Delvare  <kdelvare@nerim.net>

	* app/tools/gimprectangletool.c: aspect ratio should be width /
	height.
2006-02-03 19:29:11 +00:00
Sven Neumann
21ff206f9c manually add the icons to the color picker buttons instead of abusing the
2006-01-31  Sven Neumann  <sven@gimp.org>

	* app/tools/gimplevelstool.c (gimp_levels_tool_color_picker_new):
	manually add the icons to the color picker buttons instead of
	abusing the stock-id property. Fixes bug #325745.
2006-01-31 15:04:37 +00:00
Michael Schumacher
8fa7568565 use the closest corner of the current pixel as origin. Fixes bug #329000.
2006-01-30  Michael Schumacher  <schumaml@cvs.gnome.org>

	* app/tools/gimpmeasuretool.c: use the closest corner of the
	current pixel as origin. Fixes bug #329000.
2006-01-30 20:12:19 +00:00
Karine Delvare
202539a47c app/tools/gimpcroptool.c app/tools/gimpnewrectselecttool.c
2006-01-21  Karine Delvare  <kdelvare@nerim.net>

	* app/tools/gimpcroptool.c
	* app/tools/gimpnewrectselecttool.c
	* app/tools/gimprectangleoptions.c
	* app/tools/gimprectangletool.c: indentation fixes.
2006-01-21 18:20:26 +00:00
Michael Natterer
8c35465cdb don't call g_free() on a widget pointer. Fixes bug #327639.
2006-01-19  Michael Natterer  <mitch@gimp.org>

	* app/tools/gimprectangletool.c (gimp_rectangle_tool_dispose):
	don't call g_free() on a widget pointer. Fixes bug #327639.
2006-01-19 17:45:22 +00:00
Michael Natterer
e1ceed5147 define GIMP_PARAM_STATIC_STRINGS which is G_PARAM_STATIC_NAME|NICK|BLURB.
2006-01-18  Michael Natterer  <mitch@gimp.org>

	* app/config/config-types.c: define GIMP_PARAM_STATIC_STRINGS
	which is G_PARAM_STATIC_NAME|NICK|BLURB. Also define
	GIMP_PARAM_READABLE, _WRITABLE and _READWRITE which include
	GIMP_PARAM_STATIC_STRINGS.

	* app/*/*.c: use them for all object properties so their
	strings are not copied.
2006-01-18 20:29:40 +00:00
Michael Natterer
5d8b25a27d variant of gimp_config_connect() which allows the connected objects to
2006-01-14  Michael Natterer  <mitch@gimp.org>

	* app/config/gimpconfig-utils.[ch] (gimp_config_connect_full):
	variant of gimp_config_connect() which allows the connected
	objects to have different propertynames.

	* app/widgets/widgets-enums.[ch]: removed enum GimpViewType...

	* app/core/core-enums.[ch]: ...and added it here.

	* app/widgets/gimpviewablebutton.[ch] (gimp_viewable_button_new):
	added "button_preview_size" parameter so the button and popup
	preview sizes can be specified separately.

	* app/widgets/gimptemplateeditor.c: changed accordingly.

	* app/widgets/gimpviewablebox.[ch] (gimp_prop_*_box_new):
	new functions which take additional "view_type_prop" and
	"view_size_prop" parameters and sync the passed context's
	properties with the resp. properties of the viewable button.

	* app/paint/gimppaintoptions.[ch]
	* app/tools/gimpbucketfilloptions.c
	* app/tools/gimpclonetool.c
	* app/tools/gimppaintoptions-gui.c
	* app/tools/gimptextoptions.[ch]: added view-type and view-size
	properties to the options objects and use the new viewable box
	constructors so the selected view types and sizes are persistant
	across sessions. Fixes bug #315443.
2006-01-14 00:09:22 +00:00
Michael Natterer
55cc42339b implement GtkWidget::hide() and set the the focus widget to NULL, so a
2006-01-07  Michael Natterer  <mitch@gimp.org>

	* libgimpwidgets/gimpdialog.c: implement GtkWidget::hide() and set
	the the focus widget to NULL, so a focussed entry emits focus_out
	and its callbacks are invoked immediately (before the call to
	gtk_widget_hide() returns). Fixes crashes and warnings in tool
	dialogs when hitting escape while a spinbutton is being edited.

	* app/tools/gimptransformtool.c
	(gimp_transform_tool_force_expose_preview): return silently
	instead of warning when being called while the draw tool is not
	active (same scenario as above).
2006-01-07 17:47:24 +00:00
Michael Natterer
ef9b04c535 Fixed incomplete core/ui separation of paint tools and paint methods:
2005-12-27  Michael Natterer  <mitch@gimp.org>

	Fixed incomplete core/ui separation of paint tools and paint
	methods:

	* app/core/core-enums.h
	* app/core/gimpcontext.[ch]: added a "paint-info" property and API
	so the current paint method can be selected without the need for
	an active tool.

	(gimp_context_real_set_tool): set the paint-info to
	tool_info->paint_info so the paint method follows the active tool
	just as the active image follows the active display.

	* app/core/gimp.h (struct Gimp)
	* app/core/gimppaintinfo.[ch]: added "standard_paint_info" API
	and stuff to be consistent with other context object properties.

	* app/paint/gimp-paint.c: set the paintbrush as
	standard_paint_info.

	* app/core/gimpstrokedesc.c (gimp_stroke_desc_new): removed the
	hack of falling back to the paintbrush when there is no active
	tool and use the active paint method instead. Fall back to the
	standard paint method if there is no active one.
	(nothing in the core uses the active tool any more now).

	* app/widgets/gimpdeviceinfo.h: add the paint info to the
	properties which are saved in devicerc.

	Added identifiers (names) and stock-ids to GimpPaintInfo:

	* app/core/gimppaintinfo.[ch] (gimp_paint_info_new): added
	identifier and stock-id parameters.

	* app/core/gimptoolinfo.c (gimp_tool_info_new): removed the hack
	of setting the paint-info stock-id from the tool-info stock-id.

	* app/paint/paint-types.h
	* app/paint/gimp-paint.c: changed GimpPaintRegisterCallback
	accordingly.

	* app/tools/gimp-tools.c (gimp_tools_register): changed paint
	info names accordingly.

	* app/paint/*.c (gimp_*_register): pass identifier and stock-id
	accordingly.
2005-12-27 18:57:01 +00:00
Sven Neumann
6a0267b65e changed description of GIMP_CLONE_ALIGN_NO enum value.
2005-12-16  Sven Neumann  <sven@gimp.org>

	* app/paint/paint-enums.[ch]: changed description of
	GIMP_CLONE_ALIGN_NO enum value.

	* app/tools/gimpclonetool.c (gimp_clone_options_gui): use a combo
	box for the align mode.
2005-12-16 14:44:25 +00:00
Michael Natterer
8b8c784a5b port to G_DEFINE_TYPE() and friends. Some related cleanup.
2005-12-13  Michael Natterer  <mitch@gimp.org>

	* app/tools/*.c: port to G_DEFINE_TYPE() and friends. Some related
	cleanup.
2005-12-13 09:13:50 +00:00
William Skaggs
72a3574bba Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/tools/gimprectangletool.c: handle fixed_width,
	fixed_height, and fixed_aspect in a reasonable way.
	Also don't crash when user modifies aspect of a
	nonexistent rectangle, and disconnect notify
	handler in dispose.
2005-11-29 23:32:55 +00:00
William Skaggs
7a316db9e5 Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/tools/gimprectangletool.c: don't crash when
	user modifies width/height of nonexistent rectangle, and
	make sure to disconnect option notify handlers in dispose.
	Should fix bug #322396.
2005-11-28 22:30:24 +00:00