Commit graph

42393 commits

Author SHA1 Message Date
Michael Natterer
fe932fe7ad Bug 794826 - Do not default to last used filter settings
Add GimpGuiConfig::filter-tool-use-last-settings wchich defaults to FALSE.

Honor the new option in gimp_gegl_procedure_execute_async() and add
it to prefs -> dialog defaults.
2018-04-01 14:41:20 +02:00
Michael Natterer
14a054e980 app: add a "Filter Dialogs" section to prefs -> dialog defaults 2018-04-01 14:15:13 +02:00
Michael Natterer
62ec4831db app: ...and a mnemonic. 2018-04-01 14:01:14 +02:00
Michael Natterer
44ce8b4dd8 app: a colon was missing after "Debug Policy" in preferences
and it's "Debug policy" (capitalization).
2018-04-01 13:58:42 +02:00
Michael Natterer
f586aac43a app: use g_clear_foo() in gimp_gegl_procedure_finalize() 2018-04-01 13:54:47 +02:00
shark0r
e55c94eff0 Bug 794854 - Brush color is not added to color history in smudge tool
Add the color in gimp_smudge_paint(INIT) like GimpPaintbrush does.

Achieve this by calling gimp_palettes_add_color_history() directly,
not by inheriting GimpPaintbrush because GimpPaintbrush and GimpSmudge seem to share few common features.
2018-04-01 12:57:27 +02:00
Edward E
019af3dacb file-open-location: don't close dialog if no file was opened 2018-04-01 12:40:57 +02:00
Edward E
a4b366f494 file-open-location: disable widgets only while opening a file 2018-04-01 12:40:57 +02:00
Edward E
33b7d8e334 file-open-location: create only one progress bar 2018-04-01 12:40:57 +02:00
Ell
fd6d4931c8 It's alive! 2018-04-01 01:19:41 +00:00
Michael Natterer
a3071d2620 configure.ac: require babl >= 0.1.45 and GEGL => 0.3.31
and set gimp_version to "2.10.0-RC1-git" so we can distinguish it
from the RC1 tarball.
2018-03-31 18:39:53 +02:00
Jehan
04a798d786 app: do not copy needlessly paint_mask GimpTempBuf.
We are not doing any write operation on this mask data so copying all
the data just to read it and unreffing it in the end is only a cost on
performance.
See also bug 694917.
2018-03-31 16:54:53 +02:00
Ell
49285463e6 app: align projection update area to coarse grid
When adding a rectangle to a projection's update area, align the
rectangle to a coarse grid, to reduce the complexity of the overall
area.  We currently align the rectangle to a 32x32 grid, which
seems to be a good tradeoff between the overhead of processing a
complex area, and the overhead of processing a large area.
2018-03-31 08:19:18 -04:00
Michael Natterer
7be2d1457c app: use gimp_config_writer_string() to output the mypaint-brush-path
so it is properly escaped.
2018-03-31 11:28:12 +02:00
Massimo Valentini
2aa4426d4f app: improvements in code executed a lot while painting.
This keeps the same rectangle packing behaviour, so to behave exactly as
before for what concerns batching the updates, but should be lighter
when looping to find the first good rectangle to use.

In rtree_insert(), some conditions in the if tests are implied by
previous conditions. And therefore the 2 successive for loops are
actually identical.

In rtree_node_insert(), it is wrong/harmful to insert zero sized
rectangles in the tree because they can never be selected and just make
the list longer. So rtree_node_create() should just return NULL when w
or h are 0.

See bug 694917, comments 51 to 61.
2018-03-31 00:18:46 +02:00
Piotr Drąg
31086ae211 Update Polish translation 2018-03-30 22:00:14 +02:00
Michael Natterer
347acb16d3 desktop: add gimp-data-extras.metainfo.xml to .gitignore
and some cosmetic cleanup in Makefile.am
2018-03-30 15:53:19 +02:00
Michael Natterer
29d7cee100 configure.ac: add new option --enable-bundled-mypaint-brushes
because a simple platform dependency in gimpcoreconfig.c doesn't do
the trick (there can be both manual builds and bundled builds on
windows and macos). Use an AC_DEFINE() instead.

Also, make sure the system gimprc and its manpage are generated with
the correct values.
2018-03-30 14:41:13 +02:00
Michael Natterer
452b1bd558 Stop leaking properties of the distcheck machine into the tarball
Some gimprc properties' default values depend on the machine where
"make dist" in run. We had an ugly hack in place to force
(num-processors 1) in the installed system gimprc and its manpage, but
were still leaking "tile-cache-size" and "mypaint-brush-path".

The files are generated by the hidden options --dump-gimprc-system
and --dump-gimprc-manpage which exist only for this purpose.

In gimpconfig-dump.c, special case the three properties in
dump_gimprc_system() and dump_gimprc_manpage() to output constant
default values for "num-processors" and "tile-cache-size" and
output @mypaint_brushes_dir@ in "mypaint-brush-path" which can
be replaced at configure time.

Also introduce etc/gimprc.in so @mypaint_brushes_dir@ can actually be
substituted for the installed system gimprc.
2018-03-30 13:19:22 +02:00
Jehan
4698529dbe app: make MyPaint brushes path relative on Win32 and macOS.
Otherwise the brushes won't be found when bundling on macOS or with the
Windows installer. Build-time path from configuration is still used on
other platforms.
2018-03-29 22:22:51 +02:00
Jehan
8811e31419 app: cleaning out some if-0 variables. 2018-03-29 17:47:48 +02:00
Jehan
479bcaafdd configure, docs: set correct "mypaint-brush-path" value in man page.
This was hard-coded to what I guess was a personal prefix (commit
368c7c0511), which is obviously wrong. This has to be constructed at
compilation and the man must mirror whatever is the actual installation
path of mypaint-brushes package.
2018-03-29 17:26:23 +02:00
Jehan
5d83c7697e devel-docs: minor typo. 2018-03-29 17:26:23 +02:00
Michael Natterer
7c1ea0345e configure.ac: fix check for freetype2 2018-03-29 12:25:27 +02:00
Jordi Mas
dbb9fdb333 Update Catalan translation 2018-03-29 11:58:32 +02:00
Ell
53c145c0be app: add --show-debug-menu command-line option
The debug menu is currently not included in stable versions.

Include the menu unconditionally, but hide it, and its associated
actions, by default in stable versions.  Allow enabling the menu
using a new --show-debug-menu command-line option, in the same vein
as --show-playground.
2018-03-29 05:26:03 -04:00
Ell
c3efb1b0de app: don't show invisible actions in search dialog 2018-03-29 05:26:02 -04:00
Ell
3265797f3e Bug 794753 - do not dither image mask and channels for imported images
By the same logic of commit
44f293bcdb, we shouldn't dither the
alpha channel either.
2018-03-29 03:30:31 -04:00
Ell
9cabee5451 app: call gimp_progress_end() at gimp_image_convert_dither_u8() exit 2018-03-29 03:30:31 -04:00
Jehan
527ad94a7e Bug 794772 - detect freetype2 using pkg-config.
I hesitated keeping both the pkg-config and freetype-config (which is
mostly a wrapper to pkg-config nowadays apparently) as fallback, but
anyway I can see in their repositories that they have a pkg-config file
since 2003. Really I don't think it makes sense to hold onto such old
and deprecated dependency configuration systems.
2018-03-28 19:48:16 +02:00
Thomas Manni
44f293bcdb Bug 794753 - do not dither image mask and channels for imported images
When "Dither images when promoting to floating point" is checked in
Preferences, apply dithering on layers and keep image mask and channels
unaltered.
2018-03-28 17:15:06 +02:00
Michael Natterer
c5ebf29065 Bug 794747 - Multiple GIMP-WARNINGs about duplicate accelerators on startup
Turn the g_warning() into a g_printerr().

Duplicate accelerators should not trigger a WARNING, because they come
from a config file and there is nothing that can be fixed in the code
to prevent that.
2018-03-28 14:48:05 +02:00
Michael Natterer
60e01f5593 app: fix error reporting in gimp_tool_preset_deserialize_property()
when setting a custom parse error with g_scanner_error() we *must*
return G_TOKEN_NONE as expected token, or general GimpConfig error
handling will try to overwrite our error with its generic "unexpected
token" message, which triggers a warning.
2018-03-28 01:17:39 +02:00
Michael Natterer
69d5201d59 app: fix formatting in previous commit 2018-03-28 00:44:33 +02:00
Øyvind Kolås
a7b0d55fc5 app: only create GeglBuffer wrapper for cairo-data when used
As suggested by massimo in bug #694917, move unconditional creation/destruction
of a wrapper GeglBuffer object from top-level scope of the function to the
single conditional scope where it is used.
2018-03-28 00:37:06 +02:00
Khaled Hosny
0fe50c76f8 Update Arabic translation 2018-03-27 15:47:41 +02:00
Ell
5614cd444d app: in gimp_image_convert_precision(), report progress for selection mask 2018-03-27 09:39:52 -04:00
Ell
cf658f64b5 Bug 794721 - CRITICAL converting image precision
In gimp_image_convert_precision(), don't overwrite the 'progress'
parameter with the object queue, since we need to call
gimp_progress_end() on it at the end of the process.
2018-03-27 09:39:52 -04:00
Marco Ciampa
7f96c9e7c6 Updated Italian translation 2018-03-27 12:25:33 +02:00
Ell
956ca8e3a3 app: small fix to gimp_operation_buffer_source_validate_process()
Fix tile-grid realignemnt after intersecting the ROI with the dirty
region.
2018-03-26 19:15:20 -04:00
Michael Natterer
e5e14b3898 configure.ac: bump version to 2.10.0-RC1 2018-03-27 01:07:28 +02:00
Michael Natterer
368c7c0511 docs, etc: default gimprc and its manpage regenerated by distcheck 2018-03-27 01:07:28 +02:00
Ell
caa3a98f04 Bug 790810 - Nested layer groups lead to a deadlock with multithreading
In gimp_operation_buffer_source_validate_process(), align the ROI
to the tile grid *before* intersecting it with the validate-
handler's dirty region.  This is necessary since, even though
subsequent operations will only read data within the ROI, the
entire tiles containing the ROI will be fetched, resulting in an
area potentially greater than the ROI.  We need to validate this
area in advance, or else it will be validated as part of the
subsequent operations, which can lead into the same deadlock we're
trying to prevent.
2018-03-26 19:04:34 -04:00
Piotr Drąg
e4d2de7dde Update Polish translation
String freeze, eh?
2018-03-26 23:55:30 +02:00
Michael Natterer
8c0d30004f NEWS: some small fixes 2018-03-26 23:42:46 +02:00
Jehan
7409c98893 devel-docs: add OS support specific information.
I create this file so that we can refer to it to know whether we can use
a OS-specific API, or if we want to know if we can safely bump a
dependency, etc.
2018-03-26 23:32:38 +02:00
Kristian Rietveld
ce3899e722 libgimpwidgets: gimppickbutton-quartz: do not release color_space
The color_space reference should not be released because it was obtained
with a Get-function, which means we do not have ownership.
2018-03-26 22:59:01 +02:00
Kristian Rietveld
0e9e167da8 libgimpwidgets: make pick button quartz work on macOS < 10.12
The symbol CGColorSpaceCopyICCData() is only available on macOS 10.12
and higher. We want GIMP to run from 10.9 onwards, so use the older
symbol CGColorSpaceCopyICCProfile() even though this one is deprecated.
2018-03-26 22:59:01 +02:00
Ell
b2d40eb994 data: don't install gimp-splash.xcf
We only need it in git.
2018-03-26 15:37:01 -04:00
Zhouyang
a6fd24a953 Bug 793951 - Fix crashes when some external APIs fail
Check the return values of some functions and set errors or print
a message to stderr if they fail.
2018-03-26 21:27:42 +02:00