When an error occurs, we want to prevent overwriting any previous
version of the file by incomplete contents. So run
g_output_stream_close() with a cancelled GCancellable to do so.
See also discussion in #2565.
(cherry picked from commit 613bf7c5ab)
Need to check if we must override PixbufStyle's draw_layout() after
each theme change, not only at the beginning of themes_init(), so it
works also when the the pixbuf engine was not already loaded at
startup.
Massimo is worried that it could unload the module (maybe in some
specific cases?), which could indeed happen when the g_type_class_ref()
just before was the first call to the class (hence it's the only ref).
So let's just unref() in the exit() function instead.
Not sure if g_type_class_ref() can actually return NULL here, but let's
add a check, just in case.
Also unref() after since we ref-ed it ourselves.
Finally reorganize a bit to keep the private functions together and
named appropriately, clean some tabs and add a comment to remind of
further check/cleanup once we port to GTK+3.
Comment by Jehan after review:
"Quick and dirty hack" but a working one. Since the bug will likely
disappear with the GTK+3 port (to be verified) which uses another theme
system, let's just do it this way.
Allow propgui constructors to specify an (optional) callback function
when creating pickers, to be called when a color/coordinate is picked,
similarly to controller callbacks.
Implement picker callback support in GimpFilterTool. When the active
picker has an associated callback function, call it instead of the
class's color_picked() function.
Add lots of "#include <gegl.h>" to .c files that miss it, which is
now necessary, since this commit adds a Babl* parameter in
propgui-types.h.
Create GIMP_CONFIG_DEFAULT_(ICON_)?THEME in gimpguiconfig.h to set
defaults in a single place, except for libgimpwidgets/ which cannot
include from app/.
- use G_FILE_CREATE_NONE instead of 0
- don't put "Could not open <file> for writing: <error>" around the
returned error, the returned message is already verbose
gimp_directory_file(), gimp_data_directory_file() etc. The new
functions take a variable list of path elements to the file,
the list has to be NULL-terminated. Remove the newly added
gimp_personal_rc_gfile(). Start using the new functions in app/.
2009-01-17 Michael Natterer <mitch@gimp.org>
* all files with a GPL header and all COPYING files:
Change licence to GPLv3 (and to LGPLv3 for libgimp).
Cleaned up some copyright headers and regenerated the parsers in
the ImageMap plugin.
svn path=/trunk/; revision=27913
2007-04-17 Michael Natterer <mitch@gimp.org>
* app/config/gimprc.c
* app/plug-in/gimppluginmanager.c
* app/plug-in/gimpplugin.c
* app/gui/themes.c: don't translate --verbose or g_printerr()
messages, they are debugging output that often end up in bugzilla
and should not depend on the locale.
svn path=/trunk/; revision=22262
2004-11-30 Michael Natterer <mitch@gimp.org>
* app/gui/themes.c (themes_init): use gtk_rc_parse() instead of
gtk_rc_add_default_file() to add ~/.gimp-2.2/themerc to the list
of files parsed by GTK+ because the latter works only before
gtk_init(). Fixes bug #155963.
2004-01-21 Tor Lillqvist <tml@iki.fi>
* app/gui/themes.c (themes_list_themes_foreach): Fix undefined
behaviour. Fixes crash in bringing up the Preferences dialog when
compiled with Sun's compiler.
2004-01-19 Sven Neumann <sven@gimp.org>
* app/*/*.c: include "libgimpbase/gimpbase.h" where needed; removed
now unnecessary inclusions of "file/file-utils.h".
2004-01-19 Sven Neumann <sven@gimp.org>
* app/file/file-utils.[ch]: removed file_utils_filename_to_utf8() ...
* libgimpbase/gimputils.[ch]: ... and added it here as
gimp_filename_to_utf8(). Added some docs that promise less than
the current implementation holds so that we can change the
implementation later.
* app/*/*.c: use gimp_filename_to_utf8() where
file_utils_filenames_to_utf8() has been used before.
* libgimpbase/gimpbase.def: changed accordingly.
* configure.in: reset GIMP_INTERFACE_AGE.
2004-01-14 Tor Lillqvist <tml@iki.fi>
* app/file/file-utils.[ch]: Add new function
file_utils_filename_to_utf8(), which is to be used when converting
file names (which are kept in the on-disk encoding) to UTF-8 for
passing to GTK, or to g_print() etc.
* app/*/*.c: Call file_utils_filename_to_utf8(). Should fix most
of the warnings generated by non-UTF8 pathnames. See #130118.
* libgimpbase/gimpenv.b: Document that gimp_directory() etc return
strings in the on-disk encoding.
* libgimpmodule/gimpmodule.c: Convert filenames to UTF-8 (using
g_filename_to_utf8()) before passing to g_print().
2003-11-16 Sven Neumann <sven@gimp.org>
* app/gui/themes.c (themes_apply_theme): removed an unused
variable and trailing whitespace.
* app/widgets/gimppropwidgets.c (gimp_prop_adjustment_notify):
fixed a cut'n'paste error and added a warning which would have
caught it.
* app/config/gimpbaseconfig.c
* app/config/gimpcoreconfig.c
* app/config/gimpguiconfig.c
* app/config/gimppluginconfig.c: cosmetics.
2003-11-16 Hans Breuer <hans@breuer.org>
* app/text/*.c : still unacceptable patched to compile
without FT2, see bug #113681
* **makefile.msc : updated
* app/config/gimpconfig-dump.c : include gimpwin32-io.h
* app/plug-in/plug-ins.c : don't depend on g_print handling
%s with NULL pointers, it doesn't anymore with glib cvs at
least not on win32
* app/widgets/gimppropwidgets.c
libgimpbase/gimputils.c
libgimpwidgets/gimpmemsizeentry.c :
sorry about the mess, need to work-around a stupi not able
to cast from guint64 to double
* app/widgets/gimppropwidgets.c (gimp_prop_memsize_entry_new) :
avoid 'overflow in floating-point constant arithmetic' by disabling
an imho alays questionable g_return_val_if_fail() for _MSC_VER only
* libgimpmodule/gimpmodule.def : sorted
* libgimpwidgets/gimpfileselection.c : removed unused S_ISDIR
definition
* app/gui/themes.c : filenames in rc files need to be escaped
2003-11-15 Michael Natterer <mitch@gimp.org>
* app/gui/themes.c (themes_get_theme_file): new utility function
which takes a filename relative to the theme's root directory and
returns the absolute path to the file in the current theme. It
falls back to the resp. path in the default theme if the given
file is not present in the current theme.
* app/gui/preferences-dialog.c (prefs_notebook_append_page): use it.
2003-11-14 Michael Natterer <mitch@gimp.org>
* app/config/gimpconfig-utils.c
* app/gui/themes.c: use standard file error message
strings. Removes two more translatable strings.
2003-11-12 Michael Natterer <mitch@gimp.org>
Use the correct GTK+ APIs for setting and changing the theme:
* app/gui/themes.c (themes_apply_theme): don't call gtk_rc_parse()
but write a new config file "~/.gimp-1.3/themerc" which includes
both the theme's and the user's gtkrc files.
(themes_init): use gtk_rc_add_default_file() to make themerc known
to GTK+.
(themes_theme_change_notify): don't fiddle with toplevel windows
manually but simply call gtk_rc_reparse_all() after writing the
new themerc.
* libgimp/gimpui.c (gimp_ui_init): use gtk_rc_add_default_file()
instead of gtk_rc_parse().
* app/gui/preferences-dialog.c: cleaned up / beautified the theme
selector. Added a "Reload Current Theme" button. Simplified
GtkTreeView column inserting all over the place.
(prefs_response): destroy the preferences dialog later so we don't
crash when cancelling a theme change on "Cancel" (workaround for
bug #126808).
* app/gui/module-browser.c (module_browser_new): column inserting
simplification.
2003-11-12 Michael Natterer <mitch@gimp.org>
* app/gui/themes.[ch]: split out function themes_apply_theme()
from themes_init(). Connect to "notify::theme" of gimp->config and
change the theme in the callback. Added themes_list_themes().
Added "const gchar *theme_name" parameter to
themes_get_theme_dir().
* app/gui/gui-vtable.c (gui_get_theme_dir): changed accordingly.
* app/gui/preferences-dialog.c (prefs_dialog_create): enabled
theme selection on the "Interface" page. Still has many issues
(like using a conceptually wrong method of theme changing ;-)
but it won't get fixed if we cannot change themes on the fly...
2003-11-10 Michael Natterer <mitch@gimp.org>
Made plug-ins honor the current GIMP theme:
* app/core/gimp.[ch]: added GimpGetThemeDirFunc to the GUI vtable.
* app/gui/gui-vtable.c: implement it here.
* tools/pdbgen/pdb/gimprc.pdb: added new PDB function
gimp_get_theme_dir().
* libgimp/gimpui.c: use the new function and fall back to
gimp_gtkrc() if it returns NULL.
* app/pdb/gimprc_cmds.c
* app/pdb/internal_procs.c
* libgimp/gimpgimprc_pdb.[ch]: regenerated.
* app/gui/themes.c: unrelated cleanup.
2003-09-11 Michael Natterer <mitch@gimp.org>
* app/gui/Makefile.am
* app/gui/themes.[ch]: new files.
* app/gui/gui.[ch]: code taken from here. It was getting too large.
* app/gui/preferences-dialog.c; changed accordingly.
