Commit graph

15102 commits

Author SHA1 Message Date
Michael Natterer
062d38d141 Bug 675399 - Mention that the image was at least exported in the close...
If the image was exported, mention it in the close warning dialog.
(cherry picked from commit 57d4680ab3)
2012-05-10 01:11:54 +02:00
Michael Natterer
c4d14752a7 Bug 630173 - a dockable open from an existing one appears under it
Show the new dock with gtk_widget_show_now(), which waits until it's
mapped, then call gdk_window_raise() explicitly. How sick...
(cherry picked from commit bd3f892f79)
2012-05-09 00:23:10 +02:00
Michael Natterer
7f37903b11 app: make GimpContainerPopup transient to its parent toplevel
so it doesn't appear under the dock it's invoked from. Only
needed on OSX, but the right thing to do on all platforms.
(cherry picked from commit 3545140ad8)
2012-05-08 21:36:05 +02:00
Michael Natterer
7ef8a96465 app: don't call gimp_image_flush() when cancelling GimpImageMapTool
because the tool might be cancelled from some other place opening an
undo group, so flushing the image would update menus and whatnot while
that other operation is running, with unforeseeable side
effects. Also, flusing the image here is not needed because we didn't
change anything in the image. Instead, make sure manually that the
display is updated correctly after restoring GimpImageMapTool's
temporary editing.
(cherry picked from commit e7e8c9ef0a)
2012-05-05 21:48:13 +02:00
Michael Natterer
32a0c6355e app: fix UI tag matching to always work case-insensitively
Add gimp_tag_has_prefix() and use it in GimpTagEntry when completing
patrially entered tag names, and fix two uses of strcmp() in
GimpTagPopup to use gimp_tag_compare_with_string().
(cherry picked from commit 30b4fe8510)
2012-05-05 19:00:32 +02:00
Michael Natterer
4c66e50763 app: make sure Ctrl+E doesn't invoke "Export to" when it's invisible 2012-05-05 00:17:51 +02:00
Enrico Schröder
8cd272bb80 Heal: Make HealTool work when brush is partially outside of layer
Fix for bug 568098 https://bugzilla.gnome.org/show_bug.cgi?id=568098
Removes condition for not applying heal when (destination)brush is partially outside of layer.
Instead heal is not applied when brush is completely outside.
2012-04-24 22:21:25 +03:00
Michael Henning
2920344524 app: Prevent uninitialized values in the heal tool.
Previously, the black checkers of the left hand edge of the solution
matrix were not being assigned a value.
2012-04-24 22:08:44 +03:00
Michael Natterer
24e6b20be8 Bug 674373 - Resizing Mask size is making gimp to crash
gimp_transform_tool_real_transform(): make sure we clip layer masks
and channels to their original extents also when transforming them
completely (not just a selection of them).
2012-04-21 22:42:53 +02:00
Mikael Magnusson
0025f9f354 fix typo "equalizee" 2012-04-12 01:28:30 +02:00
Nils Philippsen
ff6c2807be app: add a little more headroom to the smudge buffer
This fixes crashes when smudging with sizes <= 1.4, filed against Fedora
(rhbz#810850).
2012-04-11 19:04:58 +02:00
Michael Natterer
e1dcba190e app: don't leak one TempBuf per blurred brush mask/pixmap 2012-04-04 11:35:59 +02:00
Michael Natterer
531709c8db Depend on ATK 2.2.0, GTK+ 2.24.10, GdkPixbuf 2.24.1
And do some final NEWS adjustments for RC1
2012-04-03 00:53:04 +02:00
Øyvind Kolås
36c52537e4 bump babl req versions to 0.1.10 and gegl to 0.2.0 2012-04-02 23:11:07 +01:00
Michael Natterer
9252922651 Depend on GEGL 0.1.9 and use the new gegk-0.1 pkg-config file 2012-04-02 12:33:26 +02:00
Michael Natterer
90706f8427 app: make sure explicitly saved color tool settings don't end up in "recent"
reset the "time" property after applying the stored setting, otherwise
explicitly storing the config as setting will also copy the time, and
the stored object will be considered to be among the automatically
stored recently used settings
2012-04-02 11:50:47 +02:00
Michael Natterer
657a2661b2 app: fix saving of the settings' timestamp in color tool config classes
we override serialize_property() and are responsible for doing it
ourselves.
2012-04-02 11:49:22 +02:00
Martin Nordholts
08cbf159c1 app/tests: Update gegl_buffer_get() code so it builds 2012-04-01 11:44:12 +02:00
Michael Natterer
817d516da4 Depend on Babl 0.1.8 2012-03-30 10:13:23 +02:00
Michael Natterer
1556773582 app: don't set another scanner error after gimp_config_deserialize() failed
Setting errors on top of each other produces runtime warnings.
2012-03-30 10:09:14 +02:00
Michael Natterer
7cbd1c5739 app: don't dereference a NULL session_info->p->factory_entry 2012-03-30 09:55:45 +02:00
Øyvind Kolås
814f81b389 app: fix meta-data registration in TileSource op 2012-03-29 22:40:30 +01:00
Øyvind Kolås
17f92b7379 app: the destroy functions are gone from GEGL, use g_object_unref() instead 2012-03-29 22:21:05 +01:00
Øyvind Kolås
eea7a40dbc app: update GeglOps to new GEGL API 2012-03-29 19:22:22 +01:00
Simon Budig
17729bf6af app: specify proper BABL format for legacy point filters 2012-03-29 03:16:06 +02:00
Øyvind Kolås
5f11b748ce app: map lanczos to lohalo when using GEGL
This is mostly not used anywhere in GIMP, but since GEGL no longer has a
lanczos implementation mapping it to lohalo is what makes most sense.
2012-03-28 12:52:28 +01:00
Øyvind Kolås
a3774d1cfb app: update to new GEGL API in cage tool 2012-03-26 19:03:40 +01:00
Øyvind Kolås
c93edf59f4 app: adapt to API changes in GEGL 2012-03-26 01:22:17 +01:00
Michael Natterer
011b058945 app: follow GEGL API changes 2012-03-26 01:13:37 +02:00
Michael Natterer
c3230a7a2f app: forgot to change the actual binary to 2.8 2012-03-24 19:42:34 +01:00
Michael Natterer
439f7f579a app: s/Babl/const Babl/ 2012-03-24 18:52:31 +01:00
Massimo Valentini
6600bb8347 app: silence a harmless critical warning
Executing Desaturate... or Posterize... used to print:

Gimp-Widgets-CRITICAL **: gimp_settings_box_add_current: assertion
`GIMP_IS_SETTINGS_BOX (box)' failed
2012-03-18 18:30:28 +01:00
Mikael Magnusson
18692f318f app: fix header in gimpoperationbrightnesscontrast.[ch] 2012-03-13 21:50:04 +01:00
Massimo Valentini
a29c096614 app: initialize also GimpRGB's alpha component
Conditional jump or move depends on uninitialised value(s)
==29000==    at 0x4C33CBC: gimp_color_area_set_color (gimp/libgimpwidgets/gimpcolorarea.c:425)
==29000==    by 0x4C3505B: gimp_color_button_set_color (gimp/libgimpwidgets/gimpcolorbutton.c:642)
==29000==    by 0x5DA5BE: gimp_text_style_editor_set_color (gimp/app/widgets/gimptextstyleeditor.c:700)
==29000==    by 0x5DB0D4: gimp_text_style_editor_update_idle (gimp/app/widgets/gimptextstyleeditor.c:1090)
==29000==    by 0x57E9E95: gdk_threads_dispatch (gtk-2-24/gdk/gdk.c:512)

Steps to reproduce:

<Ctrl>N <Enter> T
click on canvas
type something

select the text entered and change its color using
the color button from the text style editor
2012-03-13 20:44:47 +01:00
Massimo Valentini
62ebb4a1e5 app: initialize all members of a GimpAnchor
Conditional jump or move depends on uninitialised value(s)
==28817==    at 0x6AA386: gimp_coords_manhattan_dist (gimp/app/core/gimpcoords.c:175)
==28817==    by 0x6AB428: gimp_coords_bezier_is_straight (gimp/app/core/gimpcoords-interpolate.c:213)
==28817==    by 0x67663B: gimp_bezier_stroke_segment_nearest_point_get (gimp/app/vectors/gimpbezierstroke.c:676)
==28817==    by 0x676C86: gimp_bezier_stroke_nearest_point_get (gimp/app/vectors/gimpbezierstroke.c:631)
==28817==    by 0x4D79E3: gimp_draw_tool_on_vectors_curve (gimp/app/tools/gimpdrawtool.c:1175)
==28817==    by 0x4D7CD5: gimp_draw_tool_on_vectors (gimp/app/tools/gimpdrawtool.c:1242)
==28817==    by 0x511CE7: gimp_vector_tool_oper_update (gimp/app/tools/gimpvectortool.c:989)
==28817==    by 0x50B059: gimp_tool_oper_update (gimp/app/tools/gimptool.c:970)
==28817==    by 0x546F3C: gimp_display_shell_canvas_tool_events (gimp/app/display/gimpdisplayshell-tool-events.c:401)
==28817==    by 0x52A42E2: _gtk_marshal_BOOLEAN__BOXED (gtk-2-24/gtk/gtkmarshalers.c:86)

Steps to reproduce:

G_SLICE=always-malloc valgrind gimp-2.7 app/tests/*/*.xcf

B (Activate Path tool)
2012-03-13 20:44:47 +01:00
Massimo Valentini
a80a63443d app: initialize a GtkTreeIter
Conditional jump or move depends on uninitialised value(s)
==28871==    at 0x4A09863: bcmp (/builddir/build/BUILD/valgrind-3.6.1/memcheck/mc_replace_strmem.c:692)
==28871==    by 0x4C487C7: gimp_int_store_row_inserted (gimp/libgimpwidgets/gimpintstore.c:220)
==28871==    by 0x8342B03: g_closure_invoke (glib/gobject/gclosure.c:774)
==28871==    by 0x8353129: signal_emit_unlocked_R (glib/gobject/gsignal.c:3232)
==28871==    by 0x835A72A: g_signal_emit_valist (glib/gobject/gsignal.c:3033)
==28871==    by 0x835A8F1: g_signal_emit (glib/gobject/gsignal.c:3090)
==28871==    by 0x529EF63: gtk_list_store_insert (gtk-2-24/gtk/gtkliststore.c:1039)
==28871==    by 0x5CEB6B: gimp_stroke_editor_constructed (gimp/app/widgets/gimpstrokeeditor.c:229)
==28871==    by 0x8348222: g_object_newv (glib/gobject/gobject.c:1731)
==28871==    by 0x8348565: g_object_new_valist (glib/gobject/gobject.c:1820)
==28871==    by 0x8348873: g_object_new (glib/gobject/gobject.c:1535)
==28871==    by 0x5CEE74: gimp_stroke_editor_new (gimp/app/widgets/gimpstrokeeditor.c:320)
==28871==    by 0x4C3842: stroke_dialog_new (gimp/app/dialogs/stroke-dialog.c:176)
==28871==    by 0x4A3B5C: select_stroke_cmd_callback (gimp/app/actions/select-commands.c:349)

Steps to reproduce:

On a 64 bits machine run gimp-2.7

<Ctrl>N <Enter> <Ctrl>A
and activate <Edit>/Stroke Selection... (<Alt>E S)
2012-03-13 20:44:47 +01:00
Michael Natterer
b262c93048 app: create an own GimpOperationBrightnessContrast
and use it instead of gegl:brightness-contrast because the GEGL op is
giving different reaults.
2012-03-13 15:02:17 +01:00
Michael Natterer
216133b2d0 app: the usual formatting cleanup in GimpTileBackendTileManager 2012-03-13 14:53:09 +01:00
Øyvind Kolås
2ea41ea3f6 tests: update API usage of gimptilebackendtilemanager test 2012-03-13 13:09:59 +00:00
Øyvind Kolås
5d6662ad00 gimptilebackendtilemanager: add utility call to construct buffer
For this utility call as well as the backend constructor itself pass a boolean
to indicate if write access to the buffer is desired.
2012-03-13 12:49:35 +00:00
Øyvind Kolås
5362448044 GimpTileBackendTileManager: make it work
remove dead code, simplify existing code and make full width tiles be 0-copy.
2012-03-13 10:32:48 +00:00
Michael Natterer
ddf0d9e6b7 app: use G_GUINT64_FORMAT to print guint64 2012-03-12 20:26:51 +01:00
Michael Natterer
aa7e7c153c app: remove another bunch of one-line GtkTables 2012-03-12 20:12:11 +01:00
Michael Natterer
5e94863c8e app: get rid of a GtkTable in gimp_paint_options_gui(), and some cleanup 2012-03-09 20:30:05 +01:00
Massimo Valentini
7fed1b6e93 Bug 651956: Text tool misremembers point size upon reloading file
When setting the unit of a property shared with a gimp_prop_size_entry,
a conversion is applied to the corresponding size property (to preserve
size_entry's ref-value), but the conversion risks to change the size
property already updated.

To update, at the same time, size and unit, it is better to start updating
size_entry's unit in order to trigger the useless conversion on the stale
size.
2012-03-09 19:21:44 +01:00
Massimo Valentini
71cb4fbd71 Bug 667368: Bug in Histogram egalization 2012-03-08 18:20:45 +01:00
Alexis Wilhelm
c7c752f5df Bug 541859 - Colour Balance Range to Adjust has no Effect
This makes the different ranges have a clearly different effect,
plus speeds up the gegl op quite a lot.

NOTE: this might affect the result of scripts using color-balance
2012-03-07 21:45:59 +01:00
Michael Natterer
f2f1eab753 app: add "ERROR" to the values of enum GimpPdbErrorCode
so they are now GIMP_PDB_ERROR_FOO instead of just GIMP_PDB_FOO,
because it was just too confusing wrt enum GimpPdbStatusType.
2012-03-05 19:36:59 +01:00
Michael Natterer
435feea20a app: use gimp_cairo_set_source_rgb() wheh setting a GimpRGB 2012-03-05 19:19:47 +01:00
Massimo Valentini
1658460523 app: don't g_assert_not_reached on GIMP_PDB_FAILED errors
calling in a script (gimp-file-load-layer 1 image "notexists.bmp")
used to crash GIMP with the following message:

**
Gimp-PDB:ERROR:gimpprocedure.c:491:gimp_procedure_get_return_values:
code should not be reached
gimp-2.7: terminated: Aborted
2012-03-05 18:36:03 +01:00