Commit graph

10774 commits

Author SHA1 Message Date
Martin Nordholts
052d859c6a When the screen resolution changes and we are not in Dot by dot, we also
2008-08-14  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-handlers.c
	(gimp_display_shell_monitor_res_notify_handler): When the screen
	resolution changes and we are not in Dot by dot, we also need to
	clamp the display shell offsets.

svn path=/trunk/; revision=26557
2008-08-14 15:44:25 +00:00
Martin Nordholts
f91ac50fd7 If we are in dot-by-dot, we only need to update the rulers, and only if
2008-08-14  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-handlers.c
	(gimp_display_shell_resolution_changed_handler): If we are in
	dot-by-dot, we only need to update the rulers, and only if the
	unit is not pixels.

svn path=/trunk/; revision=26556
2008-08-14 15:34:09 +00:00
Martin Nordholts
ecd95dcf76 Split this up in gimp_display_shell_scale_update_scrollbars() and
2008-08-14  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_update_scrollbars_and_rulers): Split this up
	in gimp_display_shell_scale_update_scrollbars() and
	gimp_display_shell_scale_update_rulers().

svn path=/trunk/; revision=26555
2008-08-14 15:17:40 +00:00
Martin Nordholts
2f52791b2b New helper function.
2008-08-14  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.c
	(gimp_display_shell_scroll_clamp_and_update): New helper function.

	* app/display/gimpdisplayshell-scale.c
	* app/display/gimpdisplayshell-scroll.c
	* app/display/gimpdisplayshell-callbacks.c: Use it.

svn path=/trunk/; revision=26554
2008-08-14 14:41:29 +00:00
Sven Neumann
4d38e14aa9 applied patch from Luidnel Maignan (followup to bug #105568).
2008-08-13  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/paint-funcs.c (replace_inten_pixels): applied
	patch from Luidnel Maignan (followup to bug #105568).


svn path=/trunk/; revision=26535
2008-08-13 19:03:57 +00:00
Sven Neumann
fc2f433d98 applied patch from Geert Jordaens to fix scaling artifacts in top row (bug
2008-08-13  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/scale-region.c: applied patch from Geert
	Jordaens to fix scaling artifacts in top row (bug #464466).


svn path=/trunk/; revision=26534
2008-08-13 19:02:23 +00:00
Martin Nordholts
0fabf10475 New function responsible for deciding what viewport coordinate to focus on
2008-08-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_get_zoom_focus): New function
	responsible for deciding what viewport coordinate to focus on when
	zooming in and out.

svn path=/trunk/; revision=26532
2008-08-13 18:37:15 +00:00
Martin Nordholts
ccdac05843 Make this a private function because we want to be in full control over
2008-08-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.[ch]
	(gimp_display_shell_scale_to): Make this a private function
	because we want to be in full control over what pixel to focus on
	when zooming in and out.

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_canvas_tool_events): Use
	gimp_display_shell_scale() here instead of
	gimp_display_shell_scale_to(). We figure out (and can override if
	we wish) the coordinates that were previously passed explicitly.

svn path=/trunk/; revision=26531
2008-08-13 17:58:25 +00:00
Martin Nordholts
47b34e973d New function.
2008-08-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_image_is_within_viewport): New function.

	* app/display/gimpdisplayshell.c (gimp_display_shell_new): When
	the zoom button is toggled, implicitly do a View -> Fit Image in
	Window if the (scaled) image is within the viewport.

svn path=/trunk/; revision=26529
2008-08-13 17:36:29 +00:00
Martin Nordholts
a9bb68a248 Include gimpprojection.h for gimp_projection_get_tiles().
2008-08-13  Martin Nordholts  <martinn@svn.gnome.org>

	* app/paint/gimppaintcore.c: Include gimpprojection.h for
	gimp_projection_get_tiles().

svn path=/trunk/; revision=26528
2008-08-13 17:30:08 +00:00
Sven Neumann
a39600752f followup change for bug #105568
svn path=/trunk/; revision=26527
2008-08-12 20:50:06 +00:00
Sven Neumann
f35066ffe4 applied a slightly modified version of the patch from Luidnel Maignan as
2008-08-12  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/paint-funcs.c (replace_inten_pixels): applied 
a
	slightly modified version of the patch from Luidnel Maignan as
	attached to bug #105568. Fixes incorrect alpha treatment in
	plug-in selection masking.


svn path=/trunk/; revision=26524
2008-08-12 20:01:19 +00:00
Sven Neumann
1a7bdc570d don't do the background histogram unless the histogram view is actually
2008-08-12  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimphistogrameditor.c
	(gimp_histogram_editor_frozen_update): don't do the background
	histogram unless the histogram view is actually visible.


svn path=/trunk/; revision=26523
2008-08-12 19:37:09 +00:00
Sven Neumann
a59c7ccaf0 use gimp_projection_get_tiles() instead of doing the same through the
2008-08-12  Sven Neumann  <sven@gimp.org>

	* app/paint/gimppaintcore.c (gimp_paint_core_start): use
	gimp_projection_get_tiles() instead of doing the same through 
the
	GimpPickable interface.


svn path=/trunk/; revision=26522
2008-08-12 18:59:04 +00:00
Sven Neumann
f6771f1987 moved function calls out of CLAMP macros.
2008-08-12  Sven Neumann  <sven@gimp.org>

	* app/core/gimpprojection.c (gimp_projection_paint_area): moved
	function calls out of CLAMP macros.


svn path=/trunk/; revision=26520
2008-08-12 16:30:44 +00:00
Sven Neumann
0847643307 removed calls to scale the image and to update the scrollbars and rulers.
2008-08-12  Sven Neumann  <sven@gimp.org>

	* app/display/gimpdisplayshell.c (gimp_display_shell_empty):
	removed calls to scale the image and to update the scrollbars 
and
	rulers. Doesn't seem to make sense in an empty display and it
	causes a crash.


svn path=/trunk/; revision=26518
2008-08-12 15:17:43 +00:00
Sven Neumann
ee58f4c90d app/core/gimpitem.c app/core/gimpobject.c app/dialogs/preferences-dialog.c
2008-08-12  Sven Neumann  <sven@gimp.org>

	* app/core/gimpitem.c
	* app/core/gimpobject.c
	* app/dialogs/preferences-dialog.c
	* plug-ins/imagemap/imap_main.c
	* plug-ins/imagemap/imap_selection.c
	* plug-ins/common/filter-pack.c
	* plug-ins/common/grid.c
	* plug-ins/common/newsprint.c
	* plug-ins/fractal-explorer/fractal-explorer-dialogs.c
	* plug-ins/fractal-explorer/fractal-explorer.c: use canonical
	signal names.


svn path=/trunk/; revision=26517
2008-08-12 14:45:59 +00:00
Sven Neumann
b25e6c0612 another minor coding style cleanup
svn path=/trunk/; revision=26493
2008-08-11 09:54:13 +00:00
Sven Neumann
7de9d15a8a make it compile again
svn path=/trunk/; revision=26492
2008-08-11 09:47:30 +00:00
Sven Neumann
2b68234259 another minor coding style cleanup
svn path=/trunk/; revision=26491
2008-08-11 09:44:38 +00:00
Sven Neumann
b060070182 minor coding style cleanups.
2008-08-11  Sven Neumann  <sven@gimp.org>

	* app/tools/gimptexttool.c: minor coding style cleanups.


svn path=/trunk/; revision=26490
2008-08-11 09:41:12 +00:00
Martin Nordholts
73e303590c If the image fits within the display shell canvas on a given axis, center
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-callbacks.c
	(gimp_display_shell_canvas_size_allocate): If the image fits
	within the display shell canvas on a given axis, center the image
	on that axis. This behaviour will certainly require a few tweaks
	but let's see how this feels. Feedback welcome.

svn path=/trunk/; revision=26489
2008-08-10 15:19:24 +00:00
Martin Nordholts
5148ff2c9f Recent refactorings seems to have made the centering hack obsolete so use
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell.c (gimp_display_shell_fill): Recent
	refactorings seems to have made the centering hack obsolete so use
	gimp_display_shell_scroll_center_image_on_next_size_allocate()
	instead.

svn path=/trunk/; revision=26488
2008-08-10 14:34:10 +00:00
Martin Nordholts
21a6d735e5 Always center the image after a wrap. I can't think of a case when that
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell.c (gimp_display_shell_shrink_wrap):
	Always center the image after a wrap. I can't think of a case when
	that shouldn't happen.

	* app/display/gimpdisplayshell-handlers.c
	(gimp_display_shell_size_changed_detailed_handler): Centering
	occurs implicitly after wrapping now, no need to do it explicitly.

	* app/display/gimpdisplayshell-scroll.c
	(gimp_display_shell_scroll_center_image): Handle the no-image
	case.

svn path=/trunk/; revision=26487
2008-08-10 14:26:29 +00:00
Martin Nordholts
b41206c334 New low level function for setting display shell offset.
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.[ch]
	(gimp_display_shell_scroll_set_offset): New low level function for
	setting display shell offset.

	(gimp_display_shell_scroll_center_image)

	* app/display/gimpdisplayshell-handlers.c
	(gimp_display_shell_size_changed_detailed_handler): Use it instead
	of gimp_display_shell_scale_by_values().

svn path=/trunk/; revision=26486
2008-08-10 13:09:24 +00:00
Martin Nordholts
0687c3317d Move the zoom-revert updating logic into this new helper function so that
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_handle_zoom_revert): Move the
	zoom-revert updating logic into this new helper function so that
	we can update zoom-revert from other places.

svn path=/trunk/; revision=26485
2008-08-10 13:06:06 +00:00
Martin Nordholts
2eacb5cf58 Rename gimp_display_shell_scale_setup() to
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.[ch]:
	Rename gimp_display_shell_scale_setup() to
	gimp_display_shell_update_scrollbars_and_rulers(), because that's
	exactly what that function does.

	* app/display/gimpdisplayshell.c
	* app/display/gimpdisplayshell-scroll.c
	* app/display/gimpdisplayshell-handlers.c
	* app/display/gimpdisplayshell-callbacks.c: Adapt to new name.

svn path=/trunk/; revision=26484
2008-08-10 11:56:29 +00:00
Martin Nordholts
c023ac02f9 Remove unused local variables sw and sh.
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scale.c
	(gimp_display_shell_scale_setup): Remove unused local variables sw
	and sh.

svn path=/trunk/; revision=26483
2008-08-10 11:40:00 +00:00
Martin Nordholts
4bbe4c81b8 Renamed gimp_display_shell_scroll_private() to gimp_display_shell_scroll()
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.[ch]: Renamed
	gimp_display_shell_scroll_private() to gimp_display_shell_scroll()
	and keep it here.

	* app/display/gimpdisplayshell-private.h: Removed.

	* app/display/Makefile.am
	* app/display/gimpdisplayshell-scale.c
	* app/display/gimpdisplayshell-scroll.c
	* app/display/gimpdisplayshell-handlers.c
	* app/display/gimpdisplayshell-callbacks.c
	* app/display/gimpdisplayshell-autoscroll.c: Adapt.

svn path=/trunk/; revision=26480
2008-08-10 11:11:19 +00:00
Martin Nordholts
65ff34a540 It makes more sense for gimp_display_shell_get_scaled_image_size() to be
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.[ch]: It makes more sense
	for gimp_display_shell_get_scaled_image_size() to be moved from
	here to

	* app/display/gimpdisplayshell-draw.[ch]: here, and rename it to
	gimp_display_shell_draw_get_scaled_image_size().

	* app/display/gimpdisplayshell.c: Adapt to name change.

svn path=/trunk/; revision=26479
2008-08-10 10:54:00 +00:00
Martin Nordholts
a81790d789 Oops, forgot to commit gimp_display_shell_get_scaled_viewport() -> gimp_display_shell_scroll_get_scaled_viewport() for gimprectangletool.c
svn path=/trunk/; revision=26478
2008-08-10 10:51:56 +00:00
Martin Nordholts
7865481ddf app/display/gimpdisplayshell-draw.[ch]
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-draw.[ch]
	* app/display/gimpdisplayshell-render.[ch]
	* app/display/gimpdisplayshell-transform.[ch]
	* app/display/gimpdisplayshell-appearance.[ch]: Sprinkle as many
	const qualifiers we can without any implementation changes.

svn path=/trunk/; revision=26477
2008-08-10 10:09:03 +00:00
Martin Nordholts
b9f66d0489 gimp_display_shell_ -> gimp_display_shell_scroll_ for functions that are
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.[ch]: gimp_display_shell_ ->
	gimp_display_shell_scroll_ for functions that are scroll
	related. Also did some other minor renamings.

	* app/display/gimpnavigationeditor.c
	* app/display/gimpdisplayshell-draw.c
	* app/display/gimpdisplayshell-scale.c 
	* app/display/gimpdisplayshell-render.c
	* app/display/gimpdisplayshell-transform.c
	* app/display/gimpdisplayshell-callbacks.c: Adapt to the name
	changes.

svn path=/trunk/; revision=26476
2008-08-10 09:08:11 +00:00
Martin Nordholts
aff80d1cf8 We need to center the image after a Shrink Wrap.
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/actions/view-commands.c (view_shrink_wrap_cmd_callback): We
	need to center the image after a Shrink Wrap.

svn path=/trunk/; revision=26472
2008-08-10 07:40:03 +00:00
Martin Nordholts
34b4b890cf There is no need for special casing depending on image size relative to
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	* app/display/gimpdisplayshell-scroll.c
	(gimp_display_shell_scroll_center_image): There is no need for
	special casing depending on image size relative to viewport size.

svn path=/trunk/; revision=26471
2008-08-10 07:26:35 +00:00
Martin Nordholts
a736df49e2 Put functions to center the image in the display shell where they belong,
2008-08-10  Martin Nordholts  <martinn@svn.gnome.org>

	Put functions to center the image in the display shell where they
	belong, and give them proper names.

	* app/display/gimpdisplayshell-scale.[ch]: Get rid of functions
	and use the new names.

	* app/display/gimpdisplayshell-scroll.[ch]: Put the functions here
	and call them gimp_display_shell_scroll_center_image() and
	gimp_display_shell_scroll_center_image_on_next_size_allocate().

	* app/display/gimpdisplayshell.c:
	* app/display/gimpdisplayshell-handlers.c: Use the new names.

svn path=/trunk/; revision=26470
2008-08-10 07:23:14 +00:00
Sven Neumann
9e163bb41b implement tile_manager_get_tile_coordinates() by calling
2008-08-08  Sven Neumann  <sven@gimp.org>

	* app/base/tile-manager.c: implement
	tile_manager_get_tile_coordinates() by calling
	tile_manager_get_tile_col_row() instead of the other way around.
	Saves two multiplications and divisions for each call of
	tile_manager_get_tile_col_row().


svn path=/trunk/; revision=26446
2008-08-08 11:33:18 +00:00
Sven Neumann
7f05996abc simplified tile_manager_map_tile()
svn path=/trunk/; revision=26439
2008-08-08 11:00:29 +00:00
Sven Neumann
576ea3cda1 whitespace fix
svn path=/trunk/; revision=26438
2008-08-08 10:57:38 +00:00
Sven Neumann
c10f60e4c8 introduced utility function tile_manager_allocate_tiles() to avoid code
2008-08-08  Sven Neumann  <sven@gimp.org>

	* app/base/tile-manager.c: introduced utility function
	tile_manager_allocate_tiles() to avoid code duplication.


svn path=/trunk/; revision=26437
2008-08-08 10:55:46 +00:00
Sven Neumann
0d4b6aa33e improved a comment.
2008-08-08  Sven Neumann  <sven@gimp.org>

	* app/base/tile-pyramid.c: improved a comment.


svn path=/trunk/; revision=26436
2008-08-08 10:06:09 +00:00
Sven Neumann
876b7ad14c allow to pass NULL for the 'name' parameter. This will be handled just
2008-08-08  Sven Neumann  <sven@gimp.org>

	* app/core/gimplayer.c (gimp_layer_new_from_tiles)
	(gimp_layer_new_from_pixbuf) (gimp_layer_new_from_region): allow
	to pass NULL for the 'name' parameter. This will be handled just
	like in gimp_layer_new().


svn path=/trunk/; revision=26434
2008-08-08 07:52:06 +00:00
Sven Neumann
7caf4cfc34 added mnemonic to the new action.
2008-08-07  Sven Neumann  <sven@gimp.org>

	* app/actions/layers-actions.c (layers_actions): added mnemonic 
to
	the new action.

	* de.po: Updated German translation.


svn path=/trunk/; revision=26432
2008-08-07 21:12:08 +00:00
Sven Neumann
20cf784f9a resurrected a mnemonic that was accidentally lost
svn path=/trunk/; revision=26431
2008-08-07 21:01:33 +00:00
Sven Neumann
b910779a62 fixed typo
svn path=/trunk/; revision=26430
2008-08-07 20:57:24 +00:00
Sven Neumann
5367771e4a sprinkled with const qualifiers. Fixed some portability problems.
2008-08-07  Sven Neumann  <sven@gimp.org>

	* app/paint-funcs/scale-region.c: sprinkled with const 
qualifiers.
	Fixed some portability problems.


svn path=/trunk/; revision=26429
2008-08-07 20:48:42 +00:00
Sven Neumann
1323200809 renamed a variable.
2008-08-07  Sven Neumann  <sven@gimp.org>

	* app/base/tile.c (tile_attach): renamed a variable.


svn path=/trunk/; revision=26428
2008-08-07 20:08:21 +00:00
Sven Neumann
4eb3689b62 added gimp_buffer_get_tiles().
2008-08-07  Sven Neumann  <sven@gimp.org>

	* app/core/gimpbuffer.[ch]: added gimp_buffer_get_tiles().

	* app/actions/edit-commands.c
	* app/core/gimpbrushclipboard.c
	* app/core/gimppatternclipboard.c: use the new accessor 
function.


svn path=/trunk/; revision=26426
2008-08-07 17:23:45 +00:00
Sven Neumann
60fcaa9629 app/core/gimplayer.c app/actions/edit-commands.c
2008-08-07  Sven Neumann  <sven@gimp.org>

	* app/core/gimplayer.c
	* app/actions/edit-commands.c
	* app/actions/layers-commands.c
	* tools/pdbgen/pdb/layer.pdb: corrected the GimpImageType passed
	to gimp_layer_new_from_tiles().

	* app/pdb/layer-cmds.c: regenerated.


svn path=/trunk/; revision=26425
2008-08-07 17:19:32 +00:00
Sven Neumann
7ee3d7f448 app/actions/edit-commands.[ch] added new action "edit-paste-as-new-layer".
2008-08-07  Sven Neumann  <sven@gimp.org>

	* app/actions/edit-commands.[ch]
	* app/actions/edit-actions.c: added new action
	"edit-paste-as-new-layer".

	* app/widgets/gimphelp-ids.h: added new help-id.

	* menus/image-menu.xml.in: added the new action.


svn path=/trunk/; revision=26424
2008-08-07 16:25:46 +00:00