dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Issue #12277: GIMP 3.0 RC1 opens Windows Console.

Browse source 
This was a bug in the meson port which was not taking into account the
stable or release state of a build (unlike how it was in the old
autotools). The rules are:

* All unstable builds (release or not) have the console.
* Non-release builds in stable series have the console.
* Only release of stable series don't have the console.
* The RC of a stable release should behave as a stable release.
This commit is contained in:
Jehan 2024-11-17 12:25:23 +09:00
parent b5e356265d
commit fcf524fbc3
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
meson.build
View file

@ -555,7 +555,11 @@ libarchive = dependency('libarchive')
# Check for debug console (Win32)
if platform_windows
conf.set('ENABLE_WIN32_DEBUG_CONSOLE', get_option('win32-debug-console'))
enable_win32_debug_console = get_option('win32-debug-console').enabled() or \
(get_option('win32-debug-console').auto() and (not stable or not release))
conf.set('ENABLE_WIN32_DEBUG_CONSOLE', enable_win32_debug_console)
# When we'll depend on meson >= 1.1.0, we can just use:
# conf.set('ENABLE_WIN32_DEBUG_CONSOLE', get_option('win32-debug-console').enable_auto_if(not stable or not release).enabled())
endif
################################################################################

2
meson_options.txt
View file

@ -1,7 +1,7 @@
# Build properties
option('ansi', type: 'boolean', value: false, description: 'Turn on strict ansi')
option('enable-console-bin',type: 'boolean', value: true, description: 'Build a console-only binary which does not link GTK')
option('win32-debug-console',type:'boolean', value: true, description: 'Open a console when starting the program')
option('win32-debug-console',type:'feature', value: 'auto', description: 'Open a console when starting the program')
option('enable-multiproc', type: 'boolean', value: true, description: 'Support for multiple processors')
option('profiling', type: 'boolean', value: false, description: 'Enable profiling')
option('windows-installer', type: 'boolean', value: false, description: 'Generate files needed for the Inno Windows installer')