dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

build/windows: Prevent users from downgrading without uninstalling GIMP

Browse source 
That's not supported by Inno and our (confusing) custom code to
remove previous "old" GIMP versions seems to not support that.
This commit is contained in:
Bruno Lopes 2025-04-01 16:31:53 -03:00
parent 0486b11d5c
commit e447b1244b
No known key found for this signature in database
2 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
build/windows/installer/base_gimp3264.iss
View file

@ -623,6 +623,7 @@ var
Installed_AppVersion: String;
Installed_AppVersionInt: Int64;
Installer_AppVersionInt: Int64;
ErrorCode: Integer;
begin
isInstalled := 'notInstalled';
if RegQueryStringValue(HKCU, 'Software\Microsoft\Windows\CurrentVersion\Uninstall\GIMP-{#GIMP_MUTEX_VERSION}_is1',
@ -654,6 +655,13 @@ begin
InstallType := 'itDowngrade';
end;
DebugMsg('CheckInstallType','Installed GIMP {#GIMP_MUTEX_VERSION} is: ' + Installed_AppVersion + ', installer is: {#FULL_GIMP_VERSION}. So Install type is: ' + InstallType);
if (not WizardSilent) and (InstallType = 'itDowngrade') then begin
if SuppressibleMsgBox(FmtMessage(CustomMessage('DowngradeError'), [Installed_AppVersion, '{#FULL_GIMP_VERSION}']), mbCriticalError, MB_OK, IDOK) = IDOK then begin
ShellExecAsOriginalUser('','ms-settings:appsfeatures','','',SW_SHOW,ewNoWait,ErrorCode);
Abort;
end;
end;
end;
function InitializeSetup(): Boolean;
@ -661,6 +669,8 @@ function InitializeSetup(): Boolean;
var Message,Buttons: TArrayOfString;
#endif
begin
CheckInstallType;
ConfigOverride := coUndefined;
Check32bitOverride;
@ -1452,11 +1462,11 @@ end;
//7.2 INSTALL: show GIMP text (aka billboard) above progress bar
#if Defined(GIMP_UNSTABLE) && GIMP_UNSTABLE != ""
const
GIMP_URL = 'https://gimp.org/downloads/devel/';
const
GIMP_URL = 'https://gimp.org/downloads/devel/';
#else
const
GIMP_URL = 'https://gimp.org/downloads/';
const
GIMP_URL = 'https://gimp.org/downloads/';
#endif
procedure lblURL_OnClick(Sender: TObject);

5
build/windows/installer/lang/setup.isl.xml.in
View file

@ -18,6 +18,11 @@
</section>
<section name="CustomMessages">
<!-- Shown when the user tries to downgrade without unninstalling GIMP -->
<config name="DowngradeError">
<value>You are trying to directly downgrade from GIMP %1 to %2.%n%nPlease remove GIMP yourself before installing this version.</value>
</config>
<!-- Shown before the wizard starts on development versions of GIMP -->
<config name="DevelopmentWarningTitle">
<value>Development version</value>