dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plug-ins/filter-browser: Correctly start/stop GMainLoop

Browse source 
I incorrectly read the GMainLoop documentation and thought that calling
g_main_loop_new with NULL as the first parameter will return the
"default GMainLoop". This is wrong and it resulted in the original
GMainLoop to never stop and therefore for the plug-in to never stop.

This also adds a call to unref for the GMainLoop.
This commit is contained in:
Ondřej Míchal 2025-11-11 11:55:52 +02:00
parent 9a82668999
commit d2045f49bb
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
plug-ins/filter-browser/filter-browser.c
View file

@ -86,6 +86,8 @@ G_DEFINE_TYPE (FilterBrowser, filter_browser, GIMP_TYPE_PLUG_IN)
GIMP_MAIN (FILTER_BROWSER_TYPE)
DEFINE_STD_SET_I18N
static GMainLoop *main_loop = NULL;
static GtkWidget *
create_filter_param_details (GParamSpec *pspec,
GtkSizeGroup *sg_label,
@ -699,7 +701,8 @@ browser_dialog_response (GtkWidget *widget,
gtk_widget_destroy (browser->dialog);
g_list_free (browser->filters);
g_free (browser);
g_main_loop_quit (g_main_loop_new (NULL, TRUE));
g_main_loop_quit (main_loop);
g_main_loop_unref (main_loop);
}
static GimpValueArray *
@ -807,7 +810,9 @@ filter_browser_run (GimpProcedure *procedure,
gtk_list_box_get_row_at_index (browser->filter_list, 0));
gtk_widget_show (GTK_WIDGET (browser->dialog));
g_main_loop_run (g_main_loop_new (NULL, TRUE));
main_loop = g_main_loop_new (NULL, TRUE);
g_main_loop_run (main_loop);
return gimp_procedure_new_return_values (procedure, GIMP_PDB_SUCCESS, NULL);
}