From c31ca5cd4cf943ad09745c92c807e7486267423f Mon Sep 17 00:00:00 2001 From: Jacob Boerema Date: Thu, 6 Feb 2025 11:45:34 -0500 Subject: [PATCH] app: better help ids for soft-proofing related Image commands The help ids for the Image Color management related to soft-proofing were all pointing to the View color management submenu. Let's use more specific ids for the Image menu, so that help will arrive at a better location in the manual (once we have added the ids there too). --- app/actions/image-actions.c | 12 ++++++------ app/widgets/gimphelp-ids.h | 4 ++++ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/app/actions/image-actions.c b/app/actions/image-actions.c index fd5ad2aacb..8ef6d04141 100644 --- a/app/actions/image-actions.c +++ b/app/actions/image-actions.c @@ -85,7 +85,7 @@ static const GimpActionEntry image_actions[] = NC_("image-action", "_Soft-proof Profile..."), NULL, { NULL }, NC_("image-action", "Set the soft-proofing profile"), image_softproof_profile_cmd_callback, - GIMP_HELP_VIEW_COLOR_MANAGEMENT }, + GIMP_HELP_IMAGE_SOFT_PROOF_PROFILE_ASSIGN }, { "image-color-profile-save", NULL, NC_("image-action", "_Save Color Profile to File..."), NULL, { NULL }, @@ -176,7 +176,7 @@ static const GimpToggleActionEntry image_toggle_actions[] = NC_("image-action", "Use black point compensation for soft-proofing"), image_softproof_bpc_cmd_callback, TRUE, - GIMP_HELP_VIEW_COLOR_MANAGEMENT } + GIMP_HELP_IMAGE_SOFT_PROOF_BLACK_POINT } }; static const GimpRadioActionEntry image_convert_base_type_actions[] = @@ -299,25 +299,25 @@ static const GimpRadioActionEntry image_softproof_intent_actions[] = NC_("image-action", "_Perceptual"), NULL, { NULL }, NC_("image-action", "Soft-proofing rendering intent is perceptual"), GIMP_COLOR_RENDERING_INTENT_PERCEPTUAL, - GIMP_HELP_VIEW_COLOR_MANAGEMENT }, + GIMP_HELP_IMAGE_SOFT_PROOF_RENDERING_INTENT }, { "image-softproof-intent-relative-colorimetric", NULL, NC_("image-action", "_Relative Colorimetric"), NULL, { NULL }, NC_("image-action", "Soft-proofing rendering intent is relative colorimetric"), GIMP_COLOR_RENDERING_INTENT_RELATIVE_COLORIMETRIC, - GIMP_HELP_VIEW_COLOR_MANAGEMENT }, + GIMP_HELP_IMAGE_SOFT_PROOF_RENDERING_INTENT }, { "image-softproof-intent-saturation", NULL, NC_("image-action", "_Saturation"), NULL, { NULL }, NC_("image-action", "Soft-proofing rendering intent is saturation"), GIMP_COLOR_RENDERING_INTENT_SATURATION, - GIMP_HELP_VIEW_COLOR_MANAGEMENT }, + GIMP_HELP_IMAGE_SOFT_PROOF_RENDERING_INTENT }, { "image-softproof-intent-absolute-colorimetric", NULL, NC_("image-action", "_Absolute Colorimetric"), NULL, { NULL }, NC_("image-action", "Soft-proofing rendering intent is absolute colorimetric"), GIMP_COLOR_RENDERING_INTENT_ABSOLUTE_COLORIMETRIC, - GIMP_HELP_VIEW_COLOR_MANAGEMENT } + GIMP_HELP_IMAGE_SOFT_PROOF_RENDERING_INTENT } }; diff --git a/app/widgets/gimphelp-ids.h b/app/widgets/gimphelp-ids.h index 48a8d137ca..6dfaa9274b 100644 --- a/app/widgets/gimphelp-ids.h +++ b/app/widgets/gimphelp-ids.h @@ -169,6 +169,10 @@ #define GIMP_HELP_IMAGE_COLOR_PROFILE_USE_SRGB "gimp-image-color-profile-use-srgb" #define GIMP_HELP_IMAGE_COLOR_PROFILE_SAVE "gimp-image-color-profile-save" #define GIMP_HELP_IMAGE_COLOR_PROFILE_IMPORT "gimp-image-color-profile-import" +#define GIMP_HELP_IMAGE_SOFT_PROOF_PROFILE_ASSIGN "gimp-image-soft-proof-profile-assign" +#define GIMP_HELP_IMAGE_SOFT_PROOF_BLACK_POINT "gimp-image-soft-proof-black-point" +#define GIMP_HELP_IMAGE_SOFT_PROOF_RENDERING_INTENT "gimp-image-soft-proof-rendering-intent" + #define GIMP_HELP_IMAGE_METADATA_ROTATION_IMPORT "gimp-image-metadata-rotation-import" #define GIMP_HELP_IMAGE_GRID "gimp-image-grid" #define GIMP_HELP_IMAGE_PROPERTIES "gimp-image-properties"