dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

app/tools: Fix ordering of selection mode options

Browse source 
In 046c8f27, we added a new function
gimp_selection_options_get_mode_box () so that the
Paint Select tool would use the same enum as other
selection tools. Code was added to move the
GIMP_CHANNEL_OP_REPLACE enum to the front only if
it was greater than the min value and less than the max value
that was passed in. This was to allow the Paint Select tool to
keep GIMP_CHANNEL_OP_ADD at the front while leaving the
other selection tools as they are.

However, the original call used 0, 0 for those values, so the
rearrangement code never ran at all. This patch changes the
parameter max value to GIMP_CHANNEL_OP_INTERSECT so
that Replace is moved for non-Paint Select tools.
This commit is contained in:
Alx Sa 2026-03-09 10:26:46 +00:00
parent 8e4e83911c
commit c2f87513d6
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/tools/gimpselectionoptions.c
View file

@ -187,7 +187,9 @@ gimp_selection_options_gui (GimpToolOptions *tool_options)
GtkWidget *mode_box;
/* the selection operation radio buttons */
mode_box = gimp_selection_options_get_mode_box (tool_options, 0, 0);
mode_box = gimp_selection_options_get_mode_box (tool_options,
GIMP_CHANNEL_OP_ADD,
GIMP_CHANNEL_OP_INTERSECT);
gtk_box_pack_start (GTK_BOX (vbox), mode_box, FALSE, FALSE, 0);
gtk_widget_show (mode_box);
options->mode_box = mode_box;