dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

app, libgimp, pdb: use deprecated and deprecated_since rather than…

Browse source 
… std_pdb_deprecated for previously deprecated functions.

The &std_pdb_deprecated() call won't set a "Deprecated since"
information since this can't be made generic anyway. We have the info,
it'd be a shame not to document it!

Also it clears the blurb and help string, which I find unhelpful (even
for deprecated functions, it's better to have proper documentation!).
This commit is contained in:
Jehan 2026-02-01 22:40:27 +01:00
parent 98e71ee34e
commit b590dc1a2f
3 changed files with 39 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
app/pdb/drawable-select-cmds.c
View file

@ -140,13 +140,15 @@ register_drawable_select_procs (GimpPDB *pdb)
gimp_object_set_static_name (GIMP_OBJECT (procedure),
"gimp-drawables-popup");
gimp_procedure_set_static_help (procedure,
"Deprecated: Use 'gimp-items-popup' instead.",
"Invokes the drawable selection dialog.",
"Opens a dialog letting a user choose an drawable.\n"
"\n"
"Deprecated: Use 'gimp-items-popup' instead.",
NULL);
gimp_procedure_set_static_attribution (procedure,
"",
"",
"");
"Jehan",
"Jehan",
"2023");
gimp_procedure_set_deprecated (procedure,
"gimp-items-popup");
gimp_procedure_add_argument (procedure,
@ -192,13 +194,15 @@ register_drawable_select_procs (GimpPDB *pdb)
gimp_object_set_static_name (GIMP_OBJECT (procedure),
"gimp-drawables-close-popup");
gimp_procedure_set_static_help (procedure,
"Deprecated: Use 'gimp-items-close-popup' instead.",
"Close the drawable selection dialog.",
"Closes an open drawable selection dialog.\n"
"\n"
"Deprecated: Use 'gimp-items-close-popup' instead.",
NULL);
gimp_procedure_set_static_attribution (procedure,
"",
"",
"");
"Jehan",
"Jehan",
"2023");
gimp_procedure_set_deprecated (procedure,
"gimp-items-close-popup");
gimp_procedure_add_argument (procedure,
@ -218,13 +222,15 @@ register_drawable_select_procs (GimpPDB *pdb)
gimp_object_set_static_name (GIMP_OBJECT (procedure),
"gimp-drawables-set-popup");
gimp_procedure_set_static_help (procedure,
"Deprecated: Use 'gimp-items-set-popup' instead.",
"Sets the selected drawable in a drawable selection dialog.",
"Sets the selected drawable in a drawable selection dialog.\n"
"\n"
"Deprecated: Use 'gimp-items-set-popup' instead.",
NULL);
gimp_procedure_set_static_attribution (procedure,
"",
"",
"");
"Jehan",
"Jehan",
"2023");
gimp_procedure_set_deprecated (procedure,
"gimp-items-set-popup");
gimp_procedure_add_argument (procedure,

18
libgimp/gimpdrawableselect_pdb.c
View file

@ -44,7 +44,11 @@
* @initial_drawable: (nullable): The drawable to set as the initial choice.
* @parent_window: (nullable): An optional parent window handle for the popup to be set transient to.
*
* Deprecated: : Use gimp_items_popup() instead.
* Invokes the drawable selection dialog.
*
* Opens a dialog letting a user choose an drawable.
*
* Deprecated: 3.2: Use gimp_items_popup() instead.
*
* Returns: TRUE on success.
**/
@ -83,7 +87,11 @@ gimp_drawables_popup (const gchar *callback,
* gimp_drawables_close_popup:
* @callback: The name of the callback registered for this pop-up.
*
* Deprecated: : Use gimp_items_close_popup() instead.
* Close the drawable selection dialog.
*
* Closes an open drawable selection dialog.
*
* Deprecated: 3.2: Use gimp_items_close_popup() instead.
*
* Returns: TRUE on success.
**/
@ -115,7 +123,11 @@ gimp_drawables_close_popup (const gchar *callback)
* @callback: The name of the callback registered for this pop-up.
* @drawable: The drawable to set as selected.
*
* Deprecated: : Use gimp_items_set_popup() instead.
* Sets the selected drawable in a drawable selection dialog.
*
* Sets the selected drawable in a drawable selection dialog.
*
* Deprecated: 3.2: Use gimp_items_set_popup() instead.
*
* Returns: TRUE on success.
**/

9
pdb/groups/drawable_select.pdb
View file

@ -19,7 +19,8 @@ sub drawables_popup {
$help = 'Opens a dialog letting a user choose an drawable.';
&jehan_pdb_misc('2023');
&std_pdb_deprecated ('gimp-items-popup');
$deprecated = 'gimp-items-popup';
$deprecated_since = '3.2';
@inargs = (
{ name => 'callback', type => 'string', non_empty => 1,
@ -55,7 +56,8 @@ sub drawables_close_popup {
$help = 'Closes an open drawable selection dialog.';
&jehan_pdb_misc('2023');
&std_pdb_deprecated ('gimp-items-close-popup');
$deprecated = 'gimp-items-close-popup';
$deprecated_since = '3.2';
@inargs = (
{ name => 'callback', type => 'string', non_empty => 1,
@ -79,7 +81,8 @@ sub drawables_set_popup {
$help = $blurb;
&jehan_pdb_misc('2023');
&std_pdb_deprecated ('gimp-items-set-popup');
$deprecated = 'gimp-items-set-popup';
$deprecated_since = '3.2';
@inargs = (
{ name => 'callback', type => 'string', non_empty => 1,