dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

libgimpcolor: create gegl buffers with gegl_buffer_new instead of gegl_buffer_linear_new_from_data

Browse source 
Creating a gegl buffer from some data (e.g. cairo surface) through gegl_buffer_linear_new_from_data
causes crashes if the cairo surface is too big, because the gegl buffer will have only one huge tile
so tile_size will overflow if surface size > INT_MAX. Using the appropriate api, gegl will calculate
tile size and create the needed tiles automatically.
This commit is contained in:
Idriss Fekir 2025-09-30 22:07:10 +02:00 committed by Jehan
parent 5d03bb847e
commit ade0bdc487
1 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
libgimpcolor/gimpcairo.c
View file

@ -176,8 +176,8 @@ GeglBuffer *
gimp_cairo_surface_create_buffer (cairo_surface_t *surface,
const Babl *format)
{
gint width;
gint height;
GeglBuffer *buffer;
GeglRectangle extent = {0};
g_return_val_if_fail (surface != NULL, NULL);
g_return_val_if_fail (cairo_surface_get_type (surface) ==
@ -188,14 +188,12 @@ gimp_cairo_surface_create_buffer (cairo_surface_t *surface,
if (format == NULL)
format = gimp_cairo_surface_get_format (surface);
width = cairo_image_surface_get_width (surface);
height = cairo_image_surface_get_height (surface);
extent.width = cairo_image_surface_get_width (surface);
extent.height = cairo_image_surface_get_height (surface);
return
gegl_buffer_linear_new_from_data (cairo_image_surface_get_data (surface),
format,
GEGL_RECTANGLE (0, 0, width, height),
cairo_image_surface_get_stride (surface),
(GDestroyNotify) cairo_surface_destroy,
cairo_surface_reference (surface));
buffer = gegl_buffer_new (&extent, format);
gegl_buffer_set (buffer, &extent, 0, format, cairo_image_surface_get_data (surface), cairo_image_surface_get_stride (surface));
return buffer;
}