From ad936482a2238e999caa52ff69e89599bdcef6b3 Mon Sep 17 00:00:00 2001 From: Jehan Date: Wed, 25 Feb 2026 23:38:15 +0100 Subject: [PATCH] Revert "Issue #15824: waterpixels filter on a selection appears to hang GIMP." MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit d91a8b2abec31a52071cb0956580375ae9c25992. As reported by Liam on #15824, this commit was clearly wrong and reintroduced the old cropping bug with multiple filters. Reverting. The next commit was likely good, though the real hanging bug is — as far as my test go — in the GEGL op itself. This second commit 75e665f0ed was improving things, but obviously, as the bug is still in the op, it can still be triggered. We'll have to fix the source bug next. --- app/core/gimpdrawablefilter.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/app/core/gimpdrawablefilter.c b/app/core/gimpdrawablefilter.c index f9b084a95a..d882b15965 100644 --- a/app/core/gimpdrawablefilter.c +++ b/app/core/gimpdrawablefilter.c @@ -1460,11 +1460,16 @@ gimp_drawable_filter_sync_region (GimpDrawableFilter *filter) "y", (gdouble) -filter->filter_area.y, NULL); - gegl_node_set (filter->crop_before, - "operation", "gegl:crop", - "width", (gdouble) filter->filter_area.width, - "height", (gdouble) filter->filter_area.height, - NULL); + if (first_filter) + gegl_node_set (filter->crop_before, + "operation", "gegl:crop", + "width", (gdouble) filter->filter_area.width, + "height", (gdouble) filter->filter_area.height, + NULL); + else + gegl_node_set (filter->crop_before, + "operation", "gegl:nop", + NULL); } if (filter->filter_clip)