dallasgroot/Gimp
dallasgroot/Gimp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plug-ins/file-sgi: Quickfix for -Wtype-limits warnings

Browse source 
Quickfix for "warning: comparison is always false due to limited range
of data type".
This commit is contained in:
Martin Nordholts 2010-10-05 08:04:17 +02:00
parent cc7755f876
commit 9d0e69d43b
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
plug-ins/file-sgi/sgi.c
View file

@ -333,22 +333,24 @@ load_image (const gchar *filename,
* Get the image dimensions and create the image...
*/
/* Sanitize dimensions */
if (sgip->xsize == 0 || sgip->xsize > GIMP_MAX_IMAGE_SIZE)
/* Sanitize dimensions (note that they are unsigned short and can
* thus never be larger than GIMP_MAX_IMAGE_SIZE
*/
if (sgip->xsize == 0 /*|| sgip->xsize > GIMP_MAX_IMAGE_SIZE*/)
{
g_set_error (error, G_FILE_ERROR, G_FILE_ERROR_FAILED,
_("Invalid width: %hu"), sgip->xsize);
return -1;
}
if (sgip->ysize == 0 || sgip->ysize > GIMP_MAX_IMAGE_SIZE)
if (sgip->ysize == 0 /*|| sgip->ysize > GIMP_MAX_IMAGE_SIZE*/)
{
g_set_error (error, G_FILE_ERROR, G_FILE_ERROR_FAILED,
_("Invalid height: %hu"), sgip->ysize);
return -1;
}
if (sgip->zsize == 0 || sgip->zsize > GIMP_MAX_IMAGE_SIZE)
if (sgip->zsize == 0 /*|| sgip->zsize > GIMP_MAX_IMAGE_SIZE*/)
{
g_set_error (error, G_FILE_ERROR, G_FILE_ERROR_FAILED,
_("Invalid number of channels: %hu"), sgip->zsize);