From 8ff7102557447487a3b8d4ced4db2dedf72ed506 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20M=C3=ADchal?= Date: Wed, 18 Jun 2025 20:24:36 +0300 Subject: [PATCH] Clarify minimal widget sizes in procedure/plugin browser Using an explicit value of width for the height of the dialog window makes little sense. This makes the size of the dialog window clear. And now the height of the list widget is set with its own macro instead of piggybacking on the dialog window height. --- libgimp/gimpprocbrowserdialog.c | 13 +++++++------ plug-ins/common/plugin-browser.c | 13 +++++++------ 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/libgimp/gimpprocbrowserdialog.c b/libgimp/gimpprocbrowserdialog.c index e69888f336..12274fd32b 100644 --- a/libgimp/gimpprocbrowserdialog.c +++ b/libgimp/gimpprocbrowserdialog.c @@ -45,9 +45,10 @@ **/ -#define DBL_LIST_WIDTH 250 -#define DBL_WIDTH (DBL_LIST_WIDTH + 400) -#define DBL_HEIGHT 250 +#define DBL_LIST_WIDTH 250 +#define DBL_LIST_HEIGHT 250 +#define DBL_WIDTH 650 +#define DBL_HEIGHT 400 enum @@ -144,8 +145,8 @@ gimp_proc_browser_dialog_init (GimpProcBrowserDialog *dialog) GtkTreeSelection *selection; GtkWidget *parent; - gtk_window_set_default_size (GTK_WINDOW (dialog), DBL_WIDTH, - DBL_WIDTH - DBL_LIST_WIDTH); + gtk_window_set_default_size (GTK_WINDOW (dialog), + DBL_WIDTH, DBL_HEIGHT); dialog->browser = gimp_browser_new (); gimp_browser_add_search_types (GIMP_BROWSER (dialog->browser), @@ -195,7 +196,7 @@ gimp_proc_browser_dialog_init (GimpProcBrowserDialog *dialog) G_CALLBACK (browser_row_activated), dialog); - gtk_widget_set_size_request (dialog->tree_view, DBL_LIST_WIDTH, DBL_HEIGHT); + gtk_widget_set_size_request (dialog->tree_view, DBL_LIST_WIDTH, DBL_LIST_HEIGHT); gtk_container_add (GTK_CONTAINER (scrolled_window), dialog->tree_view); gtk_widget_show (dialog->tree_view); diff --git a/plug-ins/common/plugin-browser.c b/plug-ins/common/plugin-browser.c index 75a60d480c..fa90bed7a0 100644 --- a/plug-ins/common/plugin-browser.c +++ b/plug-ins/common/plugin-browser.c @@ -37,8 +37,9 @@ #define PLUG_IN_BINARY "plugin-browser" #define PLUG_IN_ROLE "gimp-plugin-browser" #define DBL_LIST_WIDTH 250 -#define DBL_WIDTH (DBL_LIST_WIDTH + 400) -#define DBL_HEIGHT 250 +#define DBL_LIST_HEIGHT 250 +#define DBL_WIDTH 650 +#define DBL_HEIGHT 400 enum @@ -562,8 +563,8 @@ browser_dialog_new (void) _("_Close"), GTK_RESPONSE_CLOSE, NULL); - gtk_window_set_default_size (GTK_WINDOW (browser->dialog), DBL_WIDTH, - DBL_WIDTH - DBL_LIST_WIDTH); + gtk_window_set_default_size (GTK_WINDOW (browser->dialog), + DBL_WIDTH, DBL_HEIGHT); g_signal_connect (browser->dialog, "response", G_CALLBACK (browser_dialog_response), @@ -641,7 +642,7 @@ browser_dialog_new (void) gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (scrolled_window), GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC); - gtk_widget_set_size_request (list_view, DBL_LIST_WIDTH, DBL_HEIGHT); + gtk_widget_set_size_request (list_view, DBL_LIST_WIDTH, DBL_LIST_HEIGHT); selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (list_view)); gtk_tree_selection_set_mode (selection, GTK_SELECTION_BROWSE); @@ -703,7 +704,7 @@ browser_dialog_new (void) GTK_SHADOW_IN); gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (scrolled_window), GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC); - gtk_widget_set_size_request (tree_view, DBL_LIST_WIDTH, DBL_HEIGHT); + gtk_widget_set_size_request (tree_view, DBL_LIST_WIDTH, DBL_LIST_HEIGHT); selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (tree_view)); gtk_tree_selection_set_mode (selection, GTK_SELECTION_BROWSE);