From 87810ae6fe9d5f27d7805ecfb6a7aebe68cd2833 Mon Sep 17 00:00:00 2001 From: Jehan Date: Tue, 24 Feb 2026 01:25:24 +0100 Subject: [PATCH] app: make explicit that "White Balance" auto effect works in linear space. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit doesn't actually changes anything, but it fixes the gimp_histogram_new() call, since the argument is supposed to be a GimpTRCType, not a boolean. Yet GIMP_TRC_LINEAR is the first value in the enum type, so it's indeed the same as FALSE. I also set the "trc" property to "gimp:levels" config object explicitly, to the same TRC value as the histogram, so that this doesn't depend on the default anymore (which is linear too, right now; so this part doesn't change a thing here again), and therefore would survive to any possible default change in the future. Note that it was considered to set this all to non-linear, just as it used to be in 2.10, as requested in #15738. After discussing it with Øyvind on IRC, we concluded that working in linear space may be a nicer default for this feature, as we'd be doing a "meaningful rebalancing of photon count per component". Now there may be cases where doing a white-balancing in non-linear may yield better result, of course. For these case, you may still go to "Levels", set to non-linear, and hit "Auto Input Levels". This is exactly the same code runing (but in non-linear space). The "White Balance" action still needs to be the simple non-GUI option and keeping work in linear seems like the more appropriate default here. --- app/core/gimpdrawable-levels.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/core/gimpdrawable-levels.c b/app/core/gimpdrawable-levels.c index 301326b8d2..a8c164d25a 100644 --- a/app/core/gimpdrawable-levels.c +++ b/app/core/gimpdrawable-levels.c @@ -43,6 +43,7 @@ gimp_drawable_levels_stretch (GimpDrawable *drawable, GimpLevelsConfig *config; GimpHistogram *histogram; GeglNode *levels; + GimpTRCType trc = GIMP_TRC_LINEAR; g_return_if_fail (GIMP_IS_DRAWABLE (drawable)); g_return_if_fail (gimp_item_is_attached (GIMP_ITEM (drawable))); @@ -51,9 +52,9 @@ gimp_drawable_levels_stretch (GimpDrawable *drawable, if (! gimp_item_mask_intersect (GIMP_ITEM (drawable), NULL, NULL, NULL, NULL)) return; - config = g_object_new (GIMP_TYPE_LEVELS_CONFIG, NULL); + config = g_object_new (GIMP_TYPE_LEVELS_CONFIG, "trc", trc, NULL); - histogram = gimp_histogram_new (FALSE); + histogram = gimp_histogram_new (trc); gimp_drawable_calculate_histogram (drawable, histogram, FALSE); gimp_levels_config_stretch (config, histogram,