From 8470ec8b1001e50b17d29fb2a1eea259018c2cba Mon Sep 17 00:00:00 2001 From: Jehan Date: Wed, 13 Aug 2025 18:40:00 +0200 Subject: [PATCH] libgimpbase: add a #warning to be activated when we move on to GIMP 4. The name GIMP_METADATA_SAVE_UPDATE does feel a bit ugly but we need to keep the GIMP_METADATA_SAVE_ prefix, otherwise we would break the GIR bindings. cf. commit 27fead082a. Make a warning for ourselves to happen when we are closing onto GIMP 4. Then we can make a decision whether or not we want to rename this enum value. --- libgimpbase/gimpmetadata.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libgimpbase/gimpmetadata.c b/libgimpbase/gimpmetadata.c index b0948b29c2..0f2692f026 100644 --- a/libgimpbase/gimpmetadata.c +++ b/libgimpbase/gimpmetadata.c @@ -31,6 +31,7 @@ #include "libgimpmath/gimpmath.h" #include "gimpbasetypes.h" +#include "gimpversion.h" #include "gimplimits.h" #include "gimpmetadata.h" @@ -39,6 +40,11 @@ #include "libgimp/libgimp-intl.h" + +#if GIMP_CHECK_VERSION(3, 99, 0) +#warning libgimpbase/gimpmetadata.h: rename GIMP_METADATA_SAVE_UPDATE as GIMP_METADATA_UPDATE? +#endif + /** * SECTION: gimpmetadata * @title: GimpMetadata